Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Saleem, Shiraz" <shiraz.saleem@intel.com>
To:     Tejun Heo <tj@kernel.org>,
        "Ismail, Mustafa" <mustafa.ismail@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>
CC:     Leon Romanovsky <leon@kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-team@fb.com" <kernel-team@fb.com>
Subject: RE: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from
 alloc_ordered_workqueue() call
Thread-Topic: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from
 alloc_ordered_workqueue() call
Thread-Index: AQHZc8EQp4z6xXqwzkCZnEExjd5iQa8105dg
Date:   Fri, 21 Apr 2023 14:29:06 +0000
Message-ID: <MWHPR11MB0029F5F9C9AC249F2BC3E981E9609@MWHPR11MB0029.namprd11.prod.outlook.com>
References: <ZEGW-IcFReR1juVM@slm.duckdns.org>
In-Reply-To: <ZEGW-IcFReR1juVM@slm.duckdns.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Zom37mk2BgcBjqW94HUDX0MZ5teVGeo6O1SQZjarz1GEsaNyIrc5i8soeI+Q?=
 =?us-ascii?Q?KddyzL/QsLsFIWuIPttEpvSHtLf8oLgW/PhZ7hW4p2dMv5VQhOIP+nnr+u7h?=
 =?us-ascii?Q?bPsJwsJwJGxCqPjeJiW6+EyRwrR/XCI16PZNdsf/CxruKvdpdScQkXXfJXDx?=
 =?us-ascii?Q?ZrFEfecG1oZK0xetiB41nlaA50mpBuEZ7dSwFy2XlDTjLad3RRr4lEyiDZhB?=
 =?us-ascii?Q?QAhgLhYp/UtizZ3vtBymcfYGpLHid7H8VnA8K9knJPmfItPiM7Ewv7GB4orn?=
 =?us-ascii?Q?YU/veDNcZdpGGgBb0fwtSf6AehZPuMh5ApS2O+NBO/xUXEqF41GyrwHfmERk?=
 =?us-ascii?Q?LBsjLxwDFWmO7r1urcI+r27bltf2EjBnEDVRROz+cTjNsChPj2KjfuhLssRj?=
 =?us-ascii?Q?l4HVtd5EwBtt/pQYRa5lgRH5I83wr0WKJdzqfYwe726JHJVfkG/1fYYyZXJr?=
 =?us-ascii?Q?imd+iyuU39QWIsuvm4zbmCTFwX/yBcpPmxbN4F8A8No/cZ4buXU9vj73i6Nw?=
 =?us-ascii?Q?pw5OkqiWZEug5RDsQCY+WOlv4/BpUdIPbqe00geP8EuYWZ1QuHBLnQ+deGnz?=
 =?us-ascii?Q?VVeJv+WaDlTupDaSe0wO195xJzKp1i5W/xd/J+2IDI/okobixA+xRq9zyUSp?=
 =?us-ascii?Q?0xvRx+PRkhZHz+bSrBL9TL9vGnioyxIBx7CMCu7/FS51SksUWa6g8r5rVL3S?=
 =?us-ascii?Q?s4CV9mqbxZRSh7WdFaHMa4swbk5EL3PMGE7AUib591G/FkOmVKjbmDxjuuv8?=
 =?us-ascii?Q?EBmOSaGVk+Kb6Te5Ym/vphF/NY6MOg+bl3zrNb+YEaLkMkRBpGrQWN5bnR4m?=
 =?us-ascii?Q?DBFF561K23mDE/svqmpE+/A56+plBUgeRTDsDyGaaT9InLKHgdWsL0oS43s5?=
 =?us-ascii?Q?ZOX6/UFaUgzd5GCM8Ch2QMtRk5Kd/LJ39GvdcB22SptRmm50mwH2IwTh3uU2?=
 =?us-ascii?Q?JoZUaKUY91Iysvlh1eVVEigesgirCiiUhptbbV85OoVhMGvvJla/h3eIpOUu?=
 =?us-ascii?Q?eepm3rjwOy+d8FrC2BwgX254n9d1v/DjrdCa7Cza5Iydb7HDP9uHSxXx+0ge?=
 =?us-ascii?Q?G0ayc1ji4X+IwzPGi9BSAFyGAe6MfAuhh1sM3YCpPmtjQE+9N9YNsk/FfJDC?=
 =?us-ascii?Q?lMuFCueqDEfZ6V+hdcLL5G4YEc08anxoE0RfVT4vfFacp7HNPLmp9ozVWvBP?=
 =?us-ascii?Q?B47iboQqzVGob2vPY5JHu5KI/YW5qL2+ibw0hNvcmQa5VizQQHavKjfd8JmW?=
 =?us-ascii?Q?QKQxEmDcPfEhyY3XTbBVo+faY9VAVXuHuSYdQS2ItC7zGrS1no6scVEI52yj?=
 =?us-ascii?Q?fCyTSPyBNM2fP1gTrA+OMYpt4OhbHVFO1qr8Ssk/B1vFyIEv6U/FzOSE40AZ?=
 =?us-ascii?Q?BUfxJ/WHxTErGMOsoKfn9yAzUtszBIZplqGNOoX9Jc792TeAw0z0hPAfarx0?=
 =?us-ascii?Q?BPcThGu1qM12ZyhQ6VT4DAlVZ+nEhh4dFz5KxlDwEcMNGPxN/m0Qv4nEHmX1?=
 =?us-ascii?Q?AuhFD4VYZT1/8VwdLNtzxuCv0v6zw+doKiF9ObQVva8CUL81oMJT+WJNIy+o?=
 =?us-ascii?Q?JN/4k8BKBRLSs4EeNTCcR7aC7XV8L93S92iN4abL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0029.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a18aeff7-7219-44fa-3b55-08db4274c3aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2023 14:29:06.9198
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KE7WDC3AX27SXFhra1KKY/wizhE08moPeEh1XakXAkAI/2ZOLVt86B6RxOMoEcmrkWSqwJW35IHc9sgV88SUFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5805
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from
> alloc_ordered_workqueue() call
>=20
> Workqueue is in the process of cleaning up the distinction between unboun=
d
> workqueues w/ @nr_active=3D=3D1 and ordered workqueues. Explicit
> WQ_UNBOUND isn't needed for alloc_ordered_workqueue() and will trigger a
> warning in the future. Let's remove it. This doesn't cause any functional
> changes.
>=20
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
>  drivers/infiniband/hw/irdma/hw.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> --- a/drivers/infiniband/hw/irdma/hw.c
> +++ b/drivers/infiniband/hw/irdma/hw.c
> @@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_
>  			break;
>  		rf->init_state =3D CEQ0_CREATED;
>  		/* Handles processing of CQP completions */
> -		rf->cqp_cmpl_wq =3D alloc_ordered_workqueue("cqp_cmpl_wq",
> -						WQ_HIGHPRI |
> WQ_UNBOUND);
> +		rf->cqp_cmpl_wq =3D
> +			alloc_ordered_workqueue("cqp_cmpl_wq",
> WQ_HIGHPRI);
>  		if (!rf->cqp_cmpl_wq) {
>  			status =3D -ENOMEM;
>  			break;

Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>