Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 11:30:13 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     liulongfang <liulongfang@huawei.com>
Cc:     alex.williamson@redhat.com, shameerali.kolothum.thodi@huawei.com,
        jonathan.cameron@huawei.com, cohuck@redhat.com,
        linux-kernel@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [PATCH v10 5/5] vfio: update live migration device status
Message-ID: <ZEKd9Rnt9rT0aAHh@nvidia.com>
References: <20230408074224.62608-1-liulongfang@huawei.com>
 <20230408074224.62608-6-liulongfang@huawei.com>
 <ZDlGOlGqo2ZHDFm3@nvidia.com>
 <fe02f34a-c3d9-056a-3081-58605e8e1247@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fe02f34a-c3d9-056a-3081-58605e8e1247@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+X72Ae7UoztZWIKU39kQwvweI7VW4DkSv3U1/wkX/6CT+I+VdNbRwHXN0t6w?=
 =?us-ascii?Q?rFJYzVymuNwaDr055PA4PMclQXjhqJeRP4hZ3OePiRDu7aXe8otTe7q8YK1R?=
 =?us-ascii?Q?AhaXudz7wGocHA6s4BuYqBos3uz6UecooIzrpk99au0Tu8FLxGTzU0K/DzHY?=
 =?us-ascii?Q?+y4Cl2lSVKzfDkd3nFMv6Hdk3GeYXIoENo+SuHGuSB1PWDkjwUUD9zimhCc8?=
 =?us-ascii?Q?Bj0+nw6Tg8pVi5LXHnTkG2TpJo3D/G949jktCCwPF/k7l1L2PEgWp0ezcBOo?=
 =?us-ascii?Q?ONwi8C5LnXOV1iwQSbGawUN8hWDfnB42tsKiyyDs0rN1DCB+x4Zon6e53qoM?=
 =?us-ascii?Q?ME8R7Wt+xlez3f704ZOtO/tGmvXRLO8KqK3U8GGCfva/4VwYTb7bZsCzPodc?=
 =?us-ascii?Q?G/VNMtUgOf7aaBoIi3tANd0y3NmxitKN5N8mee2d+DCyNpLjLnFe+UGTmlO4?=
 =?us-ascii?Q?JOgq5EvtOsTLwpauQdIlHrConUvemM5yKQCXuU+ljKGJ9f6dve+kxCHOjBPn?=
 =?us-ascii?Q?gdsXMd+V+WO6U7MqFGfiP4cmN2F/zA2HDALyfJOx0PkYZkZw0zcTUIhDiwDg?=
 =?us-ascii?Q?bKDweOwmfFSTvptKy2MkaG6FGo6FiB3vjVsvq45W+ZXwsL7PTBll+yr3n+U1?=
 =?us-ascii?Q?ALQYfu5NVTpFmz6c+/zZbXgTPXDYsArLdDOFcBhwHoxX1Z7i5TZVN22sN37k?=
 =?us-ascii?Q?me2HADFJpoexpmRxqCduh9R51BZiyCs/VNi/krOWY8uvSUvA8HyeVa9iWVxU?=
 =?us-ascii?Q?nTGRAiObbCIvSPicXAnP0+ldzQA+6w3Lg+zoKVT2E3+aF80aB/7DyJViYd/B?=
 =?us-ascii?Q?DxeSkc/Up4i8ghzFjIh2ctlrfemxtPB7mvXx4EKzTlyl4u93ikRuTywCzGNI?=
 =?us-ascii?Q?bOqY6GELTjzMEozgPgiM/z7umNZD6n6qt+eUxkG1Q9gOi0M9UZnlw0uwKymP?=
 =?us-ascii?Q?aFIe9iqjUq+vv3AG3wrxvxSz4Hh4QCUYv1wYjgAtdMxWpFzwTeHF+6n3Y3KF?=
 =?us-ascii?Q?9x9V1rRPSAjFEk125orIXlW6hXmQov0F6QgoqP+SIQdGQJdVmXdPsKtvo6vU?=
 =?us-ascii?Q?gBXaWknyTgaHEoaFGoNcMEnH1co11b8qS8GixNltFXIktyGVan/e3jBPOspi?=
 =?us-ascii?Q?eezofJyx/MpRsbhomW5JpfzKn/SUUaQhJ6PdnI3pA8De2m/qNWCCyVQzSlH5?=
 =?us-ascii?Q?ogIgH25EokvzNTJxCGQPJBJQXHnET8uOMYVI/lk9YNFiERTGZj/iu0+FQ8O/?=
 =?us-ascii?Q?3ePYq2JCJBKXf+EknTWnrE3Z3JaS2rGEEIn1bYfhh10koqSDXp7PK77mxiri?=
 =?us-ascii?Q?xNaD7NxKrMzTj4YRCyqGWjZcTktL15A9CKLBwSCdQ9WRspWaYSMmcDC/A/ME?=
 =?us-ascii?Q?yZd42cxPM3+d1H9uSqGZKOMJCQUHTvgNW45tJOdPzi7Lb+KO7bDl2ZKAPiZy?=
 =?us-ascii?Q?/QKZcIWPt30TABlkvRQ0Xm8XFLVSkrmPYsfk5GoD+F/qIDJFHEhM6UnlztGU?=
 =?us-ascii?Q?xXo7fQWwGPGyL0JuvMZFZGPkVhQmOGo5yphwKEG0AFM4r2tii8rLHqDhccm1?=
 =?us-ascii?Q?roOcEEulnr/UoOQzxnp3WT1EoMTEMgux8UOZFUal?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37e59b3a-1e76-42ed-daac-08db4274ec0f
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2023 14:30:14.8978
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zHWO8LrrUdF6YsdzJ968EJSyg8yH9gSf2jvtcaAssbnWuN1FscequGWTaeM4umWb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6034
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 21, 2023 at 11:07:53AM +0800, liulongfang wrote:
> On 2023/4/14 20:25, Jason Gunthorpe write:
> > On Sat, Apr 08, 2023 at 03:42:24PM +0800, Longfang Liu wrote:
> >> migration debugfs needs to perform debug operations based on the
> >> status of the current device. If the device is not loaded or has
> >> stopped, debugfs does not allow operations.
> >>
> >> so, after the live migration function is executed and the device is
> >> turned off, the device no longer needs to be accessed. At this time,
> >> the status of the device needs to be set to stop.
> > 
> > STOP means the devices isn't functioning
> > > An idle device that has just been reset is RUNNING by definiton.
> > 
> 
> After the vfio device is opened, it will be set to RUNNING, and after it
> is closed, it should be set to STOP according to the function of the
> device.

No, VFIO does not STOP anything, RUNNING means the PCI function is
operating normally, which is always how VFIO leaves it when the FD is
closed.

Jason