Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 11:31:44 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     liulongfang <liulongfang@huawei.com>
Cc:     alex.williamson@redhat.com, shameerali.kolothum.thodi@huawei.com,
        jonathan.cameron@huawei.com, cohuck@redhat.com,
        linux-kernel@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [PATCH v10 3/5] hisi_acc_vfio_pci: register debugfs for
 hisilicon migration driver
Message-ID: <ZEKeUBiLyWWW7E+V@nvidia.com>
References: <20230408074224.62608-1-liulongfang@huawei.com>
 <20230408074224.62608-4-liulongfang@huawei.com>
 <ZDlGC8SUXqKNmfSe@nvidia.com>
 <ca592d60-9a5b-dec3-9565-76cd5c0740e0@huawei.com>
 <81e11acf-0ede-d515-bb5a-3964c302f384@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <81e11acf-0ede-d515-bb5a-3964c302f384@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AHtLpM3dkFrzuJTTH5F9NU1/hRLPp/xqBFFs2Isbzh1GOW5Ako5Ezoc9PO+c?=
 =?us-ascii?Q?kdIJlIkGwtSWmu3YTnbAUnC7rLjglaRZ3SnGVyWvfQjlNrBUYscSBddDO/Ba?=
 =?us-ascii?Q?xrJomWCzB1DwMAVgCMTrluBa0DdQipdK31p3uGqFArZp/I1UYcGmbDAHj5tW?=
 =?us-ascii?Q?+X7HPnesBZgbb/ae4ZRgnMbW8SDdAAvd4rPj/tn31JH5QHQAvVatFxg66IgM?=
 =?us-ascii?Q?GrurJBb1l6Ybqum3GYomhwu25CgR5KjevB94LqdGqzRhpG3d+vzGt0Z3qhFz?=
 =?us-ascii?Q?D8lhRvoXjrt3XxKYTbMjqPlb0kBoimJvmf47CNxwSQtYZGaxviK4e1eq3S7s?=
 =?us-ascii?Q?pCcyno443LAc8H3Fu0zsWA95JJgRzAI5b0PExTxJ7v15u24rzOuoB2gJaL80?=
 =?us-ascii?Q?Spmh5/mMR444trO/6YqEWkp6XbN4YMJy6gxfVu+decJeU+y2PTkz2vAiDqoQ?=
 =?us-ascii?Q?47eOTrX9eX15MLLKx7uG1t/zANghKwC0LJs1c6F6e1DdmbVguJ2sgPJWsfEE?=
 =?us-ascii?Q?ItrUkxC5FG5IpgXGYKR9By/qjrCvQla/umjoJ3vUlqxQokzRB9gjDIQR0Q8U?=
 =?us-ascii?Q?2t05nmVae54kdSWkn3R9ltaG+ziExN9Hcm1/lIKlMOv8S/I8PzW2C+q6QcEl?=
 =?us-ascii?Q?akrvj/g5oR9NikPsshpNObUt01B/oCQrRZa6xWC7yFRpfEB3hp9vwWjXoxDA?=
 =?us-ascii?Q?wiWaVUXYr00vhhcb33joS3qe87qXvSXrm72+l2VGZpwxcsyJhz4OHFb1HF3W?=
 =?us-ascii?Q?B0AW7KqOPrdUX5S7tBtb5ZeYCSZp0QoWgO5mKo3CTjbslZfNi2ffJ+y4Ni4l?=
 =?us-ascii?Q?dHxbSZojazYFwSFomf0FEU8fsTDEYGFHCpk4jG8x9Q9w8egCjkFiq0gf8agF?=
 =?us-ascii?Q?ZiQ9PkOHiApxb6MJEi5q0MAwGl5tpYA4yneHF0pndpJQmHeKs+jUsiaThHMC?=
 =?us-ascii?Q?dHC8nPxyPbWatqBaUuL8Eg9zb7cLuUGJ1YNqtQumS1hoeh7YzjJQZ5bmm+E6?=
 =?us-ascii?Q?ySiceksrVztJ3KSZ/ruxjW6aLX6xVVYBDdfPnCXS8/gLaVkvpWerau4iRGeN?=
 =?us-ascii?Q?mqeW9rZeWeffSYtiKROp8WRqfJefclROsZpx8FOGSgGr9bCRPAdb43zX7sBd?=
 =?us-ascii?Q?L7RphbxLDX+jHLXCQlWJX8S29iy2693rfmrM5OvzLWz+GwqDgPZhohht7Qy9?=
 =?us-ascii?Q?rRTPGj3m1/iGGfCWP3MN8LKZeYqxpdJjRvcXGb5BteG6deYFT4gddvOBjObz?=
 =?us-ascii?Q?292lgWu3Dt5JHDBPmAW2vNrjlWZdPGed7bEpYD7yLFtA8bH2rfzwTXGeSSSe?=
 =?us-ascii?Q?gUNqOYAoyMvy/nFksQVdeMbf9mEkHbv+gs2eSGp7vuUWY5DO01rdowF6Uajb?=
 =?us-ascii?Q?moa2NZZehMWXq1i0YkZ8VFyCG6dP8bAE1ovmufBuwYBf9+Q5ug+YyjRMkBfs?=
 =?us-ascii?Q?ftJqWx/zWuUkObjE4HefkG/cE6GQiK6WVzRpxZDVI2W2eHmex3tkmJ8I5P/M?=
 =?us-ascii?Q?kV9/wr0dhHGtrB7E0trF8h03I9Np+CGscm+wIT+qPDUILCgasIY2+D9t5M1y?=
 =?us-ascii?Q?twraUyQEjCfojD89AxY+PRXUuwdmkQjbQ6gB+ovq?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fabd883-3838-423b-6aca-08db4275223c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2023 14:31:45.7413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fum1c5B/YPTL0rYyrdXYMiSrLfjFJME6xxiT0ztNAmK18ReyBUtYQ8jqPaHmMFxL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7648
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 21, 2023 at 11:32:47AM +0800, liulongfang wrote:

> Thank you for your suggestion, but the current debugfs method can already
> meet the functional requirements of verification testing and
> problem location.

To be clear, I'm against adding selftest code in this manner. We have
many frameworks for kernel teesting, please pick one and integrate
with it.

Jason