Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-372-g43825cb665-fm-20230411.003-g43825cb6
Mime-Version: 1.0
Message-Id: <5d13e927-3713-4b9e-b007-6be5671d46f2@app.fastmail.com>
In-Reply-To: <20230421130111.4041641-1-tudor.ambarus@linaro.org>
References: <20230421130111.4041641-1-tudor.ambarus@linaro.org>
Date:   Fri, 21 Apr 2023 16:30:40 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Tudor Ambarus" <tudor.ambarus@linaro.org>,
        "Nathan Chancellor" <nathan@kernel.org>,
        "Nick Desaulniers" <ndesaulniers@google.com>,
        "Tom Rix" <trix@redhat.com>,
        "Andrew Morton" <akpm@linux-foundation.org>
Cc:     joneslee@google.com, "Peter Zijlstra" <peterz@infradead.org>,
        "Kees Cook" <keescook@chromium.org>,
        "Josh Poimboeuf" <jpoimboe@kernel.org>, zhaoyang.huang@unisoc.com,
        "Liam R. Howlett" <liam.howlett@oracle.com>,
        "Randy Dunlap" <rdunlap@infradead.org>,
        "Geert Uytterhoeven" <geert+renesas@glider.be>,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        "Mark Brown" <broonie@kernel.org>,
        "Dmitry Vyukov" <dvyukov@google.com>, nogikh@google.com
Subject: Re: [PATCH] Kconfig.debug: disable CONFIG_FRAME_WARN for KASAN_STACK &&
 CC_IS_CLANG by default
Content-Type: text/plain
Precedence: bulk

On Fri, Apr 21, 2023, at 15:01, Tudor Ambarus wrote:

> The conclusion is that when KASAN is enabled the stack usage increases a
> bit, but nothing unmanageable ~30-70 bytes, whereas when enabling
> KASAN_STACK the stack usage is excessive, from ~1.7K to ~5.8K for these
> cases.
>
> Disable CONFIG_FRAME_WARN for KASAN_STACK && CC_IS_CLANG by default.
> Adventurers can still override the default value by input prompt or
> explicit values in defconfigs in case they feel that some real warnings
> are missed.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>

I think we are still better off with the warning enabled. When someone
really wants to run a kernel with KASAN_STACK enabled, they should have
a chance to see what they are getting into and not report any runtime
bugs that come from stack overflow. 

      Arnd