Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 15:32:58 +0100
From:   Mel Gorman <mgorman@techsingularity.net>
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     linux-mm@kvack.org, Kaiyang Zhao <kaiyang2@cs.cmu.edu>,
        Vlastimil Babka <vbabka@suse.cz>,
        David Rientjes <rientjes@google.com>,
        linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [RFC PATCH 13/26] mm: compaction: remove compaction result
 helpers
Message-ID: <20230421143258.c24oytksvehbqs5w@techsingularity.net>
References: <20230418191313.268131-1-hannes@cmpxchg.org>
 <20230418191313.268131-14-hannes@cmpxchg.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <20230418191313.268131-14-hannes@cmpxchg.org>
Precedence: bulk

On Tue, Apr 18, 2023 at 03:13:00PM -0400, Johannes Weiner wrote:
> I found myself repeatedly looking up the implementation of these
> helpers while working on the code, which suggests they are not a
> helpful abstraction. Inline them.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Not massively convinced one way or the other. Still, probably deserves
to join the end of the preparation patch before MIGRATE_FREE is
introduced in the interest in spltting the series into digestable
pieces.

-- 
Mel Gorman
SUSE Labs