Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 16:42:57 +0200
Message-ID: <87wn25qosu.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Chris Down <chris@chrisdown.name>
Cc:     linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] usb-audio: Rate limit usb_set_interface error reporting
In-Reply-To: <ZEKf8UYBYa1h4JWR@chrisdown.name>
References: <ZEKf8UYBYa1h4JWR@chrisdown.name>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 21 Apr 2023 16:38:41 +0200,
Chris Down wrote:
> 
> When an error occurs during USB disconnection sometimes things can go
> wrong as endpoint_set_interface may end up being called repeatedly. For
> example:
> 
> % dmesg --notime | grep 'usb 3-7.1.4' | sort | uniq -c | head -2
>    3069 usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
>     908 usb 3-7.1.4: 1:1: usb_set_interface failed (-71)
> 
> In my case, there sometimes are hundreds of these usb_set_interface
> failure messages a second when I disconnect the hub that has my USB
> audio device.
> 
> These messages can take a huge amount of the kmsg ringbuffer and don't
> provide any extra information over the previous ones, so ratelimit them.
> 
> Signed-off-by: Chris Down <chris@chrisdown.name>

This patch itself is safe and good to have, so I'm going to take it as
is.

But I'm still curious in which code path the problem happens.  That
is, we should address such unnecessary repeats if possible.  Do you
have some more data?


thanks,

Takashi