Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 15:56:57 +0100
From:   Mel Gorman <mgorman@techsingularity.net>
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     linux-mm@kvack.org, Kaiyang Zhao <kaiyang2@cs.cmu.edu>,
        Vlastimil Babka <vbabka@suse.cz>,
        David Rientjes <rientjes@google.com>,
        linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [RFC PATCH 25/26] mm: page_alloc: disallow fallbacks when 2M
 defrag is enabled
Message-ID: <20230421145657.fnpjqkuyquy3z24t@techsingularity.net>
References: <20230418191313.268131-1-hannes@cmpxchg.org>
 <20230418191313.268131-26-hannes@cmpxchg.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <20230418191313.268131-26-hannes@cmpxchg.org>
Precedence: bulk

On Tue, Apr 18, 2023 at 03:13:12PM -0400, Johannes Weiner wrote:
> Fallbacks are already unlikely due to watermarks being enforced
> against MIGRATE_FREE blocks. Eliminate them altogether. This allows
> compaction to look exclusively at movable blocks, reducing the number
> of pageblocks it needs to scan on an ongoing basis.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Conceptually this could be fun if a GFP_NOFS allocation cannot migrate
enough memory to free one pageblock and there are no pageblocks
available of the correct migratetype. Fallbacks might be unlikely but
never being able to fallback is a livelock risk, no?

-- 
Mel Gorman
SUSE Labs