Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 11:35:01 -0400
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     Mel Gorman <mgorman@techsingularity.net>
Cc:     linux-mm@kvack.org, Kaiyang Zhao <kaiyang2@cs.cmu.edu>,
        Vlastimil Babka <vbabka@suse.cz>,
        David Rientjes <rientjes@google.com>,
        linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [RFC PATCH 12/26] mm: page_alloc: per-migratetype free counts
Message-ID: <20230421153501.GE320347@cmpxchg.org>
References: <20230418191313.268131-1-hannes@cmpxchg.org>
 <20230418191313.268131-13-hannes@cmpxchg.org>
 <20230421142841.parju3gmqmpefigq@techsingularity.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230421142841.parju3gmqmpefigq@techsingularity.net>
Precedence: bulk

On Fri, Apr 21, 2023 at 03:28:41PM +0100, Mel Gorman wrote:
> On Tue, Apr 18, 2023 at 03:12:59PM -0400, Johannes Weiner wrote:
> > Increase visibility into the defragmentation behavior by tracking and
> > reporting per-migratetype free counters.
> > 
> > Subsequent patches will also use those counters to make more targeted
> > reclaim/compaction decisions.
> > 
> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> 
> Visibility into fragmentation behaviour is information that is
> almost certainly only useful to a developer and even then, there is
> /proc/pagetypeinfo. At minimum, move this patch to later in the series
> but I'm skeptical about its benefit.

Having them available in the memory dump (OOM, sysrq) was essential
while debugging problems in later patches. For OOMs or lockups,
pagetypeinfo isn't available. It would be useful to have them included
in user reports if any issues pop up.

They're used internally in several places later on, too.

I'll expand on the changelog and move them ahead in the series.

Thanks