Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 17:37:48 +0200
Message-ID: <87cz3xqm9f.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Chris Down <chris@chrisdown.name>
Cc:     linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] usb-audio: Rate limit usb_set_interface error reporting
In-Reply-To: <ZEKo68jUGe1taYxz@chrisdown.name>
References: <ZEKf8UYBYa1h4JWR@chrisdown.name>
        <87wn25qosu.wl-tiwai@suse.de>
        <ZEKiO7lh94QUyuAs@chrisdown.name>
        <87mt31qngg.wl-tiwai@suse.de>
        <ZEKo68jUGe1taYxz@chrisdown.name>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 21 Apr 2023 17:16:59 +0200,
Chris Down wrote:
> 
> Takashi Iwai writes:
> > Hrm, is "usb 3-7.1.4" really the USB audio device?  The previous
> > errors like "Unable to submit urb #2..." are certainly for USB audio,
> > and those are with "usb 3-7.4".
> 
> There are two USB audio devices -- 3-7.1.4 is input, 3-7.4 is output.
> 
>     % dmesg --notime | grep -e 'usb 3-7.4' -e 'usb 3-7.1.4' | grep Product: | sort | uniq
>     usb 3-7.1.4: Product: USB2.0 Microphone
>     usb 3-7.4: Product: USB Audio Device

Ah I see.  Then those are two different sound cards?

The repeated call of usb_set_interface() might be avoided by the
additional check like below.  But it's still puzzling how it happens,
because the only caller of endpoint_set_interface() you modified is
snd_usb_endpoint_prepare(), and it's called only from
snd_usb_pcm_prepare().  And, snd_usb_pcm_preapre() has the
snd_usb_lock_shutdown() call, which does the check of the
card->shutdown flag that should be set by the USB disconnection
callback...


thanks,

Takashi

-- 8< --
--- a/sound/usb/endpoint.c
+++ b/sound/usb/endpoint.c
@@ -911,6 +911,9 @@ static int endpoint_set_interface(struct snd_usb_audio *chip,
 
 	if (ep->iface_ref->altset == altset)
 		return 0;
+	/* already disconnected? */
+	if (unlikely(atomic_read(&chip->shutdown)))
+		return -ENODEV;
 
 	usb_audio_dbg(chip, "Setting usb interface %d:%d for EP 0x%x\n",
 		      ep->iface, altset, ep->ep_num);