Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 08:50:30 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Lee Jones <lee@kernel.org>, linux-kernel@vger.kernel.org,
        thomas.petazzoni@bootlin.com, alexis.lothore@bootlin.com
Subject: Re: [PATCH] regmap: don't check for alignment when using reg_shift
Message-ID: <ZEKwxhJJNkuX7VTr@colin-ia-desktop>
References: <20230420150617.381922-1-maxime.chevallier@bootlin.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230420150617.381922-1-maxime.chevallier@bootlin.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BcM2ztQ2SEoyjGstiZVgwcVtKAPbrOBuxWBLfB7N2P0JytwO2QBwD50fbBK/?=
 =?us-ascii?Q?TYHxXTfWv+sd/GaRkWCiZSJ1ONctZZZ5naB1kPJYqvY6l9F3/p1BJm2IoU/H?=
 =?us-ascii?Q?KwU2tyMDUyxrUb7g4MSatx5kNDEiqu+g8l4EVEN9mPJrT3I/BWzCDO1v3rRm?=
 =?us-ascii?Q?Aed+wSl7rSSaKLO0g734qxosyuSx1r2KjPvPsdZzF/HpKIFWaMJmDr8hQw0A?=
 =?us-ascii?Q?Lu1HNOuGjwPFGvYAizg1q356xq9AlMM5dKt2bQ7yKWV/IDXYygdq8MPY2PPd?=
 =?us-ascii?Q?EVtrebWrtPSxfkAmfd434xudVPO8HgYM69Ysqz4gQ5OWxcfYcckUqQeptHlP?=
 =?us-ascii?Q?PkIRtGlVhWKgVxc6QKo1c6oNpQr7O7Z6UHnOeTFV7XlPxwjt+BOaYCHLDQgV?=
 =?us-ascii?Q?mMuQbld1VF93V2NZbKy3I0H7QJNIjCSSzFISpU1Ds4tK6CzdnodyntN2eZ4t?=
 =?us-ascii?Q?P4c9NXbhahgMx20F2j/hsNDBUiz4xJRcgl+nRxVqyn7pwc15itkxjqlExRMz?=
 =?us-ascii?Q?1FAndULtURpIMQs/7qELztIeS1HQtzCTps1vetx8lfVBx3VZkb9Lqi6BdskP?=
 =?us-ascii?Q?Ja15I4TsNOEFxuzjGLzn2eAmSTdvFVPjNqcsw089Dg30ZUq2NnBLFI0hpCY8?=
 =?us-ascii?Q?9yieMf+cIkCEtuJpKXP6Gdv5I/ayRsptQqviV+LIotrNhKT11c5O6vppZgWe?=
 =?us-ascii?Q?NuoKVPgC4XZffvms+sPAV0J9EBaRHJq0iiuoGxMVlBNoGWOEqyR/3HN+iWRQ?=
 =?us-ascii?Q?DjJL9CwzuovgNgw6jPGNv2Nye/+oVSr0j9L9gjr9GZU5Ej0L53X7Oqn7dFaZ?=
 =?us-ascii?Q?1+SmfOTf4FvuNr1T1iznSzafu3J3ereXERkqwyxh7VKDRC/h2B9x2hU08MZe?=
 =?us-ascii?Q?mbsbZlq9wOyoRsjEvTLmPklG22HLMRkqOOIGxtLXQM3LhqU+wx4NJ8SeZicB?=
 =?us-ascii?Q?85Hi9ge+H2z/6WvQqHJCbNlPtBotaLpgushwlZnn16DNXRj6g8G2v2IOqUIl?=
 =?us-ascii?Q?hTNPoL9v0c5nhFCQsxnbjvBOsXr0+Zp+GvwHUhAH7v7gCEoHwoK0vOy51QdJ?=
 =?us-ascii?Q?yZ7y5yrjE3cjLZFymwJp6TbemJ5GXjBSZx0H+hjZFtJ2QdQjp5oVbfcqOYai?=
 =?us-ascii?Q?wSIW+V8F8vgHH9yswXAiHY+uxTiqlDicO/Uip63CWKk2Es5lbFe9k0FoYIVp?=
 =?us-ascii?Q?t8wjUNcksIX1PI1GuZwi+yEXMqYhgfP9vAYIz7/Aj92Xt4Zz+kT/3jexvPI4?=
 =?us-ascii?Q?VNpYgGva+4SzcRyubQwCKn+FkMDk1e6LxKMmzHbu8aQ5WqfHgdN/aHFAzADd?=
 =?us-ascii?Q?twWz+MfjZbGzAxa95RFdpBcaCfjCZu7PXh48xJopib1LS0z5Vkp/aVF07pqV?=
 =?us-ascii?Q?qst1uJWmkD7rDc+HftqmcL8F+LJd+roMAmclLbGV0hXvg+g3YOZrEvZovRg5?=
 =?us-ascii?Q?bOjcFirH3cL4LQe72Ezqc8t7T+0Jx7sy3WtTgUUwUWjff+1hzdqgBbPs/Xo0?=
 =?us-ascii?Q?8/OpsHwieOuuEDCVqF70N7t35Pl1+8jKiRB4Y8nP+irw/jiUv7SEfOzhi1HK?=
 =?us-ascii?Q?4zU6cBsrOQ2wdFEr28BYX0RDbZQERNeklPSrLgzNLnR6CUuUyOx7g1qgSxnF?=
 =?us-ascii?Q?Zw=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d0bbbbd-d367-459e-5200-08db42802405
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2023 15:50:33.4524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wbb0aScmrVd51lQw07O8LJsumdyTkziflePk30fkwWQbOVXo0LZFzDlDVZb1aAXkinkIVMtL1h/W8j/Ve75K0dLg9NuVQLGhYzbnYX0V2Y4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6965
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Maxime,

On Thu, Apr 20, 2023 at 05:06:17PM +0200, Maxime Chevallier wrote:
> On regmap consumers that require address translation through
> up/downshifting, the alignment check in the regmap core doesn't take the
> translation into account. This doesn't matter when downshifting the
> register address, as any address that fits a given alignment requirement
> will still meet it when downshifted (a 4-byte aligned address will
> always also be 2-bytes aligned for example).
> 
> However, when upshifting, this check causes spurious errors, as it
> occurs before the upshifting.

I don't follow why upshifting should make a difference to alignment.
Assuming it does though, would it make sense to test

map->format.reg_shift > 0

instead of just !map->format.reg_shift?

> -	if (!IS_ALIGNED(reg, map->reg_stride))
> +	if (!map->format.reg_shift && !IS_ALIGNED(reg, map->reg_stride))
>  		return -EINVAL;

In the case of ocelot_spi, we'd want to flag an invalid access to a
register like 0x71070003... Before this patch it would return -EINVAL,
after this patch it would access 0x71070000.

Colin Foster