Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c140045b-967f-df56-22b7-8df11da97884@wanadoo.fr>
Date:   Fri, 21 Apr 2023 17:50:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] media: ov5693: Simplify an error message
To:     Matthias Schwarzott <zzam@gentoo.org>,
        Daniel Scally <djrscally@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-media@vger.kernel.org
References: <928f2f70de241d0fa66801b46d736ad0f881eb72.1681576102.git.christophe.jaillet@wanadoo.fr>
 <b4aea4b5-d86a-1604-c646-346ea7b59476@gentoo.org>
Content-Language: fr, en-US
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <b4aea4b5-d86a-1604-c646-346ea7b59476@gentoo.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 21/04/2023 à 09:38, Matthias Schwarzott a écrit :
> Am 15.04.23 um 18:28 schrieb Christophe JAILLET:
>> dev_err_probe() already display the error code. There is no need to
>> duplicate it explicitly in the error message.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>>   drivers/media/i2c/ov5693.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
>> index e3c3bed69ad6..d23786afd754 100644
>> --- a/drivers/media/i2c/ov5693.c
>> +++ b/drivers/media/i2c/ov5693.c
>> @@ -404,8 +404,8 @@ static int ov5693_read_reg(struct ov5693_device 
>> *ov5693, u32 addr, u32 *value)
>>       ret = i2c_transfer(client->adapter, msg, 2);
>>       if (ret < 0)
> 
> i2c_transfer returns the number of transmitted messages. So I think the 
> values 0 <= ret < 2 also need to be handled.

Ok, agreed.

If ok for you, I'll send a follow-up patch when/if this one is applied,
because what you spotted is unrelated to the dev_err_probe() behavior.

CJ
> 
>>           return dev_err_probe(&client->dev, ret,
>> -                     "Failed to read register 0x%04x: %d\n",
>> -                     addr & OV5693_REG_ADDR_MASK, ret);
>> +                     "Failed to read register 0x%04x\n",
>> +                     addr & OV5693_REG_ADDR_MASK);
>>       *value = 0;
>>       for (i = 0; i < len; ++i) {
> 
>