Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 16:02:32 +0000
To:     Joel Selvaraj <joelselvaraj.oss@gmail.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Henrik Rydberg <rydberg@bitmath.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Robert Jarzmik <robert.jarzmik@free.fr>,
        Jeff LaBundy <jeff@labundy.com>,
        Markuss Broks <markuss.broks@gmail.com>,
        Jean Delvare <jdelvare@suse.de>,
        Max Krummenacher <max.krummenacher@toradex.com>,
        Chris Morgan <macromorgan@hotmail.com>,
        Job Noorman <job@noorman.info>,
        Alistair Francis <alistair@alistair23.me>,
        Hans de Goede <hdegoede@redhat.com>,
        Maxime Ripard <mripard@kernel.org>
From:   Caleb Connolly <caleb@connolly.tech>
Cc:     linux-input@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] arm64: dts: qcom: sdm845-shift-axolotl: update focaltech touchscreen properties
Message-ID: <853c694f-c3d3-f61c-2e5d-0b9b8fd2a326@connolly.tech>
In-Reply-To: <20230415020222.216232-6-joelselvaraj.oss@gmail.com>
References: <20230415020222.216232-1-joelselvaraj.oss@gmail.com> <20230415020222.216232-6-joelselvaraj.oss@gmail.com>
Feedback-ID: 10753939:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 15/04/2023 03:02, Joel Selvaraj wrote:
> The touchscreen nodes were added before the driver patches were merged.
> Update the focaltech touchscreen properties to match with the upstreamed
> focaltech driver. Also, the touchscreen used is in axolotl is fts5452
> and not fts8719.
>
> Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>

Reviewed-by: Caleb Connolly <caleb@connolly.tech>
> ---
>  .../boot/dts/qcom/sdm845-shift-axolotl.dts     | 18 ++++++++----------
>  1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm=
64/boot/dts/qcom/sdm845-shift-axolotl.dts
> index b54e304abf71..70286e53e000 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> @@ -474,23 +474,21 @@ &i2c5 {
>  =09status =3D "okay";
>
>  =09touchscreen@38 {
> -=09=09compatible =3D "focaltech,fts8719";
> +=09=09compatible =3D "focaltech,fts5452";
>  =09=09reg =3D <0x38>;
> -=09=09wakeup-source;
> -=09=09interrupt-parent =3D <&tlmm>;
> -=09=09interrupts =3D <125 0x2>;
> -=09=09vdd-supply =3D <&vreg_l28a_3p0>;
> -=09=09vcc-i2c-supply =3D <&vreg_l14a_1p88>;
>
> -=09=09pinctrl-names =3D "default", "suspend";
> +=09=09interrupts-extended =3D <&tlmm 125 IRQ_TYPE_EDGE_FALLING>;
> +=09=09reset-gpios =3D <&tlmm 99 GPIO_ACTIVE_LOW>;
> +
> +=09=09avdd-supply =3D <&vreg_l28a_3p0>;
> +=09=09vddio-supply =3D <&vreg_l14a_1p88>;
> +
>  =09=09pinctrl-0 =3D <&ts_int_active &ts_reset_active>;
>  =09=09pinctrl-1 =3D <&ts_int_suspend &ts_reset_suspend>;
> +=09=09pinctrl-names =3D "default", "suspend";
>
> -=09=09reset-gpio =3D <&tlmm 99 GPIO_ACTIVE_HIGH>;
> -=09=09irq-gpio =3D <&tlmm 125 GPIO_TRANSITORY>;
>  =09=09touchscreen-size-x =3D <1080>;
>  =09=09touchscreen-size-y =3D <2160>;
> -=09=09focaltech,max-touch-number =3D <5>;
>  =09};
>  };
>
> --
> 2.40.0
>

--
Kind Regards,
Caleb