Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 18:48:34 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Evan Green <evan@rivosinc.com>
Cc:     Palmer Dabbelt <palmer@rivosinc.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Andrew Jones <ajones@ventanamicro.com>,
        Conor Dooley <conor.dooley@microchip.com>,
        Guo Ren <guoren@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
        Jisheng Zhang <jszhang@kernel.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Philipp Tomsich <philipp.tomsich@vrull.eu>,
        Samuel Holland <samuel@sholland.org>,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] RISC-V: hwprobe: Remove __init on probe_vendor_features()
Message-ID: <20230421-humpback-thesis-052993278582@spud>
References: <20230420194934.1871356-1-evan@rivosinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="aRxAucu+VMU5sivz"
Content-Disposition: inline
In-Reply-To: <20230420194934.1871356-1-evan@rivosinc.com>
Precedence: bulk


--aRxAucu+VMU5sivz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Yo Evan,

On Thu, Apr 20, 2023 at 12:49:34PM -0700, Evan Green wrote:
> probe_vendor_features() is now called from smp_callin(), which is not
> __init code and runs during cpu hotplug events. Remove the
> __init_or_module decoration from it and the functions it calls to avoid
> walking into outer space.
>=20
> Fixes: 62a31d6e38bd ("RISC-V: hwprobe: Support probing of misaligned acce=
ss performance")
>

BTW, in the future, no empty line between trailers.

> Signed-off-by: Evan Green <evan@rivosinc.com>

Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

--aRxAucu+VMU5sivz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZELMcgAKCRB4tDGHoIJi
0r4oAP9MpkA95QmPfsVGArIe3XYGzsfJ9qessAghtLLA7WxNPQEA7mgwhKGzi3dJ
ox2EWtciEAdDRS5RDGNln4ou3RSMWwo=
=JmiQ
-----END PGP SIGNATURE-----

--aRxAucu+VMU5sivz--