Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 12:20:42 -0700
From:   Jaegeuk Kim <jaegeuk@kernel.org>
To:     Chao Yu <chao@kernel.org>
Cc:     Qi Han <hanqi@vivo.com>, linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree
Message-ID: <ZELiCve2x31uJFhM@google.com>
References: <20230418060954.67585-1-hanqi@vivo.com>
 <b031f528-f3dd-44ed-5370-2133a74f9332@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b031f528-f3dd-44ed-5370-2133a74f9332@kernel.org>
Precedence: bulk

On 04/21, Chao Yu wrote:
> On 2023/4/18 14:09, Qi Han wrote:
> > This comment make no sense and is in the wrong place, so let's
> > remove it.
> > 
> > Signed-off-by: Qi Han <hanqi@vivo.com>
> > ---
> >   fs/f2fs/extent_cache.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> > index 28b12553f2b3..1f6d7de35794 100644
> > --- a/fs/f2fs/extent_cache.c
> > +++ b/fs/f2fs/extent_cache.c
> > @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
> >   	if (!test_opt(sbi, AGE_EXTENT_CACHE))
> >   		return false;
> > -	/* don't cache block age info for cold file */
> >   	if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
> >   		return false;
> 
> Should move it here instead of removal?
> 
> /* don't cache block age info for cold file */

Not worth to comment this, as the code is exactly saying that.

> 
> >   	if (file_is_cold(inode))