Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Fri, 21 Apr 2023 19:07:53 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   "Konstantin Ryabitsev" <konstantin.ryabitsev@linux.dev>
Message-ID: <1e4386d3a24bbf4c70880fef2af74928@linux.dev>
Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional
 props
To:     "Rob Herring" <robh@kernel.org>,
        "Florian Fainelli" <f.fainelli@gmail.com>
Cc:     "Jim Quinlan" <jim2101024@gmail.com>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
        linux-pci@vger.kernel.org,
        "Nicolas Saenz Julienne" <nsaenz@kernel.org>,
        "Bjorn Helgaas" <bhelgaas@google.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        "Cyril Brulebois" <kibi@debian.org>,
        "Phil Elwell" <phil@raspberrypi.com>,
        bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com,
        "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
        "=?utf-8?B?S3J6eXN6dG9mIFdpbGN6ecWEc2tp?=" <kw@linux.com>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@lists.infradead.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "open list" <linux-kernel@vger.kernel.org>
In-Reply-To: <20230418183536.GA2087834-robh@kernel.org>
References: <20230418183536.GA2087834-robh@kernel.org>
 <20230411165919.23955-1-jim2101024@gmail.com>
 <20230411165919.23955-2-jim2101024@gmail.com>
 <5a28e520-63e4-dbcf-5b3e-e5097f02dea2@linaro.org>
 <78c18cdb-5757-8d30-e2a6-414f09505cc6@gmail.com>
 <66b7d0b9-9569-ddaf-89ca-5a0133074a17@linaro.org>
 <CANCKTBtZt9QRkT4yAW5LsfHGf5TTL7tQ025H42+PPEi-=rWE8A@mail.gmail.com>
 <20230412153723.GA2473030-robh@kernel.org>
 <ac2245fd-52c8-3255-3e54-bd8daab1282d@gmail.com>
Precedence: bulk

April 18, 2023 2:35 PM, "Rob Herring" <robh@kernel.org> wrote:=0A>> Some =
trees like the networking=0A>> tree do merge commits of patch sets where =
the cover letter is used as part=0A>> of the merge commit message. Other =
maintainers don't, and some want the=0A>> change log after the '---' and =
some do not.=0A> =0A> I'm not aware of anyone except for DRM wanting the =
changelog in the=0A> final commits, but that's really a different issue.=
=0A=0AI don't think anyone wants changelogs in actual final commits, they=
 usually go under "---" in patch submissions.=0A=0A> I'm pretty sure no o=
ne will complain about a changelog in the patches. I=0A> guess you just h=
ave to duplicate it if you think it should be in both.=0A> b4 could be ta=
ught to do that I suppose. IMO, the cover letter should=0A> have a higher=
 level changelog than the individual patches.=0A=0Ab4 doesn't really need=
 to manage per-patch changelogs -- they should just go under "---" in the=
 commit. When you send the series either via "b4 send" or via git-send-em=
ail, the changelogs will be properly included in the message, but they wo=
n't make it into the tree after the maintainer runs "git am", because git=
 will drop anything under the first "---" in the commit message.=0A=0AThe=
 cover letter changelog is supposed to be higher level than individual pa=
tch changelogs, so I don't think it makes sense for b4 to collect them fr=
om individual patches.=0A=0A-K