Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp2759226rwr; Fri, 21 Apr 2023 13:41:37 -0700 (PDT) X-Google-Smtp-Source: AKy350ZC+frLmLovuJQOE9JeCKYFz2m9uKrk13LZu4zvChKpxTzg3vKmnkd450pZJkXvwIo+5CWn X-Received: by 2002:a05:6a20:8e19:b0:d7:3c1a:6c9a with SMTP id y25-20020a056a208e1900b000d73c1a6c9amr7131709pzj.4.1682109697063; Fri, 21 Apr 2023 13:41:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682109697; cv=none; d=google.com; s=arc-20160816; b=Fk07oKpyjeFY5uI9UajQkfEmJqx0RiYuGwcDKuUE8qinBLxOkBKtnvN3y8o7jKTkws x3VjdqNsHKOLJJIzhc59XrhXBZH4NQYi1tSJNpoDcu/77XKw79t6PcBzWLd8ysA8rPgo k6gXAtmI3yBv5esjxsHa4dCijwUqVzAQMXN8vp/BAzM6V3iqHUo2fFkaO19xBZgqdmR3 kiWTil69BppzooXsd4VmtahNd5EYa01r+EWaMpIZX0kGgDKmrU0vRuyN4LcdY2mZphOs tUAbK7dPWr0KDMSaiZ6RT6gAcTxOg0BGn7AkQyp3TTfRWxtsMrdbzDlh8q3gY8wj87aq 7CDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=A2XozTJws4toh13zEJ4n565nKKguH3N7JeE3lhWnoDE=; b=iiMY7fI0ipYsHimY14Igyxrs5g2VWAyaJqmpf6slBM1ibtF1FySI4K8xsDm8tlscti TAZlNqdlgviabEg7WmzB+KwzeekExic96eB93INrVD27wSJ3zz+5VJDWYl3kJX9rfilN QSkfCZlKlItPs8ep3iAnKZTjIHDeIjj1amUW0CbgP2aWF7lS+JM+8gFUFjKNRsCCQ3/H r2ZAv6A0XJdhgBMeG+1q8aZKBwjk70o4Y2LOZcrpEJsGY+yeJFTi51l9yI41zCJ5EK4G 9fQEubvZ0FWsDokkc6FTUidB3Tv+w5xQuqICzt81FkV2W/c/KC6vJIEOk7lngxZ4LmvL NTvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=KazI3OCh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 125-20020a630583000000b00502f4be647fsi5231845pgf.641.2023.04.21.13.41.17; Fri, 21 Apr 2023 13:41:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=KazI3OCh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232999AbjDUUOO (ORCPT + 99 others); Fri, 21 Apr 2023 16:14:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbjDUUON (ORCPT ); Fri, 21 Apr 2023 16:14:13 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 022092717; Fri, 21 Apr 2023 13:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A2XozTJws4toh13zEJ4n565nKKguH3N7JeE3lhWnoDE=; b=KazI3OChQ8xi0cwyBWWi2wSA+d Dv6s5by1QWGWvpAlTZWGesKNdytZlLSAOalemBEZO5rELZUMfVeAY1yZ3qclyF0geINsWblz8o9JL KrCp/O0cKi2DLEYQQN08eZ21fTIZ0L+F8tqLSxzO0hmvR/ttXJr3rOL0pEgRfoaFXGQvs5IVHOHZZ zxTc3G+5goFSv5y1kllt2rSeIkt+cwOtNK+S+HhWtGPacqN3frlkpTebwCYWwbszRhF/mRefjwcIe CuzZGi/qjzq6oLG6SAyyoiOIgXbRDVTOGZtPQOQ5R3M4zoPS5TI38FfuJsg7RWNB05tynED3yvDp7 IUu5SVig==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ppx8q-00FZlw-Dy; Fri, 21 Apr 2023 20:14:00 +0000 Date: Fri, 21 Apr 2023 21:14:00 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org Subject: Re: [PATCH 3/5] iomap: simplify iomap_init() with PAGE_SECTORS Message-ID: References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-4-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421195807.2804512-4-mcgrof@kernel.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2023 at 12:58:05PM -0700, Luis Chamberlain wrote: > Just use the PAGE_SECTORS generic define. This produces no functional > changes. While at it use left shift to simplify this even further. How is FOO << 2 simpler than FOO * 4? > - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > + return bioset_init(&iomap_ioend_bioset, PAGE_SECTORS << 2,