Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp2763884rwr; Fri, 21 Apr 2023 13:47:25 -0700 (PDT) X-Google-Smtp-Source: AKy350brPaePqj+9pVe7bNvhnV3MVv9Fx2aA1iG+ByIrBRO7qjPSwfpXO4YRAX75sHhJgpiMmDrC X-Received: by 2002:a05:6a00:230a:b0:63d:2d6a:47be with SMTP id h10-20020a056a00230a00b0063d2d6a47bemr7220065pfh.2.1682110045145; Fri, 21 Apr 2023 13:47:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682110045; cv=none; d=google.com; s=arc-20160816; b=zBr+oN0R5QbSN+kvgehB9FI7jU3UEBOY1a8RXUMJXpJoki9sDoGKhmNcoyVaETh2bj IAnzrULUQa7SE6EzyNNOZCty1HqQPyRGXzjqCe44ngpZkbz7847MU2Jb8tgdTrOLwaB7 sH+uU2SumROtX+m2Vl2ZjAL1fd4uoSpCVdYxnHmBch1fGMelF16xrS+gYv4k26l37x3x 6KDC21rvSyGav7G8kj/VXCcZBrL4xLToEl7bwrAEStXznpsUBx3JFTpboIDhQh/6jB3m wgtEbSTTWDIxJGmHePhljhPXuajTAkQE++MU/a8SnK1j6Ih0O1RbaLRMVthQXUktVxkx THwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7jDGoKVRVE8/8Iw2EXqkPonvmAc0gvYRAzqps4fjwwg=; b=DbKrcFHETTvF+JYbHY66c5Y7b9ZeukOqpyrTDX8KUJafgRBKPxKgAbVIPXxAt7b1h/ sQfiu66Tl90Dz0a7oisKRC/e/rmcYAn1s/oIVNth8p3OCW+5u55hOJMo+lMJ0u/E+rlR nf3qiYmTZhQkGQsqKGXEWf0yCjmDsf9R9haMwe8x2F24sApEHJVCdblWPj/dmN+ORcnb 52hDIj+O9TpOs4/BxumCknKZPFc3bTCdbJI3YDBoNcmP299QdqZZZgT/zjUPVFXv1LsY qGni115qBTZWc4CKspq+pfbMEvRRM9GO5Zpn2ymdZAAXWo/wVHc5Ypl/MKvI2KHEogvx UYEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=mr+zjn1y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g25-20020a632019000000b0051372e8f9b5si1887096pgg.791.2023.04.21.13.47.11; Fri, 21 Apr 2023 13:47:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=mr+zjn1y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233277AbjDUUPY (ORCPT + 99 others); Fri, 21 Apr 2023 16:15:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232072AbjDUUPW (ORCPT ); Fri, 21 Apr 2023 16:15:22 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED9E82719; Fri, 21 Apr 2023 13:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7jDGoKVRVE8/8Iw2EXqkPonvmAc0gvYRAzqps4fjwwg=; b=mr+zjn1yXtzKk4APmgRaOn77YC qyrdJusW0V5fFBehp0H4LgJmcOzWB0HiZ/19FHS9XzMMBWYiQQiK2ov9vzahR7YBu95NK76q9JJZs AkLKN4MUKm/MQ5+LZ/SLYHWNNTKsZIr04BKzck1FGkgdltQkKD7lNhCvCFoMTcFExtsIMgiMKVPre m9Im6jnJmlKaq2x+wCYrcuNfTZjtNWDTsZNJmxJoZAgKC50KnsIBoeDx/zoi7hd2VV9XP++ihIvTA tOEZ5yH+/ubaSmLHWmwzD23OC6iMGfb2/N5vqIvhKd4FYrTP8/q/0FOd4KBWDZDlc9qXT016NGn1F NwwreEtg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ppxA3-00FZsC-AG; Fri, 21 Apr 2023 20:15:15 +0000 Date: Fri, 21 Apr 2023 21:15:15 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org Subject: Re: [PATCH 1/5] dm integrity: simplify by using PAGE_SECTORS_SHIFT Message-ID: References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421195807.2804512-2-mcgrof@kernel.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2023 at 12:58:03PM -0700, Luis Chamberlain wrote: > - *pl_index = sector >> (PAGE_SHIFT - SECTOR_SHIFT); > + *pl_index = sector >> (PAGE_SECTORS_SHIFT); You could/should remove the () around PAGE_SECTORS_SHIFT (throughout)