Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 23:18:15 +0200 (CEST)
From:   Richard Weinberger <richard@nod.at>
To:     ZhaoLong Wang <wangzhaolong1@huawei.com>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        chengzhihao1 <chengzhihao1@huawei.com>,
        yi zhang <yi.zhang@huawei.com>
Message-ID: <1751647898.236371.1682111895850.JavaMail.zimbra@nod.at>
In-Reply-To: <20230318015621.1408243-1-wangzhaolong1@huawei.com>
References: <20230318015621.1408243-1-wangzhaolong1@huawei.com>
Subject: Re: [PATCH 0/5] ubi: Enhanced fault injection capability for the
 UBI driver
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: Enhanced fault injection capability for the UBI driver
Thread-Index: zOuMq5RgU5mOajBYreOdiSG1qqplFg==
Precedence: bulk

----- Ursprüngliche Mail -----
> Von: "ZhaoLong Wang" <wangzhaolong1@huawei.com>
> The existing fault injection capability of UBI is too simple.
> It uses hard-coded fault probability values and lacks other
> configurable options. As a result, these interfaces are difficult
> to use when digging defects in the abnormal path of code and
> reproducing some problems.
> 
> The kernel provides a powerful fault injection framework, which
> provides rich configurable fault injection attributes during runtime.
> So it can be used to improve the fault injection capability of the
> UBI driver.
> 
> This series of patches refactor the existing fault injection interface
> and add some fault injection types to help testers and developers
> find potential problems in the code.

In general I like having some new and advanced way to test UBI.
But your patches seem to remove the old interface from debugfs,
this will cause breakage of existing test scripts.

So please keep the old interface too.

Thanks,
//richard