Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1f7bb81a-d38c-725a-9ee1-89efe2950b1d@linaro.org>
Date:   Sat, 22 Apr 2023 01:35:21 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 0/2] DPU1 GC1.8 wiring-up
Content-Language: en-GB
To:     Abhinav Kumar <quic_abhinavk@quicinc.com>,
        Marijn Suijten <marijn.suijten@somainline.org>
Cc:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, linux-arm-msm@vger.kernel.org,
        dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230420-topic-dpu_gc-v1-0-d9d1a5e40917@linaro.org>
 <5b133c55-e4f5-bfd2-b542-a7d44313c038@linaro.org>
 <c0e0a55a-cc37-fe8a-8d8a-5fe257f99b9a@linaro.org>
 <3f3b3637-ed85-09a1-22b7-3ccd4bc929bb@quicinc.com>
 <2dff9d62-cffe-c66f-9e50-3ecd64e44d37@linaro.org>
 <6a335df7-ff0b-098a-feec-45714159df04@linaro.org>
 <b134d09c-55fa-7879-80ff-900e39c20c3d@quicinc.com>
 <0f469b3c-5f0f-e027-8a9f-d1233169c04a@linaro.org>
 <57pxyxwluu33z4lpij5gx7biwfo5pbhdalhhxflw7esi5n3vts@qhjb7ldnz3wb>
 <0bba90c1-01be-a76e-df12-2328b84f7298@linaro.org>
 <b6d56e50-fb5b-1d59-7b39-a3ca2a0a8d83@quicinc.com>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
In-Reply-To: <b6d56e50-fb5b-1d59-7b39-a3ca2a0a8d83@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22/04/2023 01:34, Abhinav Kumar wrote:
> 
> 
> On 4/20/2023 3:52 PM, Dmitry Baryshkov wrote:
>> On 20/04/2023 22:56, Marijn Suijten wrote:
>>> On 2023-04-20 22:51:22, Dmitry Baryshkov wrote:
>>>> On 20/04/2023 22:47, Abhinav Kumar wrote:
>>>>>
>>>>>
>>>>> On 4/20/2023 11:01 AM, Dmitry Baryshkov wrote:
>>>>>> On 20/04/2023 04:36, Konrad Dybcio wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 20.04.2023 03:28, Abhinav Kumar wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 4/19/2023 6:26 PM, Konrad Dybcio wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 20.04.2023 03:25, Dmitry Baryshkov wrote:
>>>>>>>>>> On 20/04/2023 04:14, Konrad Dybcio wrote:
>>>>>>>>>>> Almost all SoCs from SDM845 to SM8550 inclusive feature a GC1.8
>>>>>>>>>>> dspp sub-block in addition to PCCv4. The other block differ a 
>>>>>>>>>>> bit
>>>>>>>>>>> more, but none of them are supported upstream.
>>>>>>>>>>>
>>>>>>>>>>> This series adds configures the GCv1.8 on all the relevant SoCs.
>>>>>>>>>>
>>>>>>>>>> Does this mean that we will see gamma_lut support soon?
>>>>>>>>> No promises, my plate is not even full, it's beyond 
>>>>>>>>> overflowing! :P
>>>>>>>>>
>>>>>>>>> Konrad
>>>>>>>>
>>>>>>>> So I think I wrote about this before during the catalog 
>>>>>>>> rework/fixes
>>>>>>>> that the gc registers are not written to / programmed.
>>>>>>>>
>>>>>>>> If thats not done, is there any benefit to this series?
>>>>>>> Completeness and preparation for the code itself, if nothing else?
>>>>>>
>>>>>> The usual problem is that if something is not put to use, it quickly
>>>>>> rots or becomes misused for newer platforms. We have seen this with
>>>>>> the some of DPU features.
>>>>>>
>>>>>> In case of GC (and the freshly defined DPU_DSPP_IGC, but not used) we
>>>>>> have three options:
>>>>>> - drop the unused GC from msm8998_sblk.
>>>>>> - keep things as is, single unused GC entry
>>>>>> - fill all the sblk with the correct information in hope that it 
>>>>>> stays
>>>>>> correct
>>>>>>
>>>>>> Each of these options has its own drawbacks. I have slight bias
>>>>>> towards the last option, to have the information in place (as long as
>>>>>> it is accurate).
>>>>>>
>>>>>
>>>>> My vote is for (1) . Today, GC is unused and from the discussion here,
>>>>> there is no concrete plan to add it. If we keep extending an unused
>>>>> bitmask for all the chipsets including the ones which will get 
>>>>> added in
>>>>> the future in the hope that someday the feature comes, it doesnt sound
>>>>> like a good idea.
>>>>>
>>>>> I would rather do (1), if someone has time.
>>>>
>>>> Agree, this was the second item on my preference list. Could you please
>>>> send this oneliner?
>>>
>>> Nit (to make sure we're on the same thought here): I think it's a
>>> 3-liner: remove it from DSPP_MSM8998_MASK as well as msm8998_dspp_sblk.
>>>
>>>>> OR lets stay at (2) till
>>>>> someone does (1).
>>>
>>> I'm personally okay leaving it in place too, with an eye on implementing
>>> this, IGC, and other blocks at some point if there's a use for it via
>>> standard DRM properties.
>>
>> I took a quick glance. I think it is possible, but not 
>> straightforward. But I must admit here, I don't have a full picture 
>> regarding different color encodings, ranges and the rest of 
>> gamma/degamma API and usage.
>>
> 
> I think its easier to remove this now and then add it when we add the 
> support. As discussed, will post this shortly.
> 
> Otherwise, whenever any new chipset gets added, we will run into the 
> same question of whether to add GC or not.

Yes, I absolutely agree here.

> 
>>>
>>>>> When someone implements GC, we can re-use this patch and that time 
>>>>> keep
>>>>> konrad's author rights or co-developed by.
>>>
>>> Good to at least know all these SoCs have the same offset and revision.
>>>
>>> - Marijn
>>

-- 
With best wishes
Dmitry