Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a1c85bef-5f41-c49b-a012-1e75e69a3789@intel.com>
Date:   Fri, 21 Apr 2023 17:07:55 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v2 01/24] selftests/resctrl: Add resctrl.h into build deps
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Shuah Khan" <shuah@kernel.org>, Babu Moger <babu.moger@amd.com>,
        "Sai Praneeth Prakhya" <sai.praneeth.prakhya@intel.com>,
        <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>
 <20230418114506.46788-2-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230418114506.46788-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3loYWdxczBrOWdmeVR4MkQwRFl2Z1E0Um1CVllVcFlHYytFWHhwUE1RTWgv?=
 =?utf-8?B?OW51WkQvSnppWE5QVnFNOWVMM2xzOFJzOUVjOXNDR1NnZmcxZnJCNnc0L2ZD?=
 =?utf-8?B?cWhpZnFPTWx1Y0RNVEpDVVVGRG1vbjhmbHJCMUpacFk3VjFrYWpwd1ozeXBB?=
 =?utf-8?B?S1FBUW1GTlpFQy82L0hFVTlaVlJlZDdIZmFnWWQ2UHNOT0tPQ0FOdWIxMGlF?=
 =?utf-8?B?NEpoTWV2V0RLcG9wM2xpM0xrdmxqamhLeUpnVVQ4UzNqSkpKQS9jSUVSakMy?=
 =?utf-8?B?cVl6anlOL1dYV1JaVW9mN1g3aFhHOTdMZFMyZ0p4MVljZUt2Nk9ZYnN3RTlx?=
 =?utf-8?B?QmZXUWtjOUNxTWZGUUdDK1NyVzg2NnhGKzNvRVlQMWhvV1NJeXV3UWcweFB0?=
 =?utf-8?B?U1Z5S0NhUHpENFZvVnROY2VockxXQ0FGb05TZEVlZHhhYlhncExNN1EzVTgr?=
 =?utf-8?B?ZmplMjd5bkxvbmRpYlp5WVNMbVl0dENCbXJEYWViaGJJT0NKTFJxZllJTWdP?=
 =?utf-8?B?T2RwQk1SNGxnd2F6cEUyNGpXa2w2UkJVK1VpZy9aZXpaRHlrY21xejU2Q2k0?=
 =?utf-8?B?SXNLQThyWTJ0dUR1Y2tSb1NlcDlCUHVtSFVZQUtDR01qM3YxdDNpSWZWUmRq?=
 =?utf-8?B?OCtRK2QzL1dYVTh6WkxadnV0WVg3WGRRdlNndy9MOEVUbExJSUFjY2dhMU1L?=
 =?utf-8?B?YTRvdUJPSU5sMlNkcnRVUzV5WW9YWE00R1dQNXJiRVR0RDhDVzVkVk1LZDht?=
 =?utf-8?B?eTJXRkp3T0Fia2VQQzkrUXNaOXdGdFBISjlueWJCOXFWUkNMVDcxNmZLNy85?=
 =?utf-8?B?aUZReWVLbE5BVmNxS3gzblp0WDAxQ2JCQUk5SWxaeDh6aWtCbTBVMWxKUzdL?=
 =?utf-8?B?bDJ1RHl5eU05ZHJ3ckYyWFpaNVVxT1hRTnhNTzloNVlhWlFtbUZHMU9kaWpD?=
 =?utf-8?B?eVpiM2FGNW9sVmRIREVJRG03bENWczNGVjh5d04wbmVqU3l6THNOZmZvaWxT?=
 =?utf-8?B?bmN1dVVjbHhzREV1c3pzZUZSMkFmYXB2eUlKS1VHTlVGeW9qN1IzYnpUTU5P?=
 =?utf-8?B?S2lqY2hWR1BBYlZ6ZGtabEZHQUcvUUlTZVcvLzFVeGNrOGsza2t6VHVnMUFm?=
 =?utf-8?B?V094YlA0VnpWQnFpZjR4MEUwdW9GZjkvSjZBSUZQOW12eEtiL3RWbCtJNWVt?=
 =?utf-8?B?cVlrT1RPamJOaSt1RkxpOVQyWHlYS1VIK2Y1RW42SWxzZitZMVBOUjZTQ2dB?=
 =?utf-8?B?RExGdEQvTFYwcUtvdlJ3Z1JLV0xQcHhkN090V1h0eWtkSFovczBpcVNySUhO?=
 =?utf-8?B?NnE4R1gxd1djdmpFakNFZ3p4VmtKRFduRWprMDhWNlVMMEFLU3pRY0pqL2N2?=
 =?utf-8?B?ZDgzMG1WU0VWSzA1OGtSV0NSMG13WjgwSUhiOWd2RUJ2QUw3Q0pLaGd1VXNi?=
 =?utf-8?B?YkVjcTNHQklKVGhlOXV4bmwxSGpqaUZuWWZPWnB5MzU5bXQzK1lEL3BRS3Z5?=
 =?utf-8?B?clQ0NGd6MGVIWWdWd2hDUWpwUDVrVk1FRXZ2SjE5Y3V2ZVJYakVLUWdHNjM1?=
 =?utf-8?B?WHNRN2JtcTQxM3JaT1Avdkt5ZmNTRnBTcENRZ0UvbDdGWWNhZldOOFVUZzhr?=
 =?utf-8?B?R0cvbnFRbENyZ1N4UERwczN4SWFua3JBZEtXbEc1NWx2T0JnM1dTTkRuTnh3?=
 =?utf-8?B?aUJBQlNqc3ZBVktBSElKTDZUY3F3ak9jalNKVFpoS2x0aU04ZkpmcmxqcDkw?=
 =?utf-8?B?LzdkTlAwcWhkR1hacjIvam5jOFFjUlFQdGNnMUdKT1A2ajhxMHo5eVZPZjh2?=
 =?utf-8?B?STFaZi8xZjdjbTNjeDBMWkx0V2xqdVRvQWZ6UXVnakJweXJNbitseGNsN3hC?=
 =?utf-8?B?ZUNyV29kM1hsSEdaeUdjRVkvb2lwb25JSEUrd2dycFA2c3BZR0hDeGhlMnR2?=
 =?utf-8?B?K2lwUERnSUZ2Z2MyRkZTc1BCTk5mZEdQci9SNUt1ZnRUODZFQUVJaXdsREpP?=
 =?utf-8?B?TnJ4S0l5V1B5WnhRdlJxMC8zY2o4dW9ud0xHTVVXTyt6akRXbEJockE1WDZr?=
 =?utf-8?B?MlFOTE53UFh1MGd5RGZFUExwMm9zMjVvSnoyN2VUZTZKTldqL0RBNFRTM01o?=
 =?utf-8?B?eHFhai9Gay9xVTBSeXIrbHI2RkNKRy9jTU9kREI1U1ZHZUpQQTlDbFJTV1BO?=
 =?utf-8?B?ZkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 39ec07ee-ab29-4c38-d4a6-08db42c5a0f6
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 00:07:58.3265
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: arrfbAcX12kRHo8Nmz7QCrphNkj0K8RmME7JD9FL09Z25n+8bFOg3rvhSO08YDb+wKxw8YeeJ6Ca25qIBOAelGSYCK5iT2URQ8B5XCsRZX8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5937
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 4/18/2023 4:44 AM, Ilpo Järvinen wrote:
> Makefile only lists *.c as build dependecies for the restctrl_tests

dependecies -> dependencies

restctrl_tests -> resctrl_tests

> executable which excludes resctrl.h.
> 
> Add *.h to wildcard() cover also resctrl.h.

I find this a bit hard to parse. How about
"Add *.h to wildcard() to include resctrl.h."

(considering the problem statement indicates that
resctrl.h was "excluded", having it now "included"
seems to match)

> 
> Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data")
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  tools/testing/selftests/resctrl/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile
> index 73d53257df42..2dc7da221795 100644
> --- a/tools/testing/selftests/resctrl/Makefile
> +++ b/tools/testing/selftests/resctrl/Makefile
> @@ -7,4 +7,4 @@ TEST_GEN_PROGS := resctrl_tests
>  
>  include ../lib.mk
>  
> -$(OUTPUT)/resctrl_tests: $(wildcard *.c)
> +$(OUTPUT)/resctrl_tests: $(wildcard *.c *.h)

How about a simpler *.[ch]? Seems like this pattern is
popular in selftest code.

Reinette