Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4bae56e1-9223-7d94-e6da-72504f3d0be3@intel.com>
Date:   Fri, 21 Apr 2023 17:08:21 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v2 02/24] selftests/resctrl: Check also too low values for
 CBM bits
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Shuah Khan" <shuah@kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>
 <20230418114506.46788-3-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230418114506.46788-3-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REhGSUZiYm1ILzZSdTNmbkFCeXhRaVJLMDdTZUFzaG5MalRrbU1iZFhOQ1h3?=
 =?utf-8?B?YlhrWU01NitFUkd3YXU0YzhsOER1Sjd4emJ1M05UNkFaSWV6Z3hoaXlzVG01?=
 =?utf-8?B?eHkwRXdieitneXlEcXFnc1lBQWszWnp0ZFhyaDRQZ0UwMlhvT3R1MDB4elJa?=
 =?utf-8?B?N1ZRTGpudmhGdzVKSHNjWEZLQ2QrYnNZeUhKMTVqWW1ML2tmR2c2RXlQamhY?=
 =?utf-8?B?ZGdHM3M4L3VQMStwdmdkTDFLcndXbG1wUnFIQXdDTTN1MzBzVWFXSDFKMU9j?=
 =?utf-8?B?OTEvUTY5Zm52K2dQSnR5K2IvZ1pBdDk0Q3BGRTV1Vk94U1gyenpnbG9NR1pw?=
 =?utf-8?B?RUQ1V05hbW9MbVlQZGFmVXVnOE4rdDFsOWVRM2l0SENIYWFLWVRCWEplcEJE?=
 =?utf-8?B?bXZacDVuc1cyNEdNaWFpYTBUVWk4RmtVVkxtZm52QlB2YmZFMGN5YTVmM0ZF?=
 =?utf-8?B?emFCOXdGV2t4SlVaRTdONGpZVjB0aFNjaEZpeEtBRWZ6Yk1pa2J3bmdybWtr?=
 =?utf-8?B?bFllb0FRUFBxeUFmSlpqZXNabTlURmhpSXdKT3hycUxyL2RVS1RFZGlLeXlU?=
 =?utf-8?B?Vm1KV1JJZ2F1NTVwckZNZkhuV2J6a2Z1VXhxU1JxekhhaTlJSkxsTFVNNzFa?=
 =?utf-8?B?RHgvWmRvS0pYc1NoZE44bEZKdHZVSkhoS1lMOC80NWlnWUdyZTRTQ2c3VHBw?=
 =?utf-8?B?UUZjSWFicTFVVWFlV1BsODd3T2dIaTA1UE91bDQ2b20yK0NvS2VYcEtLZWNx?=
 =?utf-8?B?TEZVWUZQeHM1TWFZd0ZHLy9JemVuQ0JLdHpZL3ladXdqdGdTVVhycU5xZkNz?=
 =?utf-8?B?R2RQMnNZSUZSMjloTENGVDFUQy9pM0YzNXkrNXdQMUpUT1BMZGt0N1EwT0Vk?=
 =?utf-8?B?blh2Ti96d2RwQW9EU3c2TGhFNGttaEt4eHA5ZjVsdU9zWHFTSzRoeUQxZkNC?=
 =?utf-8?B?UTV3Tm5IK3MwV1RDbXk3WGJqcytweXJDUFJ2NVFNNjRUa1B4dXorQ0ZpVmR3?=
 =?utf-8?B?T2Z3ckdqbnpVbE5XZ2xTZnNHVXlmY1RUMUwxanhucGJnQ1VQU28wcWd3WVEy?=
 =?utf-8?B?a1JnN3FRYm9KN3AxaU1iRktxTkdsV3pqL2VJK3NXZU5sTW8wTnpDa0xQazVn?=
 =?utf-8?B?OHpRbXhCQzZBZ1U4NHMyTUs5S2drT3R1enVLSnNSSjZVaDNwQ0ZBZ3k1cEpJ?=
 =?utf-8?B?Qmt5NFE4QlROZlB1S1JTSDErRHZZRXg1TXUyTjFpdXJPc3FnYnNhdkt2UXpK?=
 =?utf-8?B?UzNBakxCRi9IdnhDSzlPcG1PalNBL1RwVzM4SjNDL0hWT2xidkpmdUYyb2tM?=
 =?utf-8?B?N3JPSjRab0dUNFh6Z0IzZ3U0bm9GSDM0M0V2Mnl5aFFmRktEZWFtTmppQWoz?=
 =?utf-8?B?WUFLelZRUEZVYjJrU1ZmRENCbWM1WURzRWhJMjhqRVZPWG5FZ09oRXNEV3pa?=
 =?utf-8?B?VmU1UzhlKy8xQnF6SklVaTN6V1B0ZjA4a0RmSGFHMEEwQ1pWT0x0bDI2QVVX?=
 =?utf-8?B?V0g1cE1KWUZTdnJTTmhFeXB4aEsvaGhzelh0QzgwNjgvMThkbU9TVTgvV214?=
 =?utf-8?B?azJjbG03ZzE5ZWJDaHhqVERSRzhPNUZneVJiTlVSOFI1dUh1YlI2ZUNkRzlM?=
 =?utf-8?B?L0JrL2FTWDFZOUpjU0RUT2hXSkw0SEl0dlp1SFB6MGxpRkx6ZFN0dE1YaTl5?=
 =?utf-8?B?OFI5QlpKc3JlTjdhcUpRT0tRdWNtRVZQakNjR1hWOGZpaU1ndlJ0ZlU5bnJw?=
 =?utf-8?B?cmY1ejArKytyVGFJZmRoYzJMQk5ZN3h3OU95RmlsWjRtaDQrU0FzUTd3eklm?=
 =?utf-8?B?NElnaXlBTVVXTEtmK2FNQkNIZitlN1FYK2pJMmltY243NlJFandXUG1sYTBV?=
 =?utf-8?B?ZFR3RSszU3drTXplZ1d2S0NTa1pEN3hjUzRnRGhWcE9BTVkzY3FvRUJwaFVW?=
 =?utf-8?B?UDFuQWs2U2xzVWJiS0dlK1pUbThUbjNvRkZ2VFZIUVRjWCsycmFkTmJPZisx?=
 =?utf-8?B?cStlS1U2cUowRnNiUDdDVllxYVRIWVgzVjJOTGFDTEdXT003VUVudlFQaFpu?=
 =?utf-8?B?bUIzY1huN01JQUNZMTlZYUsvK0t0V3UxZ3VreWw4MVBia2t4bEJKWjhNNDZr?=
 =?utf-8?B?V2JZRXhDcGI5T0V4ZXZUODdMamV3a05IaDVlZ3MwcTZPRGhabEJ2U0VGYTEy?=
 =?utf-8?B?UGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 57687a28-dea4-45f7-b0ae-08db42c5b0a0
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 00:08:24.4350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zNtglNa8oByy/V8o50d4BWosBKsRa0RAaFHTfneavw7X+Y75WfARDFmiEUQeY2mzPeq2cMRFC7fGLVfWcwEUYl8K8oXWZYCd+ZjZQkH4GMM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5937
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 4/18/2023 4:44 AM, Ilpo Järvinen wrote:
> CAT test only validates that the number of CBM bits is not too large
> but it could be too small too.

Could you please elaborate how this scenario could occur?

> Check and return error before starting the CAT test if the number of
> CBM bits is too small.
> 
> Fixes: 09a67934625a ("selftests/resctrl: Don't hard code value of "no_of_bits" variable")

This fix is not clear to me. This commit being fixed already contains
an explicit test that will bail out of no_of_bits <= 0. It is not clear to me
why it is necessary to adding a test for < 1 as a fix for this commit.

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  tools/testing/selftests/resctrl/cat_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
> index fb1443f888c4..722c9cd4120d 100644
> --- a/tools/testing/selftests/resctrl/cat_test.c
> +++ b/tools/testing/selftests/resctrl/cat_test.c
> @@ -129,7 +129,7 @@ int cat_perf_miss_val(int cpu_no, int n, char *cache_type)
>  	if (!n)
>  		n = count_of_bits / 2;
>  
> -	if (n > count_of_bits - 1) {
> +	if (n < 1 || n > count_of_bits - 1) {
>  		ksft_print_msg("Invalid input value for no_of_bits n!\n");
>  		ksft_print_msg("Please enter value in range 1 to %d\n",
>  			       count_of_bits - 1);


Reinette