Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <59cfa762-24c8-5b53-feca-517250192d65@intel.com>
Date:   Fri, 21 Apr 2023 17:14:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v2 07/24] selftests/resctrl: Remove duplicated preparation
 for span arg
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Shuah Khan" <shuah@kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>
 <20230418114506.46788-8-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230418114506.46788-8-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ampRMUd1MkE3K01iT3JnN3NIUXpuOEhUR0pvSnZjRU5tWHZqNC9Ha1B4VW1i?=
 =?utf-8?B?b1d4UGhIa3ltL3NnZWljczNsS0tuTVY1endmemdkdVNqRGlaWlhZQU5odWcw?=
 =?utf-8?B?NzlxRHNjYzdvNUhnNUhlTHVzWDdsRlNldXlpQW8yU2dnNE0xZmh5ZHRELzI5?=
 =?utf-8?B?dFRqMklEUm9tMGpudjd3SXRON1JGcFVjU3FodkxVd2J0dHBSL29aWWY1OUZC?=
 =?utf-8?B?ckk2Tk1DSVBsTjJ1OTBjcHprUzgzNmRiZkhSZVlYNmkzNjBuQlhhTHBYRk5S?=
 =?utf-8?B?ZjVqNHkvK2MxSU1ESUNlU3B1aEQzdjNVbkpJR2lCRzA3MUZPRTI3SWJqZCtD?=
 =?utf-8?B?YWpmbTljUTYwaVE1a0tJZzVtajlJRHpDSGJ3R3ErYlBnVmFMalJ5ZEFQV3RM?=
 =?utf-8?B?U3FQaktoVFZxaXNZTEZQWUYzUisrTTdEWWlNbUI2OWhtdHkyVkJHOUowN2Fq?=
 =?utf-8?B?WG1CbEFSak9DVXE0bXNTYXp5UE5pby9QK1JsRzFRa1U0K0tnQllYL2tPY3dn?=
 =?utf-8?B?cjFqWElVOFBOK0pyTGU4SVBVeE9GdWkveDg3MWxNNjJVbU9ZZ1FtWFdoUW5P?=
 =?utf-8?B?bkd1RU1lTHhVY1VMOE1lM3NNdzdQZzdnay9VUTVQZW5UalJiVkltYUVSNTV1?=
 =?utf-8?B?WTBVRklMdjFHOXU5U0lHeWpHZjhHbjFnNndrNDdCVnNxRFpsOXFPUEh2eXF2?=
 =?utf-8?B?TWtFMGFqRlBEVUVCNzZXMDM0VS9VdFVOOVJ0bjdFaWVEOEphZnRTelZ5ejd2?=
 =?utf-8?B?QUFsMFVNWTBTR08zczAybWtPRlBLSnZlaHVKWXg2elRLRkhoNm5jeENKRDBM?=
 =?utf-8?B?Ry9sSCswSU1tbXc1NS8yeGlXNGRERVNON1QwTlZGSEFkK3RrT3JHRWYxT293?=
 =?utf-8?B?am11MFZKWkhWRXJRS2RIalZRemF1dnhtYUEwaC9XbmhyK1FxWFdFZE5lUkVp?=
 =?utf-8?B?S2YzYzZqTWpzdEJWdWJ5djRQQjhKUE94dFRXNmJpL0tFSWk1TDVHR0k5MG1Z?=
 =?utf-8?B?ZUFubTJWOHBZb1Q4RFRhYWgvTGNzcGxYOEZPQk1JNUJFNzNWT3h1bG5iY3B3?=
 =?utf-8?B?eWtiQndha2ZuYzl5OW9Sb0JaNHFyUUdKWjJ1T29pZ3VqQkp3aXpuM0xFQTZm?=
 =?utf-8?B?VWwzTEhQMnkyeWliK0d4Q1ZhSU1tZ1NxZDByTEErRUp4TzBMVzZYS051RGFk?=
 =?utf-8?B?K1pwdmZOSzREVENWaFNpcEw4K3ppUGJtUC9BVW1oWWVxbHNqTlYwKy9adWtZ?=
 =?utf-8?B?dmlxVlorR2JCOWN6alFuU3ZJVGE3c0lJY096Z1NjOGtnZWJ3VHE0VTFRZU9B?=
 =?utf-8?B?OXNRQUEzNDk4c1pnUnFlc3dWcDJRNmRLNHgyTWFpd2U3MGw2eFcxNi9jYm9j?=
 =?utf-8?B?NEtyTk5XVnlIUFVCV0xWTHVoVXh1R0t3cHN0cFZXT09lellqTjJSZGZ2OGJB?=
 =?utf-8?B?MGV2ekxQVEhpcXc5ZkMrSWQ1c3dIMFkvMHVUZ3JSVXNTakJrcGp5cXdBMkxR?=
 =?utf-8?B?djdkNWNRVkJZY01Dc0p5dHo2SFh6eTlyOCs0NUNTOEtXRzhBbFNFRDFLS2tU?=
 =?utf-8?B?T291R21udlZTZ29jVjB5aVdVYWpma1gzd1Z6U0x4eDBselo4QUVxZzZySzRk?=
 =?utf-8?B?ZXYvZGVwVi9mTytLOHJkUTRpQmR6ZWk3UmtIUzdjeHZrZWc5ZGZad05ZR2V5?=
 =?utf-8?B?Sk9UVUFSUGs0TncwckoyRzl1RXIyLys1NytudFc1T1Q3d0NtcEFkaVlObUpw?=
 =?utf-8?B?aTFTSHV0UWxXUEc4eEtIWXgzcm5KSEgvdVNuckQwcHRaRGhLRTlzRXlJQjBT?=
 =?utf-8?B?dEhhZ0ExMDdDTkFic3YyMy80QnJ1cHk2akhWNm0xWmlMQnVscTJIclJsT3lZ?=
 =?utf-8?B?VGI5ZytIc2lXaE42M2RiZzVyM2d2OXFIZ0gyZmlhenNtYWJnR2FaMzR6Z2Qw?=
 =?utf-8?B?b09BMHBtcnViZVNYMVhSbGNxNkR0aG9SQ3ZIWEhjZ0hqTjhYQmw1M2ZXUzBB?=
 =?utf-8?B?bGsxV016aXFtaUY4a0JyV2pSejBxYVcyNHluYVkvQXZtY3FQUlNmaWpOWWJ4?=
 =?utf-8?B?OVRvRENxMVJpMENpakNCaGl3dGpLa1R5MHlDbEZwZXVmYjVPd04rTFZvVC8z?=
 =?utf-8?B?RS9qQUVCejZkV0ZXb2FJcjZOY0wvTWlJL0pzNzdMa2hGYW5QOE9pQkhEeHk3?=
 =?utf-8?B?Qmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 37d4d7ae-ab29-46ad-c676-08db42c6822a
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 00:14:16.0196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rZIqbKey1w5frV7xa5geopBlkYjpgjf98QAaoWwCHMl8nLUHJ2ZfluivyXSH1dXPVK3Wu5YTaVXfWtchjidYsj0wiUEzwxkleE0MgQU/db0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5227
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 4/18/2023 4:44 AM, Ilpo Järvinen wrote:
> When no benchmark_cmd is given, benchmark_cmd[1] is set to span in
> main(). There's no need to do it again in run_mba_test().
> 
> Remove the duplicated preparation for span argument into
> benchmark_cmd[1] from run_mba_test(). It enables also removing has_ben
> argument from run_mba_test() as unnecessary.

I find the last sentence a bit hard to read. How about
"After this, the has_ben argument to run_mba_test() can be removed.".

> 
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  tools/testing/selftests/resctrl/resctrl_tests.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index f1ed2c89f228..3c8ec68eb507 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -99,8 +99,8 @@ static void run_mbm_test(bool has_ben, char **benchmark_cmd, unsigned long span,
>  	umount_resctrlfs();
>  }
>  
> -static void run_mba_test(bool has_ben, char **benchmark_cmd, unsigned long span,
> -			 int cpu_no, char *bw_report)
> +static void run_mba_test(char **benchmark_cmd, unsigned long span, int cpu_no,
> +			 char *bw_report)
>  {
>  	int res;
>  
> @@ -117,8 +117,6 @@ static void run_mba_test(bool has_ben, char **benchmark_cmd, unsigned long span,
>  		goto umount;
>  	}
>  
> -	if (!has_ben)
> -		sprintf(benchmark_cmd[1], "%lu", span);

Can "span" also be removed?

>  	res = mba_schemata_change(cpu_no, bw_report, benchmark_cmd);
>  	ksft_test_result(!res, "MBA: schemata change\n");
>  
> @@ -297,7 +295,7 @@ int main(int argc, char **argv)
>  		run_mbm_test(has_ben, benchmark_cmd, span, cpu_no, bw_report);
>  
>  	if (mba_test)
> -		run_mba_test(has_ben, benchmark_cmd, span, cpu_no, bw_report);
> +		run_mba_test(benchmark_cmd, span, cpu_no, bw_report);
>  
>  	if (cmt_test)
>  		run_cmt_test(has_ben, benchmark_cmd, cpu_no);


Reinette