Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0926a288-fa67-5f47-42dc-bc08aa31889f@intel.com>
Date:   Fri, 21 Apr 2023 17:16:21 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v2 11/24] selftests/resctrl: Remove start_buf local
 variable from buffer alloc func
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Shuah Khan" <shuah@kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>
 <20230418114506.46788-12-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230418114506.46788-12-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzhsQkxVTXR3MU15NW84ajI4ZlliRXR0SldmNGl5WGJQOVBMSno1RldmbENO?=
 =?utf-8?B?WnFQUk40dmlVdWhtYVBVdDVSWk5iaFdFVndYbzIvRUNxWDM2Ym13UDgrS01T?=
 =?utf-8?B?MTNTS2tPeTZpSmJ3Rm9EMm1sazk1OFJjd1ZZWm5SZVZ3L1ZDdGJ0c1QzaVNy?=
 =?utf-8?B?WVRuVUlBZ2FDbHFVZGdSaW4rNHI3WkY5dXlUSUNLdVhVaFlEUkNHcVZHaW9U?=
 =?utf-8?B?TVZZRnRCclprYjUwN2JUdDlIUjhubXlzMlViK3M1elJJbGw3cU5QRVpaRms5?=
 =?utf-8?B?NUFIQmZPc2h6OGFDL25vby9UcmNiSzZMeWVUSmR1ZjkrZS9JUEcyb2gxTlVB?=
 =?utf-8?B?SlJhUy9ZM2NYRXhDSzRhYnhjZ3dROE1MVjJNSVRHenIxRlhveDJoL0JWYkIv?=
 =?utf-8?B?SmFlZmorcG1EeUdyeGUyVC92TDE2bnA5bEYveG9nVlhBbFRyMDVUYThhbjZ1?=
 =?utf-8?B?aGNlOUgxdDhNckNrQkJzeTF0WlBya0lFNHR5TjV0emNhUnc5dEpScFV4VjY4?=
 =?utf-8?B?L1JkRFBxb3ZMcHVyM1J4QTFMTE85QjdsSEhlK1E3d2F1cVdnbEpuYkRPYUcx?=
 =?utf-8?B?R3pGRkhHMnUxdVIrVjFQajZuSGg5OGdhUTIzRlprbkM5cU1sS0dNbDZSSUZt?=
 =?utf-8?B?WU5TQXZjTEF5NnE2NkRpMnpYbHYwQ0E4dDdRb1ZPeW9aNEN1ci9zaDFjS3lH?=
 =?utf-8?B?cVk2NUdxZGVuNmtad0JqVWdBdFpuQWtiektKeHZDTXJjNGloZ1BGc2ZnVWZ0?=
 =?utf-8?B?Q0RvQWpXR3hxWDc5alNpeVI1SnBxbWduUjBpT1ZxVnozcVByY1R3bVk4RVg5?=
 =?utf-8?B?bE9lRkVFb3JhT3dzR0c1Zm9EN1VRd2tIdmVlVy9xalBXbEI5QXlISTFCQ29N?=
 =?utf-8?B?RkkzajVYTldhVWRaSjBjVWhDYXJwZmlaRzB6STNCNnZkc3dOeEo0SUN3djdt?=
 =?utf-8?B?KzBJUTFwRGdOZytzNmpXMjk5MWZHU2kxYnNCRFZ6ckx4K3IrU0FQSmRyWDl1?=
 =?utf-8?B?S1c5UnQwWlgzY09GRHJONVI2U0VyRHp2b2d4Z1U4Zk9Zdk80UmJtbFB3cXM0?=
 =?utf-8?B?eFFad012M24yaWJZNlNGMnFmS1lyakNzaHdtTGFjTzBKeTVzV2dBa0pJNk5D?=
 =?utf-8?B?akE5UkdFUEhrM2xKem5yMnh3WVBScHhINFhzRUdrdGpDNnF6UGpFZXJ3bmFp?=
 =?utf-8?B?aGxtT3MyU0lOc1FJZkpKUzNHamc1aml4cVo1WjVhMXhFU0tlaTZLT0REd1Jp?=
 =?utf-8?B?aWxGZEFYM3dNejlNcWk4N3ExZTl6K2NxazcrYWpFZFNiSDI1M2dYU2NOc3Fj?=
 =?utf-8?B?UUsydDk2U081amhnbS82SVlRM01IckZCRCtyWFIrREppMkZGT0pqKzZrOElH?=
 =?utf-8?B?c3VNSkFCWmpUOTg0V2owa2x1T1ppQjlkYzRFeHpzL3BETGFCc0ZhbVk5amNF?=
 =?utf-8?B?UnBNVlMzN3lkT2V5RFl0RXlhNER5L3NZMEVpNm83Q0sxdTZBVlJYNStSMzFh?=
 =?utf-8?B?a2tuSWZ4YVdXR3dHNjhnV2FyQytSQmlLWVFSSVB0WmRWL2pCMVVRcVE1VEdI?=
 =?utf-8?B?YnRFKzBkMEFtcDc5U3hFemt1WEZxVmFHUEtxV3ZWQnJiZERNUUFrUWdFYXkw?=
 =?utf-8?B?SzNMZzFqOFhPSkNmZ1MzajFSbElkTSswTFdBOVNSOHJTYWJ0MFJTU1AzYmRk?=
 =?utf-8?B?QVdMR0lrZnpJVXpRc3hQSk81amRXVy8yM081dzBsVXFNSWlTVjRQcFh5RWNj?=
 =?utf-8?B?d2xIRmJ6bkRFQjEyYjlrZk9nVGczdjVJTTB4NHV4SmFtYS9VL0N2a3IvTi90?=
 =?utf-8?B?Yk1xWVN2LzhqS2pXL2dZbGpadU9FNmNpbitUUnlBVjNVUG1vSTNyTVJOMnhz?=
 =?utf-8?B?WW5IRStZQ29FS0E1enBVRjl4K05zLzhUZ0VDUUF3cm4xWmZ6dlZjeG9pd3Jm?=
 =?utf-8?B?WnlJRVZKckxBLzBkTkE3NVZOYmhjSTEzbERGSENySmMvWGl5ZkFod2dmTTQ4?=
 =?utf-8?B?bS93S1lCZjh2azNDUlc0U3RUZ1IrYzFnbUxoN0xNZWluaUV0OXJGcWNzZUJO?=
 =?utf-8?B?d3hPT3lJcVpBRUNGNWtMTVZYbVFaaDJjOWd6S20yUzBIQkhxMTlmQTBydXZH?=
 =?utf-8?B?N21mS2lLNUdSb3I5UGZSRWJJSW5PUlpIVWJrbThEYXlCaFFCY2cwTFVIdHBL?=
 =?utf-8?B?VkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 91d64e5d-c7b3-4501-eb61-08db42c6cdcf
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 00:16:22.8646
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4oLiANMsX7ChfwS4uRuhdjjmLd65kJe7oG8p1reZNL5T5yw+b2wVkLSlnT6BeMMoNiSPE9MqR5MnGHaEcDqGZBBcsj10rajWECQ1lyHl7DE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5227
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 4/18/2023 4:44 AM, Ilpo Järvinen wrote:
> alloc_buffer() has local start_ptr variable which is unnecessary.
> 
> Assign the pointer of the allocated buffer directly to startptr that is
> a global variable in fill_buf to simplify the code in alloc_buffer().

I think the opposite (removing the global variable) would make the
code more manageable. Tests manage their own buffer pointers, there is
no need for a global buffer pointer (that I can see).

Reinette