Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <455c986a-0d51-0302-d5c3-c6c0f1cc6bad@intel.com>
Date:   Fri, 21 Apr 2023 17:20:10 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v2 17/24] selftests/resctrl: Replace count_bits with
 count_consecutive_bits()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Shuah Khan" <shuah@kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>
 <20230418114506.46788-18-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230418114506.46788-18-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVREQkMxaWZoOGVmVEJWUVBzUGx5ODlseElPZnJBa0JqZGlrY2lZTk9rTmtY?=
 =?utf-8?B?ajJrTTQ4d00rL0VtanNOK05LZk81aVVXM0hFMXBPVnkvblhibmY4YU9POGVq?=
 =?utf-8?B?Zm5DNzR4UFZTNHFLU2ZiSEN0cEFTNmx5elZWUXFxR2NiSDQrUGJPZXgwZUIw?=
 =?utf-8?B?cUJqZ1RaSlgvNDI5VTVNajFodCsyampxWFdkajJXVHNIT2dtSEw5eDlacGxV?=
 =?utf-8?B?R085RERTWHVMRXNTRE96QkQ0K3RBK0xXR3A1NHRuNnYydURwVURqUCt0N2Fy?=
 =?utf-8?B?WHBjMlFMT2FraUZLOUV4Z0NEREZhdHduRTAydTNPbVRFMlhoWVJ4KzFWRUVL?=
 =?utf-8?B?VUJaTSt3K0hCK2lpOU5EQVRaNWlOcEdlei9nWWkyYnpnVWY4c1hoWDk5aDZM?=
 =?utf-8?B?N0FNTU5wMDFSNlk3V0NBQ3phMVA5WlRrNXZFc2tUczRmTERVUUQyaitkWXZs?=
 =?utf-8?B?aS9PTzVnZEVsQVd0Nk9oeStPZjlhaklqTmtCZWJkRnQvRXdzcjNua3RLaHRE?=
 =?utf-8?B?bEk5L1dsbytLL3drWUk5eEhBMkhtRHpkMGx3SlB2ekdHNjdLNEF2K1N5UkRs?=
 =?utf-8?B?emhJNGJyL1l0WEo5QmRDQTZrczA1WXJaZnBGaXo0aUQ2dnVqZHZob1czREN4?=
 =?utf-8?B?YVJRM0ZSQ29FOFQ3cmRxeEx5SWFzdFlZL1hVUkhCMG9XWjUwL3RLNmM0bDVR?=
 =?utf-8?B?cC9WT1o2ZXhyWkVOVDg2RFg2NmdjdGE0Q0JQaUZ1V05vR1VDT3BHK3l1bk16?=
 =?utf-8?B?eGpHWjNMWVZ4YnlCdFNjSGxhQS9VQmRuK2ZGMFhCeDF3STJnWDBrREZMeVUz?=
 =?utf-8?B?dzNqcmY2WU82ZWZ6d042RTFaMkY5UitwRFVvdU1LNTJUN2RIZW1UeW1XM3FV?=
 =?utf-8?B?R1dCaWhsOHNqMzdqMFFGNzk1UE1mOUFJSXpVZ1ZCZUVsblc0UG5XNmsweGUv?=
 =?utf-8?B?bG1EYkhyT0xoZ0hkdXBDT3hpcWhPejg4d0pjTG54OWRZODNLdStHbU9xNFRY?=
 =?utf-8?B?NDdsOFdrOGpZWWxWVW9PS200L2JXeVBlVGQyeFR3T3VaZ2hzNjh0eEpQMkFZ?=
 =?utf-8?B?OE81RmM1MEN5bHRROE5WaE5JbmNIckdOWDNwaVVmMWpMM0dNVnI4TnpuZzFJ?=
 =?utf-8?B?NWM4Szl3cXB5enlkVUM1c0hLMEFQeVVHVnJrLzlrak45Ny81M29PbHROSjdy?=
 =?utf-8?B?dThDYm16eTIyVDg5SVRVcnV2RG9aSWsvRTU2b0dTYjQ1REYvK1pkWFFZRWpC?=
 =?utf-8?B?NWhuTDdYT0NBSmxmKzc3OGZGQmlENmRtSnNWTUZObnc0cVlTZ1ZhYWRlejBr?=
 =?utf-8?B?emVTY3RDcHZ3VFN5S2FqMXRDZ01zV1ZNRDdSYjJ6YzhsbW5WZncrc0d4SFE2?=
 =?utf-8?B?ZGdWVTJYaFVzTVFxUmFuTW0rdDQwc281eHdxejlIdlZ3Y0t2U0FsdVlGVmJv?=
 =?utf-8?B?VEJuZTBGVUZaMi94b09qaWEzeUJkaGZBYWtuZHN1aXNPaHpBSUdSQWluV2xj?=
 =?utf-8?B?cnpFbklaTVNiTkQxQTlKUE9ERGRkOW00dld6TFRCM1ZSNU9EeVNoSExxOGxY?=
 =?utf-8?B?RVpEdis4L3FTSjJMUU1mVUhNVlZGMm1Bd2RTY2VkejRxK2hNdTE4a040dHZV?=
 =?utf-8?B?TFFrcGx6TS9DYXU0c1dpZnErcytTVStSN3pBaUNjMXRHMUpoSlZtUUFKZDhm?=
 =?utf-8?B?RmFuRFNhL2RKWHJLOTRvcUpoOWlzd1BVWGRtb2lIeTIxTkp6UkRLRm5tR3pB?=
 =?utf-8?B?WG9xUm1IR2tVV2dYMkFqUVduMEk4dmJYZVJERGlYa2h5UDRicjBIYWhWclNx?=
 =?utf-8?B?bGpPYVRHa3VSbWVFbE5kZVVjSmNZZi95MnkzMUhjdWFBNUhkT1FnT0FWQU8v?=
 =?utf-8?B?NGlIRk1FTTlEdnRIR2F1VjRLSU1peDJGajVtZjRQTkxFdStWcDdxcU55c1dL?=
 =?utf-8?B?eW40eFZud2RLWmszakt0azF6UlRtUWFjSHRCTmNhb2d1dXEzZmh6anRsSTlY?=
 =?utf-8?B?aXVvcDhja0xZdlpWV1gvSHkxKy9PaFNab1dlekFCNXAvaGxJaXBqSVhwVHV3?=
 =?utf-8?B?WWZ0UFlEbHAxNFVwc3RrVEs3RDBOVnV4UWRNUjRwY2ZobForcXRVbDU5STVG?=
 =?utf-8?B?bnZSbHpHU21BL252TlJWUTRLQWwxbHNpTEs4T1p1SWFjcmJpc2YzMmkvbFFx?=
 =?utf-8?B?ZEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 075d0fa1-5a48-480e-de32-08db42c756c9
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 00:20:12.6600
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sknO0RBlroRVs6jiIttzoegiU2ujmQDgs0PqnDhPHfAylxoXPe0dWZipu4KEBpyYf8OBPmXVYfBWkOGLpWNp6FGbYv3+t2NGKJfQDQoeELE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6304
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 4/18/2023 4:44 AM, Ilpo Järvinen wrote:
> CAT and CMT tests depends on masks being continuous.

The term used in the spec is "contiguous", using it here
may help to convey the goal.

> 
> Replace count_bits with more appropriate variant that counts
> consecutive bits.

Could you please elaborate why this is more appropriate and
why this is necessary? What is wrong with current solution?

Please note that cbm_mask in resctrl will always be contiguous.

Reinette