Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <83a61c92-01bf-0ac3-709d-7ba2ed0259b2@intel.com>
Date:   Fri, 21 Apr 2023 17:12:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v2 05/24] selftests/resctrl: Make span unsigned long
 everywhere
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Shuah Khan" <shuah@kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>
 <20230418114506.46788-6-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230418114506.46788-6-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTZPVmhyOHM3UTNkanA0SzhwNTFmcFZJdFBBSTBJVU04TzI2bkJDMG55d3Rs?=
 =?utf-8?B?SjJsUXZ4VFJkL2VPTzlBU09TS0VzRFlIT1ZWd0JLaUpsSGRtczhCTVF6YktB?=
 =?utf-8?B?YWUrZlJEMVhUTjNXSWtGT293WW5nb3JxbGRRZHVqVnZKemtCaGlvUlQwa0NG?=
 =?utf-8?B?VkNkR2xiK0xlOFFBWlFtOXFJK2JnMGJsRXBzNDVzbVdKNXZiMVdmeEE0ckE4?=
 =?utf-8?B?V29CNzVhbVoweWRNWFZSZjRCWml6Yy85S3pmK0E5YVcyajV5SnBGSUo5SlFu?=
 =?utf-8?B?UFQ2UjdOWU1EZ1lqdmNuN3BGSnIxeElOaHc0cFgzemtJVXlPMjQ3cjN4M0R2?=
 =?utf-8?B?TXJNT3JZN2lJdEM2Yk9ZaHlyUC9VenVKQ3BLL0VPc1NHOVUvTVAzU0MvY3Nn?=
 =?utf-8?B?ZlRWU2JWZWlqNkkwWU9MbEN5dGxwVGYyeUZBMGZVZXdmTktyclRjL0dGSkNn?=
 =?utf-8?B?WUtPMEpvSnB0RnZrT3Y1UnRBUEZyNlN5K00wdklDYllSb1ZMSURwR3JNVnIx?=
 =?utf-8?B?V1hKeGloY0ZXeklrWFRyc0l1TDFTNnJGaXI0eGFqN29DMmtiOHg2Q0I5L2NF?=
 =?utf-8?B?WkJTazQ2czVER2VZaFdEN1QzU0RhZldNMUdFZlBxWnlZQzdtVGkrc1cveDhu?=
 =?utf-8?B?VG5nTjc5N2pRZnVXT0hOenRBTFM5S0lGRHhnRXpkT0c4QVNpaTdxbSthSTFn?=
 =?utf-8?B?enBrRmI2L3czRWUxV2h3N3YzejFtUWxZdTlFNGpNSVhBbjFDbm0xNFc4SndU?=
 =?utf-8?B?ajEvSGhzT0c4dk1SM20xSWMwZ0JtRmFtS1BBdWNmaHdkVFlOQ3VJemY3bmhU?=
 =?utf-8?B?dEhpYi9UbWY1dGJDT2xPRlc0TGJBeC9DUGdobW1NKy9wOTR2SVhzL1M1MlRJ?=
 =?utf-8?B?dDUyQ0dCemxDSXhOZTZoSURIaWdGNGpnZzd4WVlyekQ2Y05MSDhsQ2IzSXJV?=
 =?utf-8?B?YXloVG4ya3F3bFkybHNmWXREMUNNWktzeWhNUnpQYjNvQkJWZ0JZeXY5Nkk3?=
 =?utf-8?B?Y2UzRWVLMkZ1bDUySzZ1VjVkVWhhUDQ4Q1hwM1BwNHJLbFJ3bjRBMXI5WDRB?=
 =?utf-8?B?dWd1dk5WWFF6S2RmVWo5aCtZdmJCK1l2ZnlpVU9KTFc5OTJ1Q3hsODIyRnJp?=
 =?utf-8?B?NVRDejVKQlMrUnlZTlZ6eHJkbk1uQTVSNTI5Vk1Fb1R3bDI5NnpscVVpQ01I?=
 =?utf-8?B?YWZsVmVpamJPNVVmb3FLM2FqUnVBSnllMkd1WEU3UmFGWUFLM2VwOFZZcXBG?=
 =?utf-8?B?S2JxQTlSN2xKMUhzejdYQUhVTTM5OWN5ZDRZdGtsMzBUdmg0QVlwU1RNTlhY?=
 =?utf-8?B?Vk4yd3Q2b0s5ZmcxdnU3UzhXcHhnL0FjQlFSNGN1TmNUNW8rSFpRdWd4VDh2?=
 =?utf-8?B?VmNwdERLRWpwTkRCbW5MWlBWb3g5SHorL25RZSsrUC81VFJMaU9hU2NpOVl2?=
 =?utf-8?B?MGlpY0lGQ2o0ckFtKytlL1JjV3lpMWFEamR3UWdPWFJkMG00R3B4ZlVsNGRL?=
 =?utf-8?B?dlhscjJsYWY1OTBQUm5RY0FzRW5jMGJyQ0NCN1UyQ0laMjdtTUVkNERNRkxR?=
 =?utf-8?B?aFY5TmNPaGlobXpBblRnb3RPWWg2ekxtM3BIcWJ3cWQ1SnZIQTkxbFVDdllL?=
 =?utf-8?B?Q0ZFZ2JEd0dDb3dldUR5b3J2TGdua1Rna285R3BxRENGczN6bGpWK2dZeWVp?=
 =?utf-8?B?K1FKRHppcnJSZHNBdzZZRkFNM2Y3YmVzS2RQOGRGZnpvMUNhRkI3ckNnbGp5?=
 =?utf-8?B?cFJNcysvY2tYYW9rLzBsek5YOXFRcGJzN1RFUkhsS0F6Z1djYU1nSEVZWFlQ?=
 =?utf-8?B?VlI0Wk85bUY0dVBTTzJqWk5ocWV6aUdnanAxYXllYkp5SXlna2VpeDUxQUl1?=
 =?utf-8?B?VHIwV1UzMngrNEdaNWF6Z2RLaVNvTW9hbkFvUDRIdCthQ0JVenRYeHVUNlFa?=
 =?utf-8?B?aUhSN0tSUCtHVE1oMnNjQU1SUG1rdnJ1elNNQjVnT2VVaVc1VFJ6VXhRa0M0?=
 =?utf-8?B?c1YwRG4rN2RYd3FxOG1rRS9pWitFTTJldUcxM1FyVjZYbm5JejQ5aHBwSWd6?=
 =?utf-8?B?M3NiUnJoRDl0dUZmVDhNNkgwUCtnY1Zkd3RrYTAxa0RQckhVdkJFME1KMDYz?=
 =?utf-8?B?YWYwV0tBaG1ZcEh6M3Bldll2emdUeXdhNk5OT29XUmh3VUxHSUJJa2s4VEdo?=
 =?utf-8?B?eUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7897c56a-3acb-41df-108c-08db42c64706
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 00:12:36.8120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k96zGqYZtkQcdAiDEmbiQhxb63gfE+QpblSJUHmhgZpoCsRMQxXOLX+Bz3SnQhiAZH+ZnrR/Ijp63EoXlU1w6fok+D5qqMgMiy2zSbkAsrE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5227
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 4/18/2023 4:44 AM, Ilpo Järvinen wrote:
> fill_buf(), show_bw_info(), and resctrl_val_param.span define span as
> unsigned long.

There is no fill_buf() in the code and show_bw_info() does
not define span as unsigned long (it is even the first function
changed in this patch).

> 
> Consistently use unsigned long elsewhere too for span parameters.

Is unsigned long the right type to use? Tracing through all the
indirections I do not see how making all usages unsigned long
achieves consistency ... have you considered size_t?

Reinette