Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <695f71ed-46f6-e287-371d-bb11f014148d@intel.com>
Date:   Fri, 21 Apr 2023 17:21:48 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v2 22/24] selftests/resctrl: Split measure_cache_vals()
 function
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Shuah Khan" <shuah@kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>
 <20230418114506.46788-23-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230418114506.46788-23-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHVqUkMwZmUyekNyN0Y3TXM5OUhNbjlTcy9YbkR3Zm5CTlpGR0lVZ0ZrNHJS?=
 =?utf-8?B?ZHh2MDJnRFhhZmJxZkZ6TVNrWnZDQ0t2d05XK2RhYlMzRGpJeXF6QTVwQmM3?=
 =?utf-8?B?RncxbDVqMUZIQUU4V3NuY09mbHNYQ3JGNUFsdzB5YjlPdGx0QTFXOHdjbHdw?=
 =?utf-8?B?RXpnMmduRW1zVUR0Wk1pZmpMVnJUV3ZrbGoxVEFmTS9zQWVIb1RSSEh0RnBi?=
 =?utf-8?B?dFN3V3pqWGJPdnJNekZMT1RRNzlqOVB4OS9SUW9VWERETUFZR29JVUFpWFNq?=
 =?utf-8?B?SndrODkxWmFMcjlxUUw4SHYyYmE5b0pSWmhmZG55M011UU1QVHN2TGdzMEs5?=
 =?utf-8?B?alJuM0U4bnBHMmtvWjFTQ2RIaFFPRzh0Sm5qRFhiRCtzRG1ZYUlkUFV0VWpl?=
 =?utf-8?B?V0JpdjJiUlRrNXFyR0NidkJ2bXYwNVhHTGg3WmQyL25WR0ZYWGEwSVllY1VG?=
 =?utf-8?B?MzllVnY5K2YyKzQwTG9aRFJINHhFVXp0clRrQUVEM2t1cUFzcGJXdklJN05y?=
 =?utf-8?B?aXV6Y2FwOWtlNWJZeXF3Mnk5cTN2WFVKcEQxSER0ZWRwRFJnNGhMN2p2SDZW?=
 =?utf-8?B?SFRHWGhjUnhOUnN6anpLb0gwWERUMFhuL3B1aTlsYTRlQ0prY0RUbTVUWSs1?=
 =?utf-8?B?VjRDMko1TnhBUk44S05TdUhIYTRFSldYSU41S2RMWUt6eTlVeVZBdTJEY2VU?=
 =?utf-8?B?MjlrbHlydFcrY3NHbmtvY0IxdmYrTkJoS0hUV1JDVmNoVldpVHdtdXZXRkg3?=
 =?utf-8?B?N0wzVTVUeVZwRVJQVUhlWjNCaXVDOG8vTzZXMGNQRW1pVC9qaVhBWHI2Zzla?=
 =?utf-8?B?eGFBUHFpYTM2VGUvNi9IOGp4S3RRYnFOeVl3Mzk3R2IydVpqUVBIckpycUs5?=
 =?utf-8?B?RkE4MkordVRodHdBbXNrNS93ZXdUTE1ZSzI5Y1A5VStSUzNWOVBUU1VYcTIr?=
 =?utf-8?B?bU9uQ1RJaWwzZ1NRVVBKb3ptSXNGeHBVL1pWYy9ZMGVPM3A5NDlrbXNzbGtE?=
 =?utf-8?B?ODloVWltQ1FwckFyWCtpMitlM0NoUUJSSEM4T3pyb1lhY0hXZ0VwbEhJZWJv?=
 =?utf-8?B?SnFXZE5sYWR4MkE4ZlMrSEd2UzhKdDdvVEpqSGJHYzdmVGRXejgzdlBLa1RJ?=
 =?utf-8?B?TTE1dVo1RlVtSDl2SnlROHpXTWxPSkVGVW1hT2x4OFhSUDlwR0IrWU9uM2NI?=
 =?utf-8?B?em9wK3ZwazhvL05WU2hYVnhyNmRlOTM2R2FpU0hKWHRpVHZ1UDkvRlVZQjk2?=
 =?utf-8?B?UklUL3JFcnBPaGd0b1NtOUllYXVRcCtqZFUzOUFZWWFYYjdQdU80WC9LUDFI?=
 =?utf-8?B?cElLdHo4SU01bGZscStISllNQnRNMVBjU1l5a0tXY0tYTkNkY2l1UW9LaWZw?=
 =?utf-8?B?a2ljRGEzb0VDQzNvWTMrdE1sdWR2cUZ6R1pQY0FaSWJHZFpLMDdwWTRIWUVs?=
 =?utf-8?B?Z1NBMWE1VU1GdUkvcXBXVjFoTEVZZkc3M0g5RUJhemhYcWJtR2xXU2VYbEhS?=
 =?utf-8?B?V00yTnFVdXA2UjFXVkhjdk1EV0ZUcnhBeGQxdG51cE5xOEswOGs5QUZETFIw?=
 =?utf-8?B?VnRValBYT3ZCUmtCcjlFcSs4ZHF5VTNSS2YvUXlKQmhOcS8rSXFubCsvTHp6?=
 =?utf-8?B?a1JneVErZ2s2ZjBnOE9FOGdJeFE4OWROMHRucHdYUFg2V2FpbWJ1cXF0MU5T?=
 =?utf-8?B?K0ljQmtzUWI1Z3I4ZW5hVWRCOGdMTDFqL0pTQ1hYSjNEaDJiVEI2elZtc0kw?=
 =?utf-8?B?TUl2QWFoMEdYNmUxU0ZHdk1ZQ1V3Vk92TUdGRUx3M3M3VS9nb29NelZpK2tk?=
 =?utf-8?B?eEF2MllwVUN1N1JSNklLR2RnR2dFcFpYKzdUck5YZkRuUlVMUHQ4eWp2R3M0?=
 =?utf-8?B?MVZqanFVeFNpaVB0Z2R6RytrMFpkY3RxN0FHRlRVdXF6R0t3SzNpMkxkcFFt?=
 =?utf-8?B?MHFRZW1Dell1MTEvSDZZK0VqOGpQWG5ZNlA3cjVLVTJ4QWFyM1VXc0VxQ1M4?=
 =?utf-8?B?WFVlVjZKTmVtQjFuNmUwU3V0b0FCRm9lNGYyUFVnblRvNFRFa2dGNEowT3Z4?=
 =?utf-8?B?eDlpODcwdTZ1c0w0VVQyYzlwZVlNSTNMdHJNTUxRSEFlMWJWTDQrT0g5Mmt5?=
 =?utf-8?B?bCtmL3lvRHhueGY5K1FFelEzazcrbjA1amRGckhPa3NuY1ZWdUllQkhYVG44?=
 =?utf-8?B?eGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 70bec18a-7022-43d2-ce80-08db42c79142
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 00:21:50.7744
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ytz8sYp9WiM1L0GczdmajfEIrrAvF4MXj7kF9SfLqTyLyv3MhLinX3cbAmGhjd3c73d5kvvNai78xMT/CZ5BfWGI+Vyp6gNkXf/GpZntvIE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6304
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 4/18/2023 4:45 AM, Ilpo Järvinen wrote:
> The measure_cache_vals() function does a different thing depending on
> the test case that called it:
>   - For CAT, it measures LLC perf misses 2.

What does the "2" represent?

>   - For CMT, it measures LLC occupancy through resctrl.
> 
> Split these two functionalities such that CMT test calls a new function
> called measure_llc_resctrl() to get LLC occupancy through resctrl and
> CAT test directly calls get_llc_perf().
> 

The changelog mentions 'split' but the split does not end up the same for
the two usages. Why does this split end up with one usage moving to a direct
call (get_llc_perf()) while the other usage remains with a wrapper?
Why not open code both?


Reinette