Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1778225d-87b3-fb97-5512-e78ff46d169f@intel.com>
Date:   Fri, 21 Apr 2023 17:16:40 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v2 13/24] selftests/resctrl: Add flush_buffer() to
 fill_buf
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Shuah Khan" <shuah@kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>
 <20230418114506.46788-14-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230418114506.46788-14-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0E3Ui9veUJjdDBzdUJnS3lRUEVCSmxJL21JSVh2am9GSmNNNm43OVNkUG1P?=
 =?utf-8?B?MkFhUHM2NStIaW9NdjMrb1Rsb1pPZkQ3YmM3RUFTbFIvT2JqZTFGYnlwOFZm?=
 =?utf-8?B?M3Bwb3JXbmhBUmg1Sm9HSVJGYXowRVIwUUxXS010K0xrTG5tUjFleHIvVFdB?=
 =?utf-8?B?UW5QOFhHcGZZenFTQlcybWRnQWhKR2FxdUF1SXVDT3ZMd3hDRGhWUjRJQ3ll?=
 =?utf-8?B?UFZRVWkwY1JrMGdNUEo5b3l3aVRUeWFIRFFQVGxHQlZGZm1FUkdNRVF1eEti?=
 =?utf-8?B?d0taRGp0UzRRT05RUnFhdEE0RFdMOTlWVGNJSzFYWkVGL3JwQ3p3VEVFVGlY?=
 =?utf-8?B?UllMU05nK002L3RLZ1BKNk9EeURibW53T0F1ck1QbjJWdW9OeXlRdUwvaFdk?=
 =?utf-8?B?eEhjc0sxb0RaNWJicnJGdUFobjBZOWxsMXhUMlJTV1pJTGlqY2QySlNNY1hG?=
 =?utf-8?B?T2toWmJpbW9SK3VUUmpvTE5uaFNibkhGbVF1V1NoSnpHc2d6Q0tyZVhqVzhu?=
 =?utf-8?B?ZHF6Ni9ibzVxZGc1VEN0dEJFSDIvWUJhSEtBT0FPdUVOdVJtZUllYzdmcmZW?=
 =?utf-8?B?Y0tKS2t3VkYweHgrSTVNYzVwTUNlRFJjUnJrOENYV2phTzZVeVlJdXBYbkZQ?=
 =?utf-8?B?MzRRTVBHSXc4ZTIyc2J0alNPWDUyUkFmbmRVbzIwOVNCSnpuTjJhK2tRMlVl?=
 =?utf-8?B?UGVFcXRtaUZtWDltbmJVZWdiUnN2dDM5VzNwVW11eS9iMFhCRFFYdkIwRVRX?=
 =?utf-8?B?ZzIwbTFjcUdLUFFMK2h3Tk53Qm4zNHJHNG95RXJKd25Vek0yZVlHTUluQWs0?=
 =?utf-8?B?Z2xGVGJpSjlDay9YS1JEZ2l0eDdESTY5dUNxTEJaZC8rK1E2Z2VOTk5PelJo?=
 =?utf-8?B?QmlhYUNZaW53N2M2cG5EcXhuSDVUbnZ2cFdGSUlsTEIzWjJGS2JsVVM2VElU?=
 =?utf-8?B?NkpCdGJROHRuN1ZHb0hTN0c5SVlQaWo3RmhoUmRrVGhjN3ViR29wN1BZcm91?=
 =?utf-8?B?M1FoQnZ1SElNbjhRcnV2UEZwS0ZPcFNFdHBKUlFjS01yN0J3S2NKUVBsRHE0?=
 =?utf-8?B?RDlVNlJuT1ByejIrbjBmdGNSTk5FamhkNHZXaVl4ZlpqVFlBMlBBTzZLT2VG?=
 =?utf-8?B?NE5FQzJxU1FvdW9OcSt6UUFPdnN1RjZHaUtCUTVLTXo0UnkzSVYzdU5pSWlS?=
 =?utf-8?B?Ry9lM1NDNE9YdDhFY1JTdjQzekw3bitvT3JYNThjYlZONlF6UTd6WUI0a0JE?=
 =?utf-8?B?K09nWWZ3WlpibzBPbzdyNGVoQVZubVNqLzBpaXZpMVVrTzNLUXJHZ3liK2ZY?=
 =?utf-8?B?QnpFNExBd2pqdmY3OGxsQndaSmxUVkVTOERzZVFkdHZ0RFBaNERRQk8rdjkx?=
 =?utf-8?B?YzA0SllRMUY1WHFiSlNDekZJb3B1Rnd5Y3lYalhUbVY3WXo4K3B6WXpsbW04?=
 =?utf-8?B?RVU4YjJZTVVlMU8wMUVBZmZUNHJja2VZVWVGSCtJMERQeE1OYml5Rm05VGgw?=
 =?utf-8?B?SGxwTlJqcjNUUjJhQWNzNk5uMGdxYko5MlYySFlURmswRktuUTExVjNFQTZo?=
 =?utf-8?B?eU1NNlNFZTkwcldaNFoyR00xOHZtbDdHS1Bmd0YvQS9WbGZXRmh2bHZnVnp0?=
 =?utf-8?B?eWVscXNWeTYrL083VkFJYmpjZUJHTFJhKytQazdDZitPNFV4ZG0rSU1sSnN3?=
 =?utf-8?B?THZEcUhsSjZEZDRaaDM3KzBoTkpjSGdYMnc0UDlTODdSUUhFNDRzbnNLcGR0?=
 =?utf-8?B?akNDM0hQRTVpdFlNOU1qUGdJaTZsREhiN3lBZC9UY2NDZ29BZENhOXI1ZU5k?=
 =?utf-8?B?ZkhQWlVVNThDdVgvdWNoTVJncktnT0h1M2JucGI1eHhhUE9xZGVZaFZ2ZG9R?=
 =?utf-8?B?QS8yU05RNGU1WkZJM2o2WXM4OXpodWJhakJlQnRpd042Zmh5TkdmT3FyejhY?=
 =?utf-8?B?OEtnYSt4RWYvTytqQnFBR0xoOWlnSHkrQkNWZ3I3UFEydUd4WkhucUhid21I?=
 =?utf-8?B?MGRSN21ZOEZOMHRSdmJ6L0NwdUJOY3QvZ1JFaDBuenovRlRPcGtGYVZpUXRt?=
 =?utf-8?B?eUh3SVBpTys2S1NVUFlTaFFGcDB0cG8vSEJCOUR5MU52SGY0V3FYeDVYUCtE?=
 =?utf-8?B?eW1QKzlTeW1rdzZrMFNKeVRlV0JsMDRnQ1pEcDd3Skh0TVdaNEtWOXFLVTRU?=
 =?utf-8?B?NkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a3df06b-45e0-4706-c91a-08db42c6da1a
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 00:16:43.4983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zf4znB/OinldvuFvEd+O6h5lmVYGp9iFbR2ZWxnTawtfBSjaj/JpNfOoWoLVDw9e7v/EY+fOK9aZp6pTSsVDY5KtoOgpOpvdkRq+bZvLq9k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5227
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 4/18/2023 4:44 AM, Ilpo Järvinen wrote:
> Currently, flushing is only done after allocating and filling the
> buffer and cannot be controlled by the test cases.
> 
> The new CAT test will want to control flushing within a test so
> introduce flush_buffer() for that purpose.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  tools/testing/selftests/resctrl/fill_buf.c | 5 +++++
>  tools/testing/selftests/resctrl/resctrl.h  | 1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
> index 677e1a113629..7e0d3a1ea555 100644
> --- a/tools/testing/selftests/resctrl/fill_buf.c
> +++ b/tools/testing/selftests/resctrl/fill_buf.c
> @@ -58,6 +58,11 @@ static void mem_flush(void *p, size_t s)
>  	sb();
>  }
>  
> +void flush_buffer(unsigned long long span)
> +{
> +	mem_flush(startptr, span);
> +}
> +

I do not think this indirection is needed. In the same spirit of feedback
to previous patches a test can manage its own buffer pointer
and flush it by calling mem_flush() directly.

Reinette