Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <79d76793-b920-afc1-51e6-9e38781e24f3@intel.com>
Date:   Fri, 21 Apr 2023 17:22:38 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v2 23/24] selftests/resctrl: Split show_cache_info() to
 test specific and generic parts
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Shuah Khan" <shuah@kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>
 <20230418114506.46788-24-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230418114506.46788-24-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmplODFGc2NBWUE1NHVVZnhrdytsWlM2WXBObkpRWk9HY0tUR1VFK0FOZW0x?=
 =?utf-8?B?eUdXNTBXSUJQTmN6T012NUxoeXo1NFh0S3FuZFZaN0wzTUp5Y0l4TkdIZFYr?=
 =?utf-8?B?MU1aa1NDSU5EVytEanhaVUZwZUswSk02R0FhNXdxczdHMTJtK04yU0YxemZH?=
 =?utf-8?B?M084cDZLVjRpVEswd0ZPb0I2SGRhWUhNWE81Y2E2N0hnTG5KMzdpUVBvUEJk?=
 =?utf-8?B?UCtlbXovMjVUM0JtWnpzUGlRWThsUlFvQzhaalBBQXhGVk1ScmdzVGthV3Zo?=
 =?utf-8?B?MFlSZFpWQ3c5NktkR0ZRZ1duMWRuck5qUFlvclV2UkhJZmxvclJteGNXaFF1?=
 =?utf-8?B?dTd4WEFxMHVmdjBIWUJCeTNSU0xBcHYxVE1IMkZHWWpIVDdEeGRQQzFZV0RX?=
 =?utf-8?B?VWs0c0dpeW9FcmN1OTlNREo2Z3oxVStTM2RrZGRvU280OVlSWldranZqRGhh?=
 =?utf-8?B?RWZJMzNLbVdCQkRMMm0yWTJsL2VwRUgrNllzWmQ4UUxjSitweVpWNFBQWFJ0?=
 =?utf-8?B?TUlMOFZuQ0s5Mzc5N3l1dEhFZkc5UnhBc21EU0pQcmJwNDU0SVJZSFlaZDI1?=
 =?utf-8?B?VUVsZUt0WHdRc2cxdnRhOG1GdnRPYTdKdktjZ0tmQzJMa3paTkVsQms1RXFQ?=
 =?utf-8?B?QWI3YzNhVEd4aStob1V5QjVubkR3ejRLdnFPU1ZCWC9vc2UyU0wvV1FkY1RS?=
 =?utf-8?B?WlQ0SFJRSURtZDgrb0t5aThWYTlxZFprQ2dkczB1b2hCMVowRmYzbWRTWjhG?=
 =?utf-8?B?UEJDbFRMMnlZNE9nbXJ2Y1RId3M4SXVjS3psNjdBZWo1UFoyaVU0NStkZTJh?=
 =?utf-8?B?T0tKSmlKR1hKM21Ga3JWYTN3UDM5c25oZVlwc0FvMDF6K3EvSVk5SGp3eUJx?=
 =?utf-8?B?bkhqbkI0NTV2K3UrUDdYS1V1eGhnbkt0Q1RxRjVKVWVqWXpwSlhnMVNDNnFY?=
 =?utf-8?B?M2FleG43NWZGb21JM2o0VFpRWkIyNXJuYWU4NThnT0VZekkvM2c3SlhzQi96?=
 =?utf-8?B?am9hd0xWRmZuL3RiUnlNOFhhWk90YmlJOFVBVFIyYWI5LzdvUlRVSUpaaDVu?=
 =?utf-8?B?YjdhbmpTaVZBNHRvdlNlWVpsSzRqR0xiVm5TSnAxZHRQZGo4L0g1WHBsRGp6?=
 =?utf-8?B?Tk1UYzYxZFNJc01EblZNOHdQOThMRUZ6OVZPRFJXRlJtam9FM0lqOEk0WTlZ?=
 =?utf-8?B?aFEwUThQbXRZR1V4NHFEWEJFK0pHUEg5czNvb3MwRkFFMWtCbjUvRENsUTJZ?=
 =?utf-8?B?US8yT0pHTnUzSDhuV1lPODVzcy9mMXZKRk9MR0ZhSUdmVElOcWFnZUxrNXdC?=
 =?utf-8?B?U3k0ajZsckE2MU9BOU1BeGp1c2o5RFdKcGhlMnpXc0xaWTdSTmVNMXZoczZh?=
 =?utf-8?B?d1NZT2FaL3g2ODd5ZW5YcEZ0b2w0M1FRWUtJbXNuV09YSGs3NitENzZJQkdP?=
 =?utf-8?B?Q2dxNlNOU251VEw3b2RKVEo0UFVVTno1LzVHMC8xVy9yY3lzRmh4cWkzOTZK?=
 =?utf-8?B?bEh3TUZ3aHZyd2hCVmduTlZkaVRob1p3R0ZrUEdsKzB2U3Rldy8xMlV6eGJa?=
 =?utf-8?B?ZTR2MVZJWmk5dGNJeGdKY081UDRDSnBXL3NNK2xhYng2YVhWSkVIcHZlOTg1?=
 =?utf-8?B?ZjlJNFJXYkg2QXpiV2d2dVpDQ1Q1MUpYMVo2bFFxNXFnQnhEcGY4UWJMekpH?=
 =?utf-8?B?dHBVTjJHbXN1RElqMXhiNXVZenJkeHlnWmtGTkdNOFYzV2dmWEhnQ2Q5b25H?=
 =?utf-8?B?TzlZaFZZN0RzWC9vekxsbm9oU1I0aldOcHBYeStmaXZxa2ZNeG5DWXhYQnR6?=
 =?utf-8?B?MnpTU3lhRWtLQ3VmQWxENlBsQ3UvUGJuNWQ5VG9rbUNKOWl3cVgveWtWWUdC?=
 =?utf-8?B?WWptQXoxZ2dkS1F6RWxNcVFQTnRUbllHa1E5eVlOMGdkbGc4YTdmSEptQkFL?=
 =?utf-8?B?OTNKczdLSDYxeWRBaVJ0cmRscUtLOWF3blQ5MnNWdUZEblpDR0p0MW9TU3d3?=
 =?utf-8?B?ekVTNHcvYW1pQjl2YzRnM29QNUdUTllVWnZyYVZxUks0QjY0bWN6cVJVRjV4?=
 =?utf-8?B?bXVEZTJLdFBuMjhaUFVGYWRVYm1WcUNhbkJqUDZVN25LQjVZQjZhT2hjdmsr?=
 =?utf-8?B?TEFrT3pNdUgyQzl3YzNGdDJ1NTFtTVZVdGYyUkFXWXZScFZkRUJ5M2RVa2NL?=
 =?utf-8?B?OHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 708ddeb6-efb4-416d-a8ab-08db42c7af54
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 00:22:41.2172
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zmpt+jZPsGH1qaoyFI4B8Fx0UTxuW3aLCGlz0VGrf13/ieRzzKeCHOEpQX9ZlYps+oJhvCDCDaXgwmoZyzMoDIRs7sQEfu05WdhzQbGep4o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6304
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 4/18/2023 4:45 AM, Ilpo Järvinen wrote:
> show_cache_info() attempts to do calculate the results and provide
> generic cache information. It makes hard to alter the pass/fail
> conditions.

I find the above hard to read. How about:

	show_cache_info() calculates results and provide
	generic cache information. This makes it hard to alter
	pass/fail conditions.


> 
> Separate the the test specific checks into CAT and CMT test files and

"the the" -> "the"

> leave only the generic information part into show_cache_info().
> 

Reinette