Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52d96f37-3068-25c7-4a1a-dcf76a3d0870@intel.com>
Date:   Fri, 21 Apr 2023 17:20:36 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v2 19/24] selftests/resctrl: Pass the real number of tests
 to show_cache_info()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Shuah Khan" <shuah@kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20230418114506.46788-1-ilpo.jarvinen@linux.intel.com>
 <20230418114506.46788-20-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230418114506.46788-20-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUlwWnd1cW1aRTZRVmFZdWpGeUdMYnh4S0hBUlpwSGIzRFRvblhIVDQxQVg1?=
 =?utf-8?B?YWxOODBCNHQxLytQcWlBaWVwMTZLU1B1ZFB5NmZZaHB2YWlwdW9wNFpVa2Jp?=
 =?utf-8?B?ZkdJWTUxYmNiWm44b1JNQ0wrekYwM01uZllHQlNOU1AybU1rU1U5V3AzNllu?=
 =?utf-8?B?VFdYVFVnN0hpYTNRK2R3YW4vYjdyWGVIR3lTQTNRMXR5VGNoWWROLzU2cVIv?=
 =?utf-8?B?MmNKaVkxczJ6ZVh4Wlo0cnZuSGNiajNmeWxWZE5jNXVmbm41eW95UDJRRzFY?=
 =?utf-8?B?RWhXclB5SzRMY1ltY0Q1aWpBS2puVW84dFBJb1Fzekcrd1JJSnBhMmwwQnY4?=
 =?utf-8?B?Rnduc3htRlVpazd3ZW4rT0VuZkJVaEpGanRuNWxGV2xicFc3R0REU1kzejRw?=
 =?utf-8?B?dURaVHdycW1LTXNWU205SkIzdmpHcUF4azZIZS96RlNJY0pjalFzQTkvRm5r?=
 =?utf-8?B?eXgzbXJpUEhpaEd3NjJQTStIOVZ6bGxyeHJrNkpxQmIwQXROZS9pamVnNFpJ?=
 =?utf-8?B?TG0yTll3RW9XejJXdkY5azhabm5SMnRrODR1YzAyNGpYRFg0aVNjbjFnUXk1?=
 =?utf-8?B?QlVZZlVjNUZnV3ZFVzNubEptY0JDNHl6M3pNcTg5V2hOUGZJdUlSdC8vdUhv?=
 =?utf-8?B?aEtvSi9Bak9WSjg1dTl0SEZ2cC9VSkJHbm9IM3RDUGlLTXd4bURpdlR2ZUZq?=
 =?utf-8?B?YXU0cjF1TkxvNUI3MVRrK1lWLzBPTDBicFVHK1krVDJIWWJxM2MzK3I2amRj?=
 =?utf-8?B?YWUycUw3ekt1NkgvbCtUSDJtd2N1c0NOclhCS3pLbG9UbGNvZC9WZVY4ellS?=
 =?utf-8?B?K2U4WjNabWlLeUhlY1V1b1lhS0FubTVTeHAxem5VbXNEelBITXhodjNXdGUy?=
 =?utf-8?B?SUs0UXpBRU4rQ1c4eTdTNHhCZW5QVFoxdEJlQlEyd0JMS3cwbXVoY3dWKzJE?=
 =?utf-8?B?VEs4MmlJZFZjZlc1YU5mYTkweW80SVk1U2xKQmxBNm5qc2RIOG1Qb0NXREdM?=
 =?utf-8?B?OURlcmtUbzJMeGlOL1lkVFJadmFPV0o3b1p6NWZXR0tMSHNyNVNIckxrQVpB?=
 =?utf-8?B?dnZ4SWV2VFdzWnNPSU9jYTFGMTZXYTY4N1crWlhuTkJNM0cxS3dVN25HVG1m?=
 =?utf-8?B?WmZEQ3VjVUpCVTdybWZaUXdCNDRTSC9tQ0pDc3p0MGRIKy9VVGIzVlRLOXJ4?=
 =?utf-8?B?ZGpnVExtWTN1aWlTR3ljRHdCcXhTVDlXN1pDOVdLZi9peUFDWEJMLyt2YUU4?=
 =?utf-8?B?SG93SmlPb3BpZVlhc1RRa3B5bXV4QkRGc3psZlhacHZVcWN3ZVliRmpsU2Nt?=
 =?utf-8?B?cVhDK3plSWplbGdRTHFDQkNEaS9nVEsyMEwrUDR6TnE3VUNuTjAzcmtNRlpG?=
 =?utf-8?B?TGR4T2lTMDBZbFFiajlNeTVaK3R3OGxDUzY2TDg2ZjZVaER1SXlFTEdieGhl?=
 =?utf-8?B?V1ptVFBaZHUwQTFvaDBoN0lkdHdrS2s1cmlrb05nb2xlb0FQR3RJNUhJaFd3?=
 =?utf-8?B?UkV6MDFDUjE0SldxUzg1SHRyUWVteWsyQ0NSK1JVUzdrYmhCUER1cjRZd3dH?=
 =?utf-8?B?Q0tBZTRmK1RRTUFlZFB2UG1NQlNuanpzZUNuRTBhS1IzNWViU0ZBZ0hiOHNj?=
 =?utf-8?B?b0FFcVV2TXJQSWhrbmo0ZFBXNktTd2RUN2JLYVJIZ2xlY0p4T29KcW9hblpD?=
 =?utf-8?B?ZGdyYnd1cStybzQ0d0RWRHFoWmY1OGNiZW0xdmhnT1BCdUNNTmNWaUc1WHZX?=
 =?utf-8?B?anBNNW5YRjJnTU9CdXVIUVFNZjRzbXdzL0I2NWRPZmNNMVBobHBGaFc4Z2JP?=
 =?utf-8?B?c3FwaXc2R21QZnUyRDFtbk50T1p5dFJKVTJzbFNFQm42eE1sUkdaeWR2MWFt?=
 =?utf-8?B?QlNpZFRCUHZrRU12RnNXY2YrQmRxa2lEdCtkOTJVM2FudWdhSVJmWjIxVG9J?=
 =?utf-8?B?T2NIMndVaU5JZndPaTNpSXA1L0x0VzBlaTNSeUlhaUJnRlZrTCsyRWF6eTZs?=
 =?utf-8?B?Yyt3T2NwOG1RQnNORHhnL2N6bHVPRFFYejNzZEZZd0tkMDZSK3prL0tQc0R5?=
 =?utf-8?B?TUczRWJHQWo3MHlPMzduUEpoclIxT1VTYk9WVVplLzZKQlgvUmJJZ1JTNlp1?=
 =?utf-8?B?OHZ0Vk5XYU9VSFNtcnBGN3pFcDk1aWF0VTFycjBNR0lLa0lxMmdYZUZ3OUVW?=
 =?utf-8?B?bXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6162c642-cfa6-4198-e9c8-08db42c766ac
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 00:20:39.3363
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QeLKq5PUrM45h0eASxQTFLV2xbqvliuASABz/LqscnJNRWwoXhQy/MlF3UmKOaD4aX/SRyzw+kyyrLapx3p1a6YjyiwlLejAqvYIXoGjVkU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6304
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 4/18/2023 4:45 AM, Ilpo Järvinen wrote:
> Some results include warm-up tests which are discarded before passing
> the sum to show_cache_info(). Currently, show_cache_info() handles this

Please drop "Currently".

> by subtracting one from the number of tests in divisor. It is a trappy
> construct to have sum and number of tests parameters to disagree like
> this.
> 
> A more logical place for subtracting the skipped tests is where the sum
> is calculated so move it there. Pass the correct number of tests to
> show_cache_info() soit can use directly as the divisor for calculating
> the average.

This is not clear to me. How about "soit can use directly" -> "so it
can be used directly"?

Reinette