Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 22 Apr 2023 12:01:59 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Aaron Lu <aaron.lu@intel.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>,
        "Mel Gorman" <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Tim Chen <tim.c.chen@intel.com>,
        Nitin Tekchandani <nitin.tekchandani@intel.com>,
        Waiman Long <longman@redhat.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] sched/fair: Make tg->load_avg per node
Message-ID: <ZENcN3suKMCaHm1w@chenyu5-mobl1>
References: <20230327053955.GA570404@ziqianlu-desk2>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230327053955.GA570404@ziqianlu-desk2>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Lf1wCJSkBkKhQnl5Y3hQ0+lE6B/jgFui8rituWsYt9LCL9kSz1fhmPE96eBN?=
 =?us-ascii?Q?Q4sHsvv/5srvSnpODnhBUyu+jK3WYFxRNiKYEVZEtQIb/kJtT0zJQcQelu0b?=
 =?us-ascii?Q?UuEuXTR0DX/m0aMsml2+K1oaOqHNruQfHq59pTcvog61QCBtRobMPuZgv/AC?=
 =?us-ascii?Q?kK1Trti16/Bpt1M6U/MQJKQMuUJddHemohB5HkqUeNYWtw629Vz3iKH9V3ms?=
 =?us-ascii?Q?JvQ4ivHIkYC5QOookCEPk9TSB/imOHPJkjDcIlFNN5UfwaRB2jOsCai76ZVf?=
 =?us-ascii?Q?Ci1hG/vp7rpRX9k95Ymv/LBSmC9s3pcv9hBgzhNWIdSv+scVIH+c3kfiy/vW?=
 =?us-ascii?Q?n1MEDgse/DTbWQ+yRT/9g95XSDtVMFYNPNePKYXlU0yDvjlJfs0YFnvIhBuY?=
 =?us-ascii?Q?rLjbXZXDUSO1LK7le8sBM6vqAF2fTRLpP4cDMof2JbL8/GV8RaMT2LnwHJq0?=
 =?us-ascii?Q?T7xfNebmYfPmCxaR2bd438PWSF6kI94GaZVTic6zH94OlvFd33ixRXWD+3Yv?=
 =?us-ascii?Q?IISN1F3sAwew9lxvd82lihrT0p0eeJp/2JBgEINFba7zx2LhpcC7GpDA44Mg?=
 =?us-ascii?Q?YuYfD9RNsxerf8E4XJlfx8T51YFPmiXnGFWwyryvCkiJQDgiuMlAQ7Lh6iZ5?=
 =?us-ascii?Q?vz+mwyawhhmMmm9AhPTEiO4i0nUnvDDLKiqzJUgNjasg3mVC0Rl07fHsTosL?=
 =?us-ascii?Q?Tah2GMSLcg74FZ1ymOYz/sP94tndiDQN8DX3S3xSMIudXwwyO9SPWHiSU+P8?=
 =?us-ascii?Q?UYaxO+YzXBAO8eV4FycpSYScOofSx6slzq9LueZUjIFb58/UM139ZKCoJ/s0?=
 =?us-ascii?Q?ysEpesWtxBygmSM2Z9qdxxBG8NOW3tQgCpF+b3CcvGCdp01+MbO6KcJospNS?=
 =?us-ascii?Q?nrz/1ahtYB1dD2Hi+rrNsnRUCczA/Fymkcf5pIg1bNbVl2qSVfuenXh7I6JZ?=
 =?us-ascii?Q?xb64QXnm7Y3frs2nlgymMBNzrZiCHoYDDv0axtMkQl3sFiLfI4rymsAkEVTs?=
 =?us-ascii?Q?SQNisQ89Gcw6M9wDccJ526zMww9pwcL3o+wj5LVoQGjBZRqbebTRQ3LezrDT?=
 =?us-ascii?Q?+bKt0Gvk1CP1kpyEs6XIZRNo8WcokVyjPMWxXvycv6zTx3LmODHIgIEznXm5?=
 =?us-ascii?Q?bcSCa6h6htJbh5PMPzdD/ls7spQ0bjsAkwwsbssWAruxCMaGhx0K+aGEOXsl?=
 =?us-ascii?Q?HlQ63f064CxWBD5tK7KhqXp8L/XgGTk9JgZ/GdP82x1O26hwWwCIbZX1zAB4?=
 =?us-ascii?Q?oJ5Xmr4HN9ngvvVJGlONJXuS8RZN5q3mFhZtdO6gu9uVjKBhA8BNRMS4u4qI?=
 =?us-ascii?Q?NLqvM9pOay2hQkjiI/QVCH1kyGl6T3bcG2EGon+HUVN9AjgHyTR1enaDrXnq?=
 =?us-ascii?Q?ltiSCvDUqPcY1yVUwxpPgpOFhANpvFzxFQg1e5fmtht3gzwkvR2TIEF4Lzr8?=
 =?us-ascii?Q?r2NtNHs5szOZc3xCcE97Nf1/vsIG3EMEekL5B7D6NyE1Q031Rw/BV0oNorcH?=
 =?us-ascii?Q?t1YeiS8qtX33Lt1ZgRhHLDXkNCHTshdcgkuCLd6iQN0F078dnFfzKrNu5R+5?=
 =?us-ascii?Q?QVPo+4uoLMVunrg4nb5YDyOrDpChIVXDWSkHw3Pp?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 62507b4e-204e-4686-ee0e-08db42e65c9c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2023 04:02:16.9377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mFIaI4ki1LL5i9DzQrYAYgO5P7qBtez3OWtlpdImJQK7W/zqFVUOa4arzmaYpVb4PoXH6PlbVtTpPLt3Jc7rjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5577
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-03-27 at 13:39:55 +0800, Aaron Lu wrote:
> 
> The reason why only cpus of one node has bigger overhead is: task_group
> is allocated on demand from a slab and whichever cpu happens to do the
> allocation, the allocated tg will be located on that node and accessing
> to tg->load_avg will have a lower cost for cpus on the same node and
> a higer cost for cpus of the remote node.
[...]
>  static inline void update_tg_load_avg(struct cfs_rq *cfs_rq)
>  {
>  	long delta = cfs_rq->avg.load_avg - cfs_rq->tg_load_avg_contrib;
> +	int node = cpu_to_node(cfs_rq->rq->cpu);
>  
>  	/*
>  	 * No need to update load_avg for root_task_group as it is not used.
> @@ -3616,7 +3617,7 @@ static inline void update_tg_load_avg(struct cfs_rq *cfs_rq)
>  		return;
>  
>  	if (abs(delta) > cfs_rq->tg_load_avg_contrib / 64) {
> -		atomic_long_add(delta, &cfs_rq->tg->load_avg);
> +		atomic_long_add(delta, &cfs_rq->tg->node_info[node]->load_avg);
When entered enqueue_entity(cfs_rq, se) -> update_tg_load_avg(cfs_rq)
the cfs_rq->rq->cpu is not necessary the current cpu, so the node returned by
cpu_to_node(cfs_rq->rq->cpu) is not necessary the current node as the current
CPU, would atomic_add still introduce cross-node overhead due to remote access
to cfs_rq->tg->node_info[node]->load_avg in this case, or do I miss something?

thanks,
Chenyu