Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 22 Apr 2023 13:55:16 +0200
From:   Olaf Hering <olaf@aepfle.de>
To:     Shradha Gupta <shradhagupta@linux.microsoft.com>
Cc:     linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Long Li <longli@microsoft.com>,
        Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH v2] hv/hv_kvp_daemon: Add support for keyfile config
 based  connection profile in NM
Message-ID: <20230422135516.70a63d96.olaf@aepfle.de>
In-Reply-To: <1682152783-21787-1-git-send-email-shradhagupta@linux.microsoft.com>
References: <=1B[200~<ZDdbfiMD?= =?ISO-8859-1?Q?8iq2OH9s@liuwe-d?=
        =?ISO-8859-1?Q?evbox-debian-v2>
        <1682152783-21787-1-git-send-email-shradhagupta@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/gRWi/P1pLCpKXQRKOsjqL1m";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Content-Transfer-Encoding: 7bit
Precedence: bulk

--Sig_/gRWi/P1pLCpKXQRKOsjqL1m
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Sat, 22 Apr 2023 01:39:43 -0700 Shradha Gupta <shradhagupta@linux.microsoft=
.com>:

> The next part of this support is to let the Distro vendors consume
> these modified implementations to the new configuration format.

The approach taken here makes it difficult to consume the changes.
The way it is implemented means a given variant of the daemon produces
either ifcfg or .nmconnection files. In practice there is a single
source of hv_kvp_daemon.c which is compatible with all versions of a distro.

IMO the new feature should be implemented such that hv_kvp_daemon=20
writes both files. Then the tooling can decide which of the files will
actually be used.


I think the configuration file for NetworkManager should have the
suffix .nmconnection, even if it may not be mandatory.

Olaf

--Sig_/gRWi/P1pLCpKXQRKOsjqL1m
Content-Type: application/pgp-signature
Content-Description: Digitale Signatur von OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmRDyyUACgkQ86SN7mm1
DoCPvhAApdGUJobGH4vFtZ34rhTNOoEpTdQ5fTc6qcxjPjvukenex2hx5f3eum4Y
e3/cdubySB3rdf9QJOBEc0KeEf9wMMTsnL6doa7Ib8HAqhd7Ul1Cf4aJR5qq+YMH
gzNwftsjlHC1/78g1Up07rMcsiYj9uwnxCVrD0DCJljEU1bcoPNKw5BE+ATo0jVH
sLxg58DRes60Ylq1pHocj6TC10UN1tXio5cSpxmKvGmiATh4IX1eUoLTPArPZ6qg
k5WrQmy07/Ck49pZwJ6UzXqr/gfKdaRWCZf19+MzOhvdHCiOxHjVM3cxlMpJjcj2
njR2BNK+/eWJF9vbrQBv9Q1WCC8DQO3jKJTzA5VUHGjboChyKn7vtlMjNIQQNc2B
p5/HrqjZ+Ny1nyjDNQAyDF8g19jJV7VE5wnqSPrDThliVwuyfWGk8rYIX6xvWFde
XOT1Ers4Xj48U82y2iMsa4JkTuBhvyZWVCo66P9jiQb2cLFk4a0qA1Xd/8mAEPEl
nVy8diAcVIXRlSL1STexZzDNEkvPyp5x0nVxXSLzstiebbZOCLPDpoVHOKwGK3EX
G6U7BNr6AdnmOJn6dryM8nbhA6FZotF123+aT/7vTGuAOQtOMv8YBoOxGH52n6Wg
L8SRw1AkwJ2AUg8a0xOh0iQqzmQz3KugduYKI9blfkEsK9pmq90=
=HkRI
-----END PGP SIGNATURE-----

--Sig_/gRWi/P1pLCpKXQRKOsjqL1m--