Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <99b71397-9d51-4cfa-533b-992369b74541@linaro.org>
Date:   Sat, 22 Apr 2023 14:20:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8992-libra: drop duplicated
 reserved memory
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230420180746.860934-1-krzysztof.kozlowski@linaro.org>
 <20230420180746.860934-3-krzysztof.kozlowski@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230420180746.860934-3-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 20.04.2023 20:07, Krzysztof Kozlowski wrote:
> There are two entries for similar reserved memory: qseecom@cb400000 and
> audio@cb400000.  Keep the qseecom as it is longer.
> 
>   Warning (unique_unit_address_if_enabled): /reserved-memory/audio@cb400000: duplicate unit-address (also used in node /reserved-memory/qseecom@cb400000)
> 
> Fixes: 69876bc6fd4d ("arm64: dts: qcom: msm8992-libra: Fix the memory map")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Maybe the original intention was to use different address for audio res.
> memory?
> ---
Similar story to patch 2, I'll recheck on a device
soon(tm)

Konrad
>  arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts b/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts
> index 501e05efbef4..133f9c2540bc 100644
> --- a/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts
> @@ -110,11 +110,6 @@ rmtfs_mem: rmtfs@ca100000 {
>  			qcom,client-id = <1>;
>  		};
>  
> -		audio_mem: audio@cb400000 {
> -			reg = <0 0xcb000000 0 0x400000>;
> -			no-mem;
> -		};
> -
>  		qseecom_mem: qseecom@cb400000 {
>  			reg = <0 0xcb400000 0 0x1c00000>;
>  			no-mem;