Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <235c2ebc-ca9b-8765-0914-fcd839f1e45c@zhaoxin.com>
Date:   Sun, 23 Apr 2023 07:11:49 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2] UHCI:adjust zhaoxin UHCI controllers OverCurrent bit
 value
Content-Language: en-US
To:     Alan Stern <stern@rowland.harvard.edu>
CC:     <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <tonywwang@zhaoxin.com>,
        <weitaowang@zhaoxin.com>, <stable@vger.kernel.org>
References: <20230421174142.382602-1-WeitaoWang-oc@zhaoxin.com>
 <a55aa38d-0fbf-4a95-a2b2-40821815275f@rowland.harvard.edu>
From:   "WeitaoWang-oc@zhaoxin.com" <WeitaoWang-oc@zhaoxin.com>
In-Reply-To: <a55aa38d-0fbf-4a95-a2b2-40821815275f@rowland.harvard.edu>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/4/21 22:59, Alan Stern wrote:
> On Sat, Apr 22, 2023 at 01:41:42AM +0800, Weitao Wang wrote:
>> OverCurrent condition is not standardized in the UHCI spec.
>> Zhaoxin UHCI controllers report OverCurrent bit active off.
>> In order to handle OverCurrent condition correctly, the uhci-hcd
>> driver needs to be told to expect the active-off behavior.
>>
>> Suggested-by: Alan Stern <stern@rowland.harvard.edu>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Weitao Wang <WeitaoWang-oc@zhaoxin.com>
>> ---
>> v1->v2
>>   - Modify the description of this patch.
>>   - Let Zhaoxin and VIA share a common oc_low flag
>>
>>   drivers/usb/host/uhci-pci.c | 9 +++++----
>>   1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/host/uhci-pci.c b/drivers/usb/host/uhci-pci.c
>> index 3592f757fe05..034586911bb5 100644
>> --- a/drivers/usb/host/uhci-pci.c
>> +++ b/drivers/usb/host/uhci-pci.c
>> @@ -119,11 +119,12 @@ static int uhci_pci_init(struct usb_hcd *hcd)
>>   
>>   	uhci->rh_numports = uhci_count_ports(hcd);
>>   
>> -	/* Intel controllers report the OverCurrent bit active on.
>> -	 * VIA controllers report it active off, so we'll adjust the
>> -	 * bit value.  (It's not standardized in the UHCI spec.)
>> +	/* Intel controllers report the OverCurrent bit active on.  VIA
>> +	 * and ZHAOXIN controllers report it active off, so we'll adjust
>> +	 * the bit value.  (It's not standardized in the UHCI spec.)
>>   	 */
> 
> The style we use now for multi-line comments is:
> 
> 	/*
> 	 * Blah blah blah
> 	 * blah blah blah
> 	 */
> 
>> -	if (to_pci_dev(uhci_dev(uhci))->vendor == PCI_VENDOR_ID_VIA)
>> +	if (to_pci_dev(uhci_dev(uhci))->vendor == PCI_VENDOR_ID_VIA ||
>> +		to_pci_dev(uhci_dev(uhci))->vendor == PCI_VENDOR_ID_ZHAOXIN)
> 
> The indentation level of the continuation line should be different from
> the indentation of the statement below.  Otherwise it looks like the
> continuation line is part of the conditional block.
> 
I see, Thanks for your careful examination. I'll change it later.

Best Regards,
Weitao

> Alan Stern
> 
>>   		uhci->oc_low = 1;
>>   
>>   	/* HP's server management chip requires a longer port reset delay. */
>> -- 
>> 2.32.0
>>
> .