Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp3841034rwr; Sat, 22 Apr 2023 13:12:02 -0700 (PDT) X-Google-Smtp-Source: AKy350aJjq+yINukx5rwH4DaSj3SFgp92FtAT/Drgk4Czb4CyW4xy5jtVZHDYc6Dya9HSdKH9TUe X-Received: by 2002:a17:903:41c6:b0:19e:94ff:6780 with SMTP id u6-20020a17090341c600b0019e94ff6780mr11108049ple.6.1682194321728; Sat, 22 Apr 2023 13:12:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682194321; cv=none; d=google.com; s=arc-20160816; b=qJ/ztB95ty8w7knIKubEMIjKJNMLoJ/tpD6mhaLJdswSJJ7qqmdqSFQET13KMBERa+ 9hRFQE0l/5JfcxWi4mJzE/bnsfTL2hD+ZPxthiWmTnKiX1EJ6Ocf5OoaHf6hZn7tTXra jY6qkdew9Z8JribVWtyK7d5EPOhh93B0623KJZcaWHrQOxdDbKeHQPzoNjpwzv27rfBQ r0ftqqEwbdFlTvfc4OSsJCH+s0rL976MS6vY1ISIVPIE3EKY0By44ukTYi49ynB6Bf3c PZ38Idg1+mWuIjOAgle23+HVyCSHkVNFznEwA1SsupEtlPTDfhClfQdzCNfxPsanwGWq belg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=X9yZH5jobw+2NxtflHbFeViB++WpgYUG8lLecB6Yof4=; b=PFvYJ3wOQT1udj31nrNoDM1TJkiGDGnprh0j4B/zA20RteFoyN2feKWtbGLOALA3L8 AGuP8+Z4XAdf3XwA8X3NWoHuD7s7HUAARQq34Qhbq63VkABUZeSvyEolzHU0EsImbLWU 9uBl/52GM2j5JGm+fvaFVYqzPl89mC7SUwWFC1t9Y4ho0d16Fa41O9Mi21SgSjI70VXi Cd+I773YisMEWZUp5G6bbSLKFS3A/i/NF2iA0DlktHkKAwGg8vyDPiybVyZWLQ9Tpu0L B9BkFKhJF+ww9zDWwNT3EyRrcSUlegG80G/OVs0PDGEEzA4zmRLb+K7a783ie2FyOeAi qn5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CtthS9Ys; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w1-20020a1709026f0100b001a64b603189si6849576plk.100.2023.04.22.13.11.46; Sat, 22 Apr 2023 13:12:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CtthS9Ys; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229804AbjDVT4s (ORCPT + 99 others); Sat, 22 Apr 2023 15:56:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229797AbjDVT4q (ORCPT ); Sat, 22 Apr 2023 15:56:46 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9462E19A6 for ; Sat, 22 Apr 2023 12:56:44 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f196e8e2c6so11850915e9.1 for ; Sat, 22 Apr 2023 12:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682193403; x=1684785403; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X9yZH5jobw+2NxtflHbFeViB++WpgYUG8lLecB6Yof4=; b=CtthS9YsA6btqa4JO6vI8qG6Ei18swg2oPFg8KSHXvYFTzsNah2B3GZZ2DkXLIK3Bu WM0pmmAqy8lmu8V5P5lBn6SpKmEQLfSQRnN9RvwhNc6BvTCdoCQ0A8lMUYzZCukwctyR aHCIqkRnqpEv6uttQW+6QMeoM+SujZq10TVVXX8rdWR6DXNqDEHeemDTMcLHjoTM9FqD doVI7jomezoHjx23hxLkDztftgUtxd1JXMvb2eIKQW5Ntoilq1SiNUJUzrOmd9GQkQoP hzz2hmyx516OXcG72SALiwE7+ltPW0o7cRxRdqn5nMsGaCPULJuP4JTnjbysaF57fbUW 1L/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682193403; x=1684785403; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X9yZH5jobw+2NxtflHbFeViB++WpgYUG8lLecB6Yof4=; b=StesO1l4gAnEQEp3hFEMJtNHfqYkLTYkbdicA9vDU3Dn4gPa5oyxj0YigpWhIFKExq ONHeDZsfSjlQDwxlccZjNIpNze2MJKIGybvoxCCw89hu1Qzvg8E+KHk9ueK/+L5HNv91 UFSojeUNKDfonhv5rRv8WJGHwwVfKaxRbF+Ww066Z8Np0/o1/jBxIxYalQJ8al5qapbJ LsSYtmuEnsojC8mLTbr/QNOzASeF+5kG5y61srRlDMstnsvNcQNNeMlyl5p1wedCtzgk kfp9haUYx97AOxwh7xMV2+TFT5Ofj+TjL4VX+IVR87vHnnWWbRiSTQdyeSeFmc2mArVY ecSg== X-Gm-Message-State: AAQBX9d8155irkGUhRBeYGAkmw24egsgoufj30uWSZ1JFZNnXBWt28pS 6QrAmqToIm0tnPpSP4jI7VqXoA== X-Received: by 2002:adf:e2c8:0:b0:2ef:bc0b:e70 with SMTP id d8-20020adfe2c8000000b002efbc0b0e70mr7197653wrj.54.1682193403110; Sat, 22 Apr 2023 12:56:43 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id i3-20020adff303000000b002f4cf72fce6sm7206104wro.46.2023.04.22.12.56.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Apr 2023 12:56:42 -0700 (PDT) Date: Sat, 22 Apr 2023 22:56:39 +0300 From: Dan Carpenter To: Dan Carpenter Cc: Dongliang Mu , Vicki Pfau , kernel-janitors@vger.kernel.org, Dmitry Torokhov , Pavel Rojtberg , Nate Yocom , Mattijs Korpershoek , John Butler , Matthias Benkmann , Christopher Crockett , Santosh De Massari , hust-os-kernel-patches@googlegroups.com, syzbot+a3f758b8d8cb7e49afec@syzkaller.appspotmail.com, "Pierre-Loup A. Griffais" , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: xpad - fix GPF in xpad_probe Message-ID: References: <20230414125603.686123-1-dzm91@hust.edu.cn> <011c00e7-c351-4331-8be4-1c184d5773e1@kili.mountain> <3ccc85bd-0541-4ffb-a207-dfc533a2c0aa@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 22, 2023 at 10:48:32PM +0300, Dan Carpenter wrote: > The warnings from this are quite promising. Well... The results are over 90% false positives. But there are still probably 15 bugs in there. The printk warning trick would probably work. regards, dan carpenter