Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <38eff1f50343a576edd115be9283f6bd28bd2008.camel@gmail.com>
Subject: Re: [PATCH 3/4] net/ftgmac100: add mac-address-increment option for
 GMA command from NC-SI
From:   Ivan Mikhaylov <fr0st61te@gmail.com>
To:     Rob Herring <robh@kernel.org>
Cc:     Samuel Mendoza-Jonas <sam@mendozajonas.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Paul Fertser <fercerpav@gmail.com>,
        openbmc@lists.ozlabs.org
Date:   Sun, 23 Apr 2023 01:02:17 +0000
In-Reply-To: <20230418185445.GA2111443-robh@kernel.org>
References: <20230413002905.5513-1-fr0st61te@gmail.com>
         <20230413002905.5513-4-fr0st61te@gmail.com>
         <20230418185445.GA2111443-robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-04-18 at 13:54 -0500, Rob Herring wrote:
> On Thu, Apr 13, 2023 at 12:29:04AM +0000, Ivan Mikhaylov wrote:
> > Add s32 mac-address-increment option for Get MAC Address command
> > from
> > NC-SI.
> >=20
> > Signed-off-by: Paul Fertser <fercerpav@gmail.com>
> > Signed-off-by: Ivan Mikhaylov <fr0st61te@gmail.com>
> > ---
> > =C2=A0Documentation/devicetree/bindings/net/ftgmac100.txt | 4 ++++
> > =C2=A01 file changed, 4 insertions(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt
> > b/Documentation/devicetree/bindings/net/ftgmac100.txt
> > index 29234021f601..7ef5329d888d 100644
> > --- a/Documentation/devicetree/bindings/net/ftgmac100.txt
> > +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt
> > @@ -22,6 +22,10 @@ Optional properties:
> > =C2=A0- use-ncsi: Use the NC-SI stack instead of an MDIO PHY. Currently
> > assumes
> > =C2=A0=C2=A0 rmii (100bT) but kept as a separate property in case NC-SI=
 grows
> > support
> > =C2=A0=C2=A0 for a gigabit link.
> > +- mac-address-increment: Increment the MAC address taken by GMA
> > command via
> > +=C2=A0 NC-SI. Specifies a signed number to be added to the host MAC
> > address as
> > +=C2=A0 obtained by the OEM GMA command. If not specified, 1 is used by
> > default
> > +=C2=A0 for Broadcom and Intel network cards, 0 otherwise.
>=20
> This would need to be common. There's been some attempts around how
> to=20
> support a base MAC address with a transform per instance. So far it's
> not clear that something in DT works for everyone. Until there's=20
> something common (if ever), you need platform specific code somewhere
> to=20
> handle this. The nvmem binding has had some extensions to support
> that.
>=20
> Rob

Rob, I agree but unfortunately there isn't a generic option for such
case, maybe something should be added into net/ethernet-
controller.yaml? As example, `mac-address-increment` option using
widely in openwrt project. About nvmem, are we talking `nvmem-cell-
names` option or reverse_mac_address in drivers/nvmem/imx-ocotp.c?

I'll do the transfer into DT schema, that's not a problem but after
naming resolve.

Adding openbmc community, maybe they have some ideas about this one.

Thanks.