Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <58a984d3-a89d-89d4-2491-a559bc8b1076@linux.dev>
Date:   Sun, 23 Apr 2023 10:56:30 +0800
MIME-Version: 1.0
From:   Guoqing Jiang <guoqing.jiang@linux.dev>
Subject: Re: [PATCH for-next v2 2/3] RDMA/rtrs: Fix the last iu->buf leak in
 err path
To:     Li Zhijian <lizhijian@fujitsu.com>, haris.iqbal@ionos.com,
        jinpu.wang@ionos.com, jgg@ziepe.ca, leon@kernel.org,
        linux-rdma@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <1682213212-2-1-git-send-email-lizhijian@fujitsu.com>
 <1682213212-2-3-git-send-email-lizhijian@fujitsu.com>
Content-Language: en-US
In-Reply-To: <1682213212-2-3-git-send-email-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/23/23 09:26, Li Zhijian wrote:
> The last iu->buf will leak if ib_dma_mapping_error() fails.

Fixes: c0894b3ea69d("RDMA/rtrs: core: lib functions shared between 
client and server modules")

> Signed-off-by: Li Zhijian<lizhijian@fujitsu.com>
> ---
> V2: new patch to address memory leaking
> ---
>   drivers/infiniband/ulp/rtrs/rtrs.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs.c b/drivers/infiniband/ulp/rtrs/rtrs.c
> index 4bf9d868cc52..3696f367ff51 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs.c
> @@ -37,8 +37,10 @@ struct rtrs_iu *rtrs_iu_alloc(u32 iu_num, size_t size, gfp_t gfp_mask,
>   			goto err;
>   
>   		iu->dma_addr = ib_dma_map_single(dma_dev, iu->buf, size, dir);
> -		if (ib_dma_mapping_error(dma_dev, iu->dma_addr))
> +		if (ib_dma_mapping_error(dma_dev, iu->dma_addr)) {
> +			kfree(iu->buf);
>   			goto err;
> +		}
>   
>   		iu->cqe.done  = done;
>   		iu->size      = size;

Good catch, Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev>

Thanks,
Guoqing