Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 23 Apr 2023 10:08:37 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH] MIPS: uprobes: Restore thread.trap_nr
Message-ID: <ZEShNUil0gsVlrDo@debian.me>
References: <1682213883-3654-1-git-send-email-yangtiezhu@loongson.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="O7Is9K1MZxESaB/k"
Content-Disposition: inline
In-Reply-To: <1682213883-3654-1-git-send-email-yangtiezhu@loongson.cn>
Precedence: bulk


--O7Is9K1MZxESaB/k
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 23, 2023 at 09:38:03AM +0800, Tiezhu Yang wrote:
> thread.trap_nr is saved in arch_uprobe_pre_xol(), it should be restored
> in arch_uprobe_{post,abort}_xol() accordingly, actually it was only done
> in the post function, just do it in the abort function too, this change
> is similar with x86 and powerpc.

I'm confused (please fix up grammar, spelling, and punctuation). Can you
explain why thread.trap_nr should be restored somewhere else? Also, what
x86/powerpc changes as reference?

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--O7Is9K1MZxESaB/k
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZEShMQAKCRD2uYlJVVFO
o7JPAQCKqSaf6wOMWWRmqM4AeXMOR0pUHFOq5zLSBrenErDLQQEApLxOMi2vHQnN
LJVZgZBTHH2kHDtlkofiZXWfxh6TxAs=
=yyT7
-----END PGP SIGNATURE-----

--O7Is9K1MZxESaB/k--