Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        "'Rob Herring'" <robh+dt@kernel.org>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <20230421190202.15471-1-krzysztof.kozlowski@linaro.org>
Subject: RE: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl
 configuration
Date:   Sun, 23 Apr 2023 10:36:11 +0530
Message-ID: <340901d975a1$53de6ad0$fb9b4070$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQGoG4MPsMzRMzzdGHd0mLCSi9wmTAIxB2sIr4mDHrA=
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20230421190209epcas5p1ad0aa67d1b9d19f746f42412c4424f15@epcas5p1.samsung.com>
        <20230421190202.15471-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Saturday, April 22, 2023 12:32 AM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl
> configuration
> 
> The camera's pinctrl configuration is simply empty and not effective.
> Remove it to fix dtbs_check warnings like:
> 
>   s5pv210-torbreck.dtb: camera@fa600000: pinctrl-0: True is not of type
> 'array'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/s5pv210.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi
> b/arch/arm/boot/dts/s5pv210.dtsi index d9436bbf77c8..faa3682ab5dd
> 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -549,8 +549,6 @@ i2c1: i2c@fab00000 {
> 
>  		camera: camera@fa600000 {
>  			compatible = "samsung,fimc";
> -			pinctrl-names = "default";
> -			pinctrl-0 = <>;
>  			clocks = <&clocks SCLK_CAM0>, <&clocks
> SCLK_CAM1>;
>  			clock-names = "sclk_cam0", "sclk_cam1";
>  			#address-cells = <1>;
> --
> 2.34.1