Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b9d8632d-7b42-58bf-5849-0291909f3819@intel.com>
Date:   Sun, 23 Apr 2023 13:37:24 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 00/21] Enable CET Virtualization
Content-Language: en-US
To:     Mike Rapoport <rppt@kernel.org>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <peterz@infradead.org>,
        <john.allen@amd.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <rick.p.edgecombe@intel.com>
References: <20230421134615.62539-1-weijiang.yang@intel.com>
 <ZEMGA2uUfpJL4rMH@kernel.org>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZEMGA2uUfpJL4rMH@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVVDMGVma1VPajJFQ1dyRGdMdzRSRE1FR1RXTS9nVHozeng1NDIySGJLVi9t?=
 =?utf-8?B?OU5rY1g5VVlaNmoxNU5Ta3RCaFNLWE81UWlseHY5ang5dlRocDlIUG1vMTlH?=
 =?utf-8?B?aUhSd05iaDRidTZnQ0pmNzRuaVUzVW1hN2pSdFhUSjFHMnhWSFRQYW1mTVcv?=
 =?utf-8?B?cjZJYUE0K09rblNTV0VhNS9aVGFlZm0zSWwzcm5BYnd3V20wb0ZPZFRXbkhv?=
 =?utf-8?B?a1J3QWNWWDgrNm0vc2NlbmpzMHR4REwrazBHZTVaQndIckZwNmpWSHJkeUp2?=
 =?utf-8?B?RGI2R1FXZVhNTXBuTlBUUVp1SnFQU2UwZmlpUDI4NUdNVHNPZVdaUnhadExh?=
 =?utf-8?B?cUwrc3grcks5a2VVZXVldlBLcjZkWDZzS3VISUJaZEI3RTQzeFZjUDZsMWtq?=
 =?utf-8?B?L2I0WHNBbEZzNHg5ZGFqbEl0Tkh4UUVpRmVUNGN0T2d6cko4SGJBc3VLRFpI?=
 =?utf-8?B?SE92N0JMWWsyZEwrR0U1bE1TUHQ4d1gxR0U5MTlucFUvTHdDN0VaMnpoczNM?=
 =?utf-8?B?bXREMzZFWlNXMGhqNTJuV1N4cWxpb1VPcjl3RkQxWXRqUE9EWXZCNGhuQWN6?=
 =?utf-8?B?QXNEQnhBbEpzQUhhWlArV0x2TUdtU2FMcUxlREhkbnBuKzAyQWRZNGZTNThM?=
 =?utf-8?B?d0RNb1Qva3ZmWjNMak5CK2JSMTNNTEpoOUxSSEdLUzhVR3hnUkhXdlZxV0lV?=
 =?utf-8?B?MWRmZUgwT2xjOTk2NGlabVZESnFoVHp4ZHk1WmlOL2t4V3N6UUZsNEExVmxh?=
 =?utf-8?B?eHlYTEprcWRwNFJBSHliL3R3aWpEdE95L2MyT1N3b1VHSzRmb3lVcWlwaTE3?=
 =?utf-8?B?V2wveEhwNnBjeW9aeGZUUDRVTzZLcTEwaHAxa2VoRVJTOWVyK2xzaXV1N2dh?=
 =?utf-8?B?ckpqQmJWL0FFRFY5UXplcG8zd3FIdVpmNkZidzg4aTM3S3V4MEt6c2x6NVly?=
 =?utf-8?B?dnZXcndQY0NVOWxHWFJRcFdTcWRSc1hKb0tQNUlBdEN2MktxYkd6RjZWUGtw?=
 =?utf-8?B?KzBETUZ6Wk9CRm50dFdhakt5bWljbkFYNVBhSjdrSFNVNXlseDh0dE1McTdv?=
 =?utf-8?B?NFp3Q2M4bldNemg0cUFEOThNZjIrS1FCeU5MOGhKK3ExbGRNV2ZCV284TmtP?=
 =?utf-8?B?VWxjMmlZZ0hDUUZLSE5wRkFXNDF6aGZsZmU2emJONnlETUp2cElHUlAwNVdn?=
 =?utf-8?B?S1JXT2hPZTNmZW10UEU2Q1ZhL3U3NHU4MTdJYVQvZEEvSlpGbFdPYkp1UFZq?=
 =?utf-8?B?QzFtUCtPNGJncnNGK1BWd29MMzRtNjgwcCtKelAva3pkL0p6azNhQmxMVkM4?=
 =?utf-8?B?TllqdHUvSVZYY3dUZ2NFcEFBMHljSXplSWROYVN4Y0tmTlJmajc5N3c5UUw2?=
 =?utf-8?B?UU5lY285elFPZkJENUFXYVltZlRSaUV6WCtycVEvOU9OZVhvMXc5NTBSdC9K?=
 =?utf-8?B?REJ5TzkwUWJYczZsemtHc056bHJraC8wL1dwenVXVjFuWXBQUU1HUTcwOGNw?=
 =?utf-8?B?NG5ibmt3V3lialpuRVB6WFJESmRLTm1oVXVhdVVHa1lQUndpYVdsK3RpL3Ur?=
 =?utf-8?B?RCszWEEzaVhDSGZuZE9CbytnZk12WDVUL2N6QlNaV0RsR1hDZW1sc0J1cGE0?=
 =?utf-8?B?aFd5aXhmWk5WejhzSTVpWEdlSWpOOS94TmxuVFZCUDFtOXdMc21CTVY3Z21P?=
 =?utf-8?B?dENRc056R0Noc2h6TzhhQ0VnWVhRSXZmYStwaGRiM1F4U3h2bG9xb1ZYMjNj?=
 =?utf-8?B?SUtNaHEwWXEzSko1c1duZzgvQy9wMVBhbkZaQzZsdXpqZXQ1dDRNVTFTeW8x?=
 =?utf-8?B?Z3hUYlYvbW52d0NSYzUxa1N1OGRnVUo0V0h6L2ZTNnhDNjluc0sxMkxRR3JQ?=
 =?utf-8?B?czFjTG5xSC8zbGs1bXh2bnFRRmdadlg5U080elZ3RHR6ekphTitLd2lnbmRo?=
 =?utf-8?B?b1lrMzFZeVJoaXVyOE9lZ0RIdlZLRnAvbXZtNkh5YmgyWHNUbS84TlNwNGs2?=
 =?utf-8?B?OWRsS1p0SGFGeWc5MHE2c0R2Zk1Db3RwUGZwUUtXdWtldXNKUE1vSGVkUjBX?=
 =?utf-8?B?UWVNYnppd1JOQjM0WmFlRlNwMEpvaXMraWU4NlgwcytLVkxsM2RKNWRrUmxD?=
 =?utf-8?B?ZEgyWm5OM2JiV2N2eXZZU2dHai9JUWl3dVRIRzZuSi9UODVsMnlPWEEwSzdj?=
 =?utf-8?B?SUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 58fa7b70-0f6f-41a9-02f2-08db43bcd640
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2023 05:37:33.4820
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4DnJlUDPqGbZ7wIcGgyTPfZF3Q40tqwR5JPw6kH+yt9GvOGtJ/YOPwawPPWlZjQciXUOrMW0SZCJBlRTKOSKGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8243
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/22/2023 5:54 AM, Mike Rapoport wrote:
> Hi,
>
> On Fri, Apr 21, 2023 at 09:45:54AM -0400, Yang Weijiang wrote:
>> [...]
>>
>> [1]: linux-next: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/?h=next-20230420
>> [2]: QEMU patch: https://lore.kernel.org/all/20230421041227.90915-1-weijiang.yang@intel.com/
>> [3]: v1 patchset: https://lore.kernel.org/all/20220616084643.19564-1-weijiang.yang@intel.com/
>> [4]: Rebase branch: https://github.com/kvm-x86/linux.git, commit: 7b632f72528d (tag: kvm-x86-next-2023.04.14)
>   
> I played a bit with KVM support for shadow stacks on AMD machines and I
> rebased v1 patches along with John's SVM series
>
> https://lore.kernel.org/kvm/20221012203910.204793-1-john.allen@amd.com/
>
> on top of v6.3-rc4 and Rick's series for host shadow stack support. I've
> put this at
>
> https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git/log/?h=shstk/kvm
>
> if anybody is interested. With this I could successfully run shadow stack
> self test in a guest on an AMD Zen3 machine.
>
> One thing I've noticed while rebasing is that John's patches move
> cet_is_msr_accessible() from vmx/ to x86.c and I also had to make such move
> for cet_is_ssp_msr_accessible().
>
> Would make sense to have them available for both VMX and SVM from the
> start.

Hi, Mike,

Yes, it makes sense to do so. I'll include the change in next version so 
that John's patchset can

omit the work, thanks!

[...]