Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 23 Apr 2023 10:08:24 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Wim Van Sebroeck <wim@linux-watchdog.org>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] watchdog: s3c2410_wdt: Use Use
 devm_clk_get[_optional]_enabled() helpers
Message-ID: <20230423080824.7u2ydmmwk4jdbobm@pengutronix.de>
References: <20230304165653.2179835-1-linux@roeck-us.net>
 <20230306091048.mfrpexle24t6nwzy@pengutronix.de>
 <20230418065603.rzpiazzw4upitynt@pengutronix.de>
 <20230422112229.GA23896@www.linux-watchdog.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ii4dxdi23ndnywjj"
Content-Disposition: inline
In-Reply-To: <20230422112229.GA23896@www.linux-watchdog.org>
Precedence: bulk


--ii4dxdi23ndnywjj
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 22, 2023 at 01:22:29PM +0200, Wim Van Sebroeck wrote:
> Hi Uwe,
>=20
> > Hello,
> >=20
> > On Mon, Mar 06, 2023 at 10:10:48AM +0100, Uwe Kleine-K=F6nig wrote:
> > > On Sat, Mar 04, 2023 at 08:56:52AM -0800, Guenter Roeck wrote:
> > > > The devm_clk_get[_optional]_enabled() helpers:
> > > >     - call devm_clk_get[_optional]()
> > > >     - call clk_prepare_enable() and register what is needed in orde=
r to
> > > >       call clk_disable_unprepare() when needed, as a managed resour=
ce.
> > > >=20
> > > > This simplifies the code and avoids the calls to clk_disable_unprep=
are().
> > > >=20
> > > > While at it, use dev_err_probe consistently, and use its return val=
ue
> > > > to return the error code.
> > > >=20
> > > > Cc: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > >=20
> > > Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> >=20
> > This patch is in next now as b05a2e58c16c47f3d752b7db1714ef077e5b82d9.
> > My name occurs twice in the tag area, once it is mangled as
> >=20
> > 	Uwe Kleine-K=3DF6nig
> >=20
> > I would welcome fixing that (i.e. s/=3DF6/=F6/). When this commit is
> > touched, you can also do s/Use Use/Use/ in the Subject.
>=20
> Fixed.

Looking at the output of

	git range-diff b05a2e58c16c47f3d752b7db1714ef077e5b82d9...9b31b1ea125ca2e7=
34ae89badc0c3073b4445842

it looks good to me now.

Thanks
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--ii4dxdi23ndnywjj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmRE53cACgkQj4D7WH0S
/k51MQf9GQenHNrdE5Chnn1T7wY3+ZaqeHuRUzF2W9AeBfOx6mq5o86ClrpDoMWI
jKPWe/2g5KGNmjYbpmnVAaujc3XscQM8znRYmJE5m/vkKKbbWoaqgP+dVQPhIImz
+GitDdLYnV5E9nHqWuLB2ajsqsWcvI9bIcHsvsfGaD3BVKzwMaxjWAQoZtoZvG6V
jZ5dcFhcnmZgOMSwK2nCMj5SXHEYPczFTpDB00aXZ1hBLsxfEUUuz5iZeOfCCGrs
DqoNF3l29Lji9IsINO6BTnroOoKqVIckgaKGwB8HRFiF4CKhEX+6pOZT3tweu13b
4Lp2sZKvLM37rgHgChQMRaZ5hVXZXA==
=hwCc
-----END PGP SIGNATURE-----

--ii4dxdi23ndnywjj--