Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230324020838.67149-1-zhanggenjian@kylinos.cn> <20230406191204.GZ19619@twin.jikos.cz>
In-Reply-To: <20230406191204.GZ19619@twin.jikos.cz>
From:   genjian zhang <zhanggenjian123@gmail.com>
Date:   Sun, 23 Apr 2023 17:21:53 +0800
Message-ID: <CAOd03yRsQATvvnV=U-RZvuKXrio-Wb-+nFZiYN45CgeEYOgWgw@mail.gmail.com>
Subject: Re: [PATCH] btrfs: fix uninitialized variable warning
To:     dsterba@suse.cz
Cc:     clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Genjian Zhang <zhanggenjian@kylinos.cn>,
        k2ci <kernel-bot@kylinos.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 7, 2023 at 3:12=E2=80=AFAM David Sterba <dsterba@suse.cz> wrote=
:
>
> On Fri, Mar 24, 2023 at 10:08:38AM +0800, Genjian wrote:
> > From: Genjian Zhang <zhanggenjian@kylinos.cn>
> >
> > compiler warning:
> >
> > ../fs/btrfs/volumes.c: In function =E2=80=98btrfs_init_new_device=E2=80=
=99:
> > ../fs/btrfs/volumes.c:2703:3: error: =E2=80=98seed_devices=E2=80=99 may=
 be used uninitialized in this function [-Werror=3Dmaybe-uninitialized]
> >  2703 |   btrfs_setup_sprout(fs_info, seed_devices);
> >       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > ../fs/btrfs/send.c: In function =E2=80=98get_cur_inode_state=E2=80=99:
> > ../include/linux/compiler.h:70:32: error: =E2=80=98right_gen=E2=80=99 m=
ay be used uninitialized in this function [-Werror=3Dmaybe-uninitialized]
> >    70 |   (__if_trace.miss_hit[1]++,1) :  \
> >       |                                ^
> > ../fs/btrfs/send.c:1878:6: note: =E2=80=98right_gen=E2=80=99 was declar=
ed here
> >  1878 |  u64 right_gen;
> >       |      ^~~~~~~~~
> >
> > Initialize the uninitialized variables.
> >
> > Reported-by: k2ci <kernel-bot@kylinos.cn>
> > Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
>
> The warnings are still reported by other build reports so I'll apply
> this patch. If you have found more please send a patch or I can update
> this one once applied. Thanks.

Sorry for the late reply.
At present, only this one has been found.
Thanks.