Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yan Wang <rk.code@outlook.com>
To:     linus.walleij@linaro.org, brgl@bgdev.pl
Cc:     Yan Wang <rk.code@outlook.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-gpio@vger.kernel.org (open list:GPIO SUBSYSTEM),
        linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v1] gpio: mmio: restroe get multiple gpio mask
Date:   Sun, 23 Apr 2023 17:06:48 +0800
Message-ID: <KL1PR01MB544800D7E51C9209A9BD998BE6669@KL1PR01MB5448.apcprd01.prod.exchangelabs.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: KL1PR01MB5448:EE_|SEYPR01MB5076:EE_
X-MS-Office365-Filtering-Correlation-Id: a549ac5a-8928-45d5-52d5-08db43da2312
X-MS-Exchange-SLBlob-MailProps: 70qbaZjg4mut0ZTEc/+RhwzsFjQD3otITfzPgwyCuh3DXz2qZZ6IBn1SP72dI6E6t9fdYxuEdZ7617P3ZbTzk/OpEuBrRoQtedzx591hTrW/KUdpUINc6ZLcigV6Z+TxPigBSpPZdNX47KLla6VgHT3WqtkPvhfypKShd7qJh7AbBPKVCrmhqVaSb1en8xpi6Dnv/I7MWLzof9d4TMwycHEuPxAZbbnGu5z5cE+wvKcVaeT0yayS9szhqj8pg/r7WE+dVxVSydNyVS9SqmVzlDlfEI2yeiMm2nidnt5Qrh1LTXepE5+sNMJXXWHUwT5W5544ZGiZQIqY2gWTrpnhKM5U1StISPXOISFGsZsepvxcQRGd/ROmpQfDm3NQgcdys/Vjt6MH5vVjAfdxkiwjXP9WQ9jeaZ//W6lHts0J/ScTGVW7fZH4qCSwijUt2OG2+NiRTjKTpryg0lHcrMTP2u90FvGegAwidCq/UFhUf0H9tG3ZER/8/asrjZDlXVoMgtT9LDmOctxPaVFlsLcGA1oFZl8JPDn59XEuIeJmjYwvWQQopAQEIsZIoSvdb7wFeaIYmF1hdm+8Q2frgt5zzMpufU5tcwAiP9XMAoWHsPVv+pRE0zUhjwhKyn0G+NzcE8RYs/Tve0EdVYY6uf/U9ljYSSok//t+lRUwu5e7+9tEjIXd1g0ZYGZC/yZW+nifidmWsWUFuLXb5FgAu8fofdvrDyLQLcHMNuzma8DI7GACGSg47wKSlA==
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: V0rmyYpytac58hvR7AB9YL3GzhYVY4AmmDsVUSXJVx9ZWni7IS6YeUDJXYWzSwBtaWIFKv7BKvLmxyu1Qe0K+8wlPSNs7TC0Y3N8hiXuIoYAZOQBgDI3slvsWKIWKKMGF/gbn5yMtFNY4shkvq0hcJ/OVeGdc9s9GvuNRkZ5Ig3jb4UIQQGq0sDesQbNT3C/Or5Hk6SvJzwxrHZSk8/iiKVLpKLuW5zwUTvVFiXD2fHUYGWdW4EBbfog/4Bk8A5Ox1rew0R0S5yVmwgaBiBs1NGEeEIBaReY3AQYytkEWwRrodFYW/bYwgflok/bg1svcdNak46KIoVug3+J58tNs04v63jzJ073wptiYLYES4tZQMs6kPeePEFjAlfNVJzyEdVGHCIT7BqeHNeggQGJ5rRKq4l76TeS3T3s0TWDUXD0UHILhqYly4h0vkuZr/Fkiuq7X3eOfyChOiZkzBLF1qHI+Drwe0zdqmK4KIymrbLqOPPIzrz4MJLUzAUB02hm9KLnSIUWktSnQNpOFdmZ0h3fusLxuGoogR6OESsmkM+upX6WTMvckMNQpvvFaoE43TwTrWHRlWOvI+G6cmPJumBpC+xMgljSkmHgGdOBEUPs/GClnKXYNOxSSUR109JA
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VkuU7TOKo0FBWvDuue1hYYt8m5EwHVsDjpiBo3dzfbCBPoX1gRVQ4nt+c9cR?=
 =?us-ascii?Q?Bf4AMuto82outasOc4NVP9XW1Szny1KI1UkyOGDLQ8+FZHT47JFD2gRKl3++?=
 =?us-ascii?Q?HuLXtoY+w6qrE8ZvWz/nN7QsEUNGn2QxK9OcvVPo1vp0SV1rh0EK3njA2hiZ?=
 =?us-ascii?Q?UBOToJvAyajkrO19ySAzv521LNq8PSviiSaj43iRnsotwgx3oWynywSiIeb1?=
 =?us-ascii?Q?Z4dmOESlE40RkCKXKnRwGBBUyQaXVk9fXAXFMQ67nGGeHD1Y34HLHU7cJwXg?=
 =?us-ascii?Q?b5PJxYZPCb0VNu3hUrYzSEpEeaYDGCzPdRVlzgKpAC11fowWoPhd2UDrbqhn?=
 =?us-ascii?Q?juYYwonc3kDaTr3kv8+yvJ1S256Va3Lo+kg9le5gEWSs6N3GmiXDLGjq0c/8?=
 =?us-ascii?Q?oiUtneKyaJAnJGHhBDmaNEDTdaXT+GCznF9vCBxtIGZ2NbKdzyPFpWrFG7V3?=
 =?us-ascii?Q?hS2VTDb9ZMVUwUilcpV0nawMo9nOMYzro2bIGcKo874XxomyRvxjYKEF0kRP?=
 =?us-ascii?Q?LC9/GAeUUkzsLh9kITNyutMUsCEjyWHFQ75MBwgYW+BfuDEvgreOL8RiYhTJ?=
 =?us-ascii?Q?psMksfnpzod1xrzdI2Ynj6ZHHnUAdawawDX7Mwu/h1rW7ABuHfo+8GftMYif?=
 =?us-ascii?Q?RAXyiHvXF4v/ijHG4F1kQRhnJazz99bQSo2wQc66S1sg3LpTX9Owg+t2ZNzo?=
 =?us-ascii?Q?jaS8cAJZKu8QDjXbuABLInbG5EUlkoxqcmgUTnJLYkLiP5n3W5x30AHY5FZ5?=
 =?us-ascii?Q?AWg71pHpdZMRnUoYqUjcPF6kkYVIqR6GyVBXVtbJWGqD0f25OeIk8rFxC1UP?=
 =?us-ascii?Q?EyrDmD6nxFn0DZmXIPj3ikXnuGz6DQx4YhKmrrvBQAqTCA9IEriC5vsxikNW?=
 =?us-ascii?Q?Y+i25Gy6wESgqFn12VAG6hFC4o2AySORwA/zidStE9Tpu0OEvhs38f9TAqO0?=
 =?us-ascii?Q?+Sw3QA4B1BBqr7T6GrvBzHObBMVrGD3i7xjJ41jgm7Lbb+GTPeLbXpMMwoU4?=
 =?us-ascii?Q?4xKQkdLXOpyqWmRZKc0Sk1YIaIe0JGpFRNAUsFG4HVHaVHBFWWRBuik/xqlj?=
 =?us-ascii?Q?XZhXtJgS/RndZMJbAkknNe5tHPOEsjH9V9LywgzyZHcatE2RcgHNHmXzN5Hu?=
 =?us-ascii?Q?e+Hph3Az+lEA9fIZVZwuexVVZLNj6Fp4nBWYcaaZc8Cd+LbZxdqjWE85o0Q4?=
 =?us-ascii?Q?A/gno1onA5plNqBGEvxhlGyV/ixMKbwjsjP6EA=3D=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a549ac5a-8928-45d5-52d5-08db43da2312
X-MS-Exchange-CrossTenant-AuthSource: KL1PR01MB5448.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2023 09:07:17.5956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR01MB5076
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Simplify the code,should not modify its logic.

Fixes: 761b5c30c206 ("gpio: mmio: replace open-coded for_each_set_bit()")
Signed-off-by: Yan Wang <rk.code@outlook.com>
---
 drivers/gpio/gpio-mmio.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
index d9dff3dc92ae..c2347ef3a4df 100644
--- a/drivers/gpio/gpio-mmio.c
+++ b/drivers/gpio/gpio-mmio.c
@@ -271,10 +271,14 @@ static void bgpio_multiple_get_masks(struct gpio_chip *gc,
 	*clear_mask = 0;
 
 	for_each_set_bit(i, mask, gc->bgpio_bits) {
-		if (test_bit(i, bits))
-			*set_mask |= bgpio_line2mask(gc, i);
-		else
-			*clear_mask |= bgpio_line2mask(gc, i);
+		if (*mask == 0)
+			break;
+		if (__test_and_clear_bit(i, mask)) {
+			if (test_bit(i, bits))
+				*set_mask |= bgpio_line2mask(gc, i);
+			else
+				*clear_mask |= bgpio_line2mask(gc, i);
+		}
 	}
 }
 
-- 
2.17.1