Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] MIPS: uprobes: Restore thread.trap_nr
To:     Bagas Sanjaya <bagasdotme@gmail.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
References: <1682213883-3654-1-git-send-email-yangtiezhu@loongson.cn>
 <ZEShNUil0gsVlrDo@debian.me>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        loongson-kernel@lists.loongnix.cn, Oleg Nesterov <oleg@redhat.com>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <f99fe71d-cd97-e641-d637-5e7efbcad5f5@loongson.cn>
Date:   Sun, 23 Apr 2023 18:39:38 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <ZEShNUil0gsVlrDo@debian.me>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Cc:
Oleg Nesterov <oleg@redhat.com>
Srikar Dronamraju <srikar@linux.vnet.ibm.com>

On 04/23/2023 11:08 AM, Bagas Sanjaya wrote:
> On Sun, Apr 23, 2023 at 09:38:03AM +0800, Tiezhu Yang wrote:
>> thread.trap_nr is saved in arch_uprobe_pre_xol(), it should be restored
>> in arch_uprobe_{post,abort}_xol() accordingly, actually it was only done
>> in the post function, just do it in the abort function too, this change
>> is similar with x86 and powerpc.
>
> I'm confused (please fix up grammar, spelling, and punctuation). Can you
> explain why thread.trap_nr should be restored somewhere else? Also, what
> x86/powerpc changes as reference?
>

Here is the related first commit for x86 in 2012:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0326f5a94dde

When xol insn itself triggers the signal, restart the original insn,
in this case, UTASK_SSTEP_TRAPPED is set [1], it does *abort_xol()
instead of *post_xol() [2], then should do the restore operations.

Maybe Oleg and Srikar could give more detailed backgrounds, thank you.
https://lore.kernel.org/lkml/1682213883-3654-1-git-send-email-yangtiezhu@loongson.cn/

[1] 
https://elixir.bootlin.com/linux/latest/source/kernel/events/uprobes.c#L1980
[2] 
https://elixir.bootlin.com/linux/latest/source/kernel/events/uprobes.c#L2268

Thanks,
Tiezhu