Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp4647214rwr; Sun, 23 Apr 2023 09:53:58 -0700 (PDT) X-Google-Smtp-Source: AKy350bnkkOnCQ2n+x5yWAljSMXsmdXh6mIem6ecJKFlKpKJXs6qoeN1QR0lxCCSjEZotMUHS+6I X-Received: by 2002:a05:6a00:2d88:b0:63d:2d99:2e7c with SMTP id fb8-20020a056a002d8800b0063d2d992e7cmr15422065pfb.0.1682268838165; Sun, 23 Apr 2023 09:53:58 -0700 (PDT) Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 186-20020a6206c3000000b0063b645b66f1si8807934pfg.193.2023.04.23.09.53.45; Sun, 23 Apr 2023 09:53:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbjDWQwI convert rfc822-to-8bit (ORCPT + 99 others); Sun, 23 Apr 2023 12:52:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbjDWQwH (ORCPT ); Sun, 23 Apr 2023 12:52:07 -0400 Received: from sender4-of-o54.zoho.com (sender4-of-o54.zoho.com [136.143.188.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A304D1700; Sun, 23 Apr 2023 09:51:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682268691; cv=none; d=zohomail.com; s=zohoarc; b=TDvOVESMjGmWlfE+WFR/cR+WIMkP8LjtZl8X/EOhxIVBUWYhBA3hbRRy+olssxzFEqxnPihlbFHOxCwu/Dx2wCyfS9DTT1fw13AavhAPgpqr1zF2vSGtHHL0UjxsLOd94BH3b+2P/CW19f2vkSrMkAUVhlaafBPEe0Rj4Aln8bU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682268691; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ofL67ii9Y+tEPSfR0GkCHJbUwNmfduXzcboKTmRkSOM=; b=jZntl0lVp0sn7BcsToPiQLTp4L+SE3QDJu0WJzFt3UmI4+saJZ2F7ZkSTS11YjiMglW+JOKfYDqXOkc8VQof5INJIdPSVdm97cIIDMXMoc/l987EMjibrBdYxRetddy19BfooY1VX3FgzidDlL1zTL+dxC5Ggq75hk6NaaSF0n8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=linux@mniewoehner.de; dmarc=pass header.from= Received: from z3r0.lan (31.187.91.190 [31.187.91.190]) by mx.zohomail.com with SMTPS id 1682268688138119.18977178360944; Sun, 23 Apr 2023 09:51:28 -0700 (PDT) Message-ID: Subject: Re: [PATCH v11 00/14] TPM IRQ fixes From: Michael =?ISO-8859-1?Q?Niew=F6hner?= To: Jarkko Sakkinen , Lino Sanfilippo Cc: peterhuewe@gmx.de, jgg@ziepe.ca, stefanb@linux.vnet.ibm.com, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, jandryuk@gmail.com, pmenzel@molgen.mpg.de, l.sanfilippo@kunbus.com, lukas@wunner.de, p.rosenberger@kunbus.com In-Reply-To: References: <20221124135538.31020-1-LinoSanfilippo@gmx.de> <4c094418-7725-b815-f1f9-8b12f1ac4d72@gmx.de> <20230319135338.c7k6r3ws6lby5qgv@kernel.org> <87d022be08cf911178cfb8182598a1689b050845.camel@mniewoehner.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Sun, 23 Apr 2023 18:51:23 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.44.4 X-ZohoMailClient: External X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_ADSP_ALL, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2023-04-23 at 18:40 +0300, Jarkko Sakkinen wrote: > On Sun Apr 23, 2023 at 6:36 PM EEST, Michael Niewöhner wrote: > > On Sun, 2023-04-23 at 17:15 +0300, Jarkko Sakkinen wrote: > > > On Sat Apr 22, 2023 at 3:59 AM EEST, Lino Sanfilippo wrote: > > > > Hi, > > > > > > > > On 21.04.23 18:50, Jarkko Sakkinen wrote: > > > > > > > > > > > > > > I tested this with libvirt/QEMU/swtpm and did the following tests: > > > > > > > > > > 1. TPM 1.2 suspend/resume. > > > > > 2. TPM 2.0 kselftest. > > > > > 3. TPM 2.0 suspend/resume + kselftest. > > > > > > > > > > I see no issues so I can pick this for my pull request. > > > > > > > > > > Tests were performed on top of v6.3-rc7. > > > > > > > > > > For all: > > > > > > > > > > Tested-by: Jarkko Sakkinen > > > > > > > > > > BR, Jarkko > > > > > > > > Thats great, thanks a lot for testing this! > > > > > > Thanks for the patience! I'm sorry it took so long but at least all the > > > steps in v11 make perfect sense and I see nothing that would rise red > > > flags. So we can land this with good confidence I think. > > > > > > BR, Jarkko > > > > I wonder, if it makes sense to submit this patch series to longterm and/or > > at > > least stable? > > it's a feature, so I don't think so. > > BR, Jarkko IMO it's a fix of a incomplete/broken implementation of that feature. I mean, the code even tested for interrupts and printed an error. It was just missed to enable them (TPM_CHIP_FLAG_IRQ).