Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230405195927.13487-1-ddrokosov@sberdevices.ru> <20230405195927.13487-7-ddrokosov@sberdevices.ru>
In-Reply-To: <20230405195927.13487-7-ddrokosov@sberdevices.ru>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Sun, 23 Apr 2023 23:30:38 +0200
Message-ID: <CAFBinCBGWOB2XLb6su=R3W684rKdK3pOgPFsCGx+Oyo_pgdeBg@mail.gmail.com>
Subject: Re: [PATCH v13 6/6] clk: meson: a1: add Amlogic A1 Peripherals clock
 controller driver
To:     Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc:     neil.armstrong@linaro.org, jbrunet@baylibre.com,
        mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, khilman@baylibre.com,
        jian.hu@amlogic.com, kernel@sberdevices.ru, rockosov@gmail.com,
        linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 5, 2023 at 9:59=E2=80=AFPM Dmitry Rokosov <ddrokosov@sberdevice=
s.ru> wrote:
[...]
> +static const struct of_device_id a1_periphs_clkc_match_table[] =3D {
> +       { .compatible =3D "amlogic,a1-clkc", },
> +       {},
nit-pick: please remove the comma after the sentinel

> +MODULE_DEVICE_TABLE(of, a1_periphs_clkc_match_table);
> +
> +static struct platform_driver a1_periphs_clkc_driver =3D {
> +       .probe =3D meson_a1_periphs_probe,
> +       .driver =3D {
> +               .name =3D "a1-clkc",
> +               .of_match_table =3D of_match_ptr(a1_periphs_clkc_match_ta=
ble),
I wonder if we should drop of_match_ptr() here as no other meson clock
driver uses it.
Also there's commits like 00cb754ac622 ("clk: imx8mq: drop
of_match_ptr from of_device_id table") which explicitly remove it from
other drivers.

Apart form these two this patch looks great to me.


Best regards,
Martin