Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Hao Ge <gehao618@163.com>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH V2] fs: fix undefined behavior in bit shift for SB_NOUSER
Date:   Mon, 24 Apr 2023 13:43:33 +0800
Message-Id: <FA638ECE-96E4-4898-A457-76A621BE1860@163.com>
References: <20230424050158.GN3390869@ZenIV>
Cc:     Hao Ge <gehao@kylinos.cn>, brauner@kernel.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <20230424050158.GN3390869@ZenIV>
To:     Al Viro <viro@zeniv.linux.org.uk>
Precedence: bulk


> On Apr 24, 2023, at 13:02, Al Viro <viro@zeniv.linux.org.uk> wrote:
>=20
> =EF=BB=BFOn Mon, Apr 24, 2023 at 12:51:22PM +0800, Hao Ge wrote:
>> Shifting signed 32-bit value by 31 bits is undefined, so changing
>> significant bit to unsigned. The UBSAN warning calltrace like below:
>=20
>> UBSAN: shift-out-of-bounds in fs/nsfs.c:306:32
>> left shift of 1 by 31 places cannot be represented in type 'int'
>> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.3.0-rc4+ #2
>> Call trace:
>> <TASK>
>> dump_backtrace+0x134/0x1e0
>> show_stack+0x2c/0x3c
>> dump_stack_lvl+0xb0/0xd4
>> dump_stack+0x14/0x1c
>> ubsan_epilogue+0xc/0x3c
>> __ubsan_handle_shift_out_of_bounds+0xb0/0x14c
>> nsfs_init+0x4c/0xb0
>> start_kernel+0x38c/0x738
>> __primary_switched+0xbc/0xc4
>> </TASK>
>>=20
>> Fixes: e462ec50cb5f ("VFS: Differentiate mount flags (MS_*) from internal=
 superblock flags")
>> Signed-off-by: Hao Ge <gehao@kylinos.cn>
>=20
> *snort*
>=20
> IMO something like "spotted by UBSAN" is more than enough here -
> stack trace is completely pointless.
>=20
> Otherwise, no problems with the patch - it's obviously safe.
Thanks for taking time to review this patch.
I fully agree with your suggestion, as it is not just this one place that re=
ported this error, although they are the same reason.
I will remove stack trace and send v3.