Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Apr 2023 15:32:36 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Zeng Guang <guang.zeng@intel.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        H Peter Anvin <hpa@zytor.com>, <kvm@vger.kernel.org>,
        <x86@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] KVM: x86: Virtualize CR4.LASS
Message-ID: <ZEYwlMmzYnJjNNHq@chao-email>
References: <20230420133724.11398-1-guang.zeng@intel.com>
 <20230420133724.11398-2-guang.zeng@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230420133724.11398-2-guang.zeng@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZqltEdXtD0vJtswM8UWb4d07UJKpIPlZey2wvszaAGEkz6G6CLVQTUuxnVqm?=
 =?us-ascii?Q?Jw6EPH/PKtHois4qwA/hWKVcNw20fXt/EIGY1JCj4i4ny86b2IAq1NkG2L86?=
 =?us-ascii?Q?/L+jkBlXCPEa7Mh1sATNw3R0ycllfJsg+1jq4bi4exy9G0z7rpTOpgbZepV3?=
 =?us-ascii?Q?8JNb8dMNtwyo9wmnrI7b+SeT20Mt7/2dsCP7LuW25DPVlhvLc9FW0JadulA7?=
 =?us-ascii?Q?7Y+UlHkRdNsbIqrjGP5BQ6feEXSMgdk2Jxb8o8Eig7fhNmOmCJiLJQ/HQ9pQ?=
 =?us-ascii?Q?4GtErFCBtqOmqqlz+etMxJ0yqhBNbTRAg65qerb4g1b34f7HjA79rZjsB7Ws?=
 =?us-ascii?Q?9IyHMpoMtJ+8pTwk5wT7w63O0vTRizBloBRP9SnVXb3dq6GsBq1rUz0H0aWQ?=
 =?us-ascii?Q?it4vvJkUVMHMMC4KVBuPlyTjWJ099MC2e+i1Ejta9HbpuP6JiKMje4Gnybe+?=
 =?us-ascii?Q?DaDIJCE/JO3NU5qzKNnhw2PYiU3qe0gF2kuMtAn63aqFL1W8rVEYGjavqlhw?=
 =?us-ascii?Q?7gSYs09Lz3f8u1D/wMzd7PVI+NeZees8qATjvdFSdnXeX6ZiWLkQ1lekIliE?=
 =?us-ascii?Q?9Wr/O+W84Qjp4rMwxDb7d4JamDLF4IBacYpR11AOyBT+FU95sZclnjz5zfWh?=
 =?us-ascii?Q?V8vyF+fjNxHdKG6M7a1q1E9/6LPxG2ItT+At4NXpTzf3i/r0RGasLip2R/Tc?=
 =?us-ascii?Q?c2oKcsiiKAuz4gn4WKK5xTBRyjfFGXX6o+lc3oVgYIVFwqfWnWC1GNH9fuqn?=
 =?us-ascii?Q?iZPQ7pRw48WhsatM60SGBS6/S+CDCfdSaqm8xlzJwYWJazkY3kegdG9ENQCj?=
 =?us-ascii?Q?pCftItB72KssL0C0piDIir0xGAxQeFijg2WCh4GCPV+fBTvkN2kCLUE43kXP?=
 =?us-ascii?Q?ibvCK4GEYo6w0ygp/O4YN06c+IEu3ZdSkYmvka+KWkvPN5pubzQq7UvG440V?=
 =?us-ascii?Q?XrlPQWl37vjlSaLC1vht7Dxhs9LOqxZd+YRLgPpktpmUghIqKO15Q8mUP09F?=
 =?us-ascii?Q?459VUrSt+Pvnc0IW8BKXZ3wtooB5zCA/9gfNQVNUcHNS6mmUSjI5daE7Hv5m?=
 =?us-ascii?Q?hrq4d4Wn8WwiEcEQuW3Z5vYnjKSie1b4W7vsVc2E85ldRQqTfhVB4ukEmpPG?=
 =?us-ascii?Q?ZR8h5Y86/nXlJa9OjfqwAx56s9CoFnv6B3OElglm8AEnCGMXCZXDW91xwm0y?=
 =?us-ascii?Q?myHseZ5dpVEY7hjwjx7sWI5uPFjQcQyYg3LgL+Zjyh6ac+6ibzvkmwSehqpo?=
 =?us-ascii?Q?Z0x82UKTpVLJmDEkS9zfOh2uOu/yS2/zMyhtk19eceGREx3n2F46TyrLSJ6R?=
 =?us-ascii?Q?CFPHKwfXJunhkt7KVi+z59DNl4OSwUzYNm45pt9KCjdks0KjOhRdEjAmwsBI?=
 =?us-ascii?Q?CUAYHT5om8MIVMMOVxM+2d8JLj1ny+v4KC7QeEHzm/yS9ay+QoWxWNL9diaF?=
 =?us-ascii?Q?OVwTMKg/xVCs8JHc/IXwT2iU+5wiMvInubRG3z7bdlQSaeUqnPf5PbP6noXZ?=
 =?us-ascii?Q?15acBGOddrqKzDHdWAyMFg4uYmDfY7u+EOMN7fw+7ICwIeLC/BuVSvGswkg3?=
 =?us-ascii?Q?8d0ziC+WpWAOuBtcfEVfOoPT5EUQeW2WcN32wiNz?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 982a6008-7a35-4e39-1f76-08db44961953
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 07:32:46.6790
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S8gSL+m6pgly7snN871PUQIIW8OwKzWiZmXHN2pZGSWXqxb/4/vchN3JducpvwUdtI9iBwoE7eptKi6v9HERAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5645
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 20, 2023 at 09:37:19PM +0800, Zeng Guang wrote:
>Virtualize CR4.LASS[bit 27] under KVM control instead of being guest-owned
>as CR4.LASS generally set once for each vCPU at boot time and won't be
>toggled at runtime. Besides, only if VM has LASS capability enumerated with
>CPUID.(EAX=07H.ECX=1):EAX.LASS[bit 6], KVM allows guest software to be able
>to set CR4.LASS.

>By design CR4.LASS can be manipulated by nested guest as
>well.

This is inaccurate. The change in nested_vmx_cr_fixed1_bits_update() is
to allow L1 guests to set CR4.LASS in VMX operation. I would say:

Set the CR4.LASS bit in the emulated IA32_VMX_CR4_FIXED1 MSR for guests
to allow guests to enable LASS in nested VMX operation.