Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jiri Olsa <olsajiri@gmail.com>
Date:   Mon, 24 Apr 2023 09:38:35 +0200
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     Jiri Olsa <olsajiri@gmail.com>, linux-trace-kernel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        Florent Revest <revest@chromium.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Will Deacon <will@kernel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Martin KaFai Lau <martin.lau@linux.dev>, bpf@vger.kernel.org
Subject: Re: [PATCH v5 4/9] tracing/probes: Add tracepoint support on
 fprobe_event
Message-ID: <ZEYx+2WWixBkDbTn@krava>
References: <168198993129.1795549.8306571027057356176.stgit@mhiramat.roam.corp.google.com>
 <168198997089.1795549.1009510263722958117.stgit@mhiramat.roam.corp.google.com>
 <ZEThQgkJV7esVGdR@krava>
 <20230423223740.9f1186a08b3b316b5a0156e7@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230423223740.9f1186a08b3b316b5a0156e7@kernel.org>
Precedence: bulk

On Sun, Apr 23, 2023 at 10:37:40PM +0900, Masami Hiramatsu wrote:
> On Sun, 23 Apr 2023 09:41:54 +0200
> Jiri Olsa <olsajiri@gmail.com> wrote:
> 
> > On Thu, Apr 20, 2023 at 08:26:10PM +0900, Masami Hiramatsu (Google) wrote:
> > > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > > 
> > > Allow fprobe_event to trace raw tracepoints so that user can trace
> > > tracepoints which don't have traceevent wrappers. This new event is
> > > always available if fprobe event is enabled since the tracepoint is
> > > disabled, trace-event and dynamic event is also not available.
> > 
> > I thought of ftrace tracepoints wrappers as standard in distros,
> > could you specify which config options that involves?
> 
> Ah, sorry, I'm completely confused you.
> 
> ----
> This new event is always available if fprobe event is enabled. If the
> tracepoint is disabled, trace-event and dynamic event including
> fprobe is also not available.
> ----

so this basically adds another way of attaching to tracepoint through ftrace
dynamic_events file interface.. but we can already attach to tracepoints
through ftrace via /sys/kernel/debug/tracing/events/* right?

I'm trying to find out what's the config for which this new way of attaching
tracepoints is useful

thanks,
jirka

> 
> > 
> > > +	if (trace_fprobe_is_tracepoint(tf)) {
> > > +		struct tracepoint *tpoint = tf->tpoint;
> > > +		unsigned long ip = (unsigned long)tpoint->probestub;
> > > +		/*
> > > +		 * Here, we do 2 steps to enable fprobe on a tracepoint.
> > > +		 * At first, put __probestub_##TP function on the tracepoint
> > > +		 * and put a fprobe on the stub function.
> > > +		 */
> > > +		ret = tracepoint_probe_register_prio_may_exist(tpoint,
> > > +					tpoint->probestub, NULL, 0);
> > > +		if (ret < 0)
> > > +			return ret;
> > > +		return register_fprobe_ips(&tf->fp, &ip, 1);
> > 
> > nice idea
> 
> Thanks!
> 
> 
> > 
> > jirka
> > 
> > > +	}
> > > +
> > >  	/* TODO: handle filter, nofilter or symbol list */
> > >  	return register_fprobe(&tf->fp, tf->symbol, NULL);
> > >  }
> > > @@ -699,6 +723,12 @@ static void __unregister_trace_fprobe(struct trace_fprobe *tf)
> > >  	if (trace_fprobe_is_registered(tf)) {
> > >  		unregister_fprobe(&tf->fp);
> > >  		memset(&tf->fp, 0, sizeof(tf->fp));
> > > +		if (trace_fprobe_is_tracepoint(tf)) {
> > > +			tracepoint_probe_unregister(tf->tpoint,
> > > +					tf->tpoint->probestub, NULL);
> > > +			tf->tpoint = NULL;
> > > +			tf->mod = NULL;
> > > +		}
> > >  	}
> > >  }
> > 
> > SNIP
> 
> 
> -- 
> Masami Hiramatsu (Google) <mhiramat@kernel.org>