Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Apr 2023 10:41:23 +0100
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     Tom Rix <trix@redhat.com>
Cc:     mark.rutland@arm.com, lpieralisi@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: smccc: set variables
 smccc_soc_id_version,revision storage-class-specifier to static
Message-ID: <20230424094123.suueva23r4njjbfg@bogus>
References: <20230423153428.3938525-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230423153428.3938525-1-trix@redhat.com>
Precedence: bulk

On Sun, Apr 23, 2023 at 11:34:28AM -0400, Tom Rix wrote:
> smatch reports
> drivers/firmware/smccc/smccc.c:20:21: warning: symbol
>   'smccc_soc_id_version' was not declared. Should it be static?
> drivers/firmware/smccc/smccc.c:21:21: warning: symbol
>   'smccc_soc_id_revision' was not declared. Should it be static?
> 
> These variables are only used in their defining file so should be static
>

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

Since the patch introducing this issue comes from irqchip tree, we must
either route this through that if they have earlier fixes set or wait
until v6.4-rc1 and send it through SoC tree. Please cc soc@kernel.org and
Marc Z and repost. It is better to be explicit and mention it is either
based on -next or mention the commit introducing the issue since it make
no sense if one has no knowledge of -next change.

-- 
Regards,
Sudeep