Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp5418810rwr; Mon, 24 Apr 2023 04:04:26 -0700 (PDT) X-Google-Smtp-Source: AKy350bxlSrnFlFzGokwffSjNb59xhiYfGsXYjah2AvgckdDEns2semESkdxwSTlRIA7CbCWqSpB X-Received: by 2002:a17:902:d4d1:b0:1a1:e308:a82e with SMTP id o17-20020a170902d4d100b001a1e308a82emr17035286plg.12.1682334266090; Mon, 24 Apr 2023 04:04:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682334266; cv=none; d=google.com; s=arc-20160816; b=Z0PI6pE6/e/QG+mtl7SRjZ61nxT8VeWlldM5l1+3UnXw3wTqgvYdysjzVOiVow+ypc bsrg3Ivio+de1k7YW5t4/y4dKX0B029ILpsXW01PAmoxyPh2FP5zz+ozbk/8KjzTaY0f lXdL+sNPlIOJec5nK7oiCoW1p6aS4Wcp/EhBorFlyw25nDTSufqW/BsuKORDcebmx+m2 b2ih8lvun4FeVBFzZQWcsKYzLeUaNLFABZ7i4E8KdcsmVw1CanPhbcKvHznYSqW88V2Q ctq5Pmh7bmrPK7bEapgMvEV7I+fCgdrJGWfrqnKQzHHcDqWRx5s82GdnlCOBoa3Q3VT+ CnNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=CYOW5SwSipHHV+X7QbtEojz+lV7M6qJUJrxoVMPpv3Q=; b=rlEO8u9tO8ktaC3MP/gTLcfVOdRIVDjVAab3SBnXihgyiJqI4XF6drN3P/AyRbbvjy RawrQwpEqeXEs0Rg9noRHCbVge6y5TSOfUu6h22arHK3+otMsu+icPamTWU0upnOevSD FlhHAVhxMIgLCRIojq+J75nWkCcvRFkjnqpcZpX7lEn5gjmgCrAjL4uZp3KventguDL6 SFPnY3Kydo9tKbCiYStklLy/BXe5NUbbuXqFs7AHGooCoorzk9NVzQiyOMsn12QE4QZ4 PQpk2uwIw0PAoWDwZJmljRklKiuK42u1V7PrPat8dYPL3H9rbWOS/N7YeBL7xeZBdE6A Uz7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u3-20020a170902e80300b001a979141a24si2296343plg.214.2023.04.24.04.03.50; Mon, 24 Apr 2023 04:04:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231667AbjDXLAG (ORCPT + 99 others); Mon, 24 Apr 2023 07:00:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231620AbjDXLAE (ORCPT ); Mon, 24 Apr 2023 07:00:04 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A93DE211F; Mon, 24 Apr 2023 04:00:02 -0700 (PDT) Received: from pride-poweredge-r740.. ([172.16.0.254]) (user=lihuya@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 33OAxja5026652-33OAxja6026652 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 24 Apr 2023 18:59:45 +0800 From: lihuya To: Thinh Nguyen , Greg Kroah-Hartman Cc: hust-os-kernel-patches@googlegroups.com, lihuya , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND] usb: dwc3: remove dead code in dwc3_otg_get_irq Date: Mon, 24 Apr 2023 18:59:31 +0800 Message-Id: <20230424105930.49944-1-lihuya@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-FEAS-AUTH-USER: lihuya@hust.edu.cn X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_get_irq() only return non-zero irq number on success, or negative error number on failure. There is no need to check the return value of platform_get_irq() to determine the return value of dwc3_otg_get_irq(), removing them to solve this problem. Signed-off-by: lihuya --- drivers/usb/dwc3/drd.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c index 039bf241769a..c2e09700212d 100644 --- a/drivers/usb/dwc3/drd.c +++ b/drivers/usb/dwc3/drd.c @@ -154,11 +154,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc) goto out; irq = platform_get_irq(dwc3_pdev, 0); - if (irq > 0) - goto out; - - if (!irq) - irq = -EINVAL; out: return irq; -- 2.34.1